Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhong Li <lizhong1008@gmail.com>
To: "Xiang, Haihao" <haihao.xiang@intel.com>
Cc: "Socek, Daniel" <daniel.socek@intel.com>,
	"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] qsvenc_hevc: Enable look ahead with ExtBRC
Date: Sun, 19 Dec 2021 23:55:19 +0800
Message-ID: <CAMmEu78G7NP+4VYMxWpG1NsrqfZD6UCtMCOe4iX1-UDrLFBBhQ@mail.gmail.com> (raw)
In-Reply-To: <3f453501701823b89754e529d06734c446dfafc8.camel@intel.com>

Xiang, Haihao <haihao.xiang@intel.com> 于2021年12月6日周一 11:09写道:
> > --- a/libavcodec/qsvenc_hevc.c
> > +++ b/libavcodec/qsvenc_hevc.c
> > @@ -248,6 +248,7 @@ static const AVOption options[] = {
> >      { "tile_rows",  "Number of rows for tiled
> > encoding",      OFFSET(qsv.tile_rows),    AV_OPT_TYPE_INT, { .i64 = 0 }, 0,
> > UINT16_MAX, VE },
> >      { "recovery_point_sei", "Insert recovery point SEI
> > messages",       OFFSET(qsv.recovery_point_sei),      AV_OPT_TYPE_INT, { .i64
> > = -1 },               -1,          1, VE },
> >      { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud),
> > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE},
> > +    { "look_ahead_depth", "Depth of look ahead in number frames",
> > OFFSET(qsv.look_ahead_depth), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 100, VE },
> >
> >      { NULL },
> >  };
>
> Any comment for this patch ? Could someone help to merge this patch if no
> objection ?

How to verify this function? is it depended on a special version of
MSDK && vaapi-driver?
I tried to enable extbrc and disable/enable look_ahead_depth (set to
zero/20) for hevc_qsv but found there are no difference of the encoded
files.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

       reply	other threads:[~2021-12-19 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211009015949.1510-1-haihao.xiang@intel.com>
     [not found] ` <3f453501701823b89754e529d06734c446dfafc8.camel@intel.com>
2021-12-19 15:55   ` Zhong Li [this message]
2021-12-20  5:52     ` Xiang, Haihao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMmEu78G7NP+4VYMxWpG1NsrqfZD6UCtMCOe4iX1-UDrLFBBhQ@mail.gmail.com \
    --to=lizhong1008@gmail.com \
    --cc=daniel.socek@intel.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=haihao.xiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git