From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9856F442E6 for ; Sun, 30 Jun 2024 05:31:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1EC1268D6E4; Sun, 30 Jun 2024 08:31:06 +0300 (EEST) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 695CF68D648 for ; Sun, 30 Jun 2024 08:30:58 +0300 (EEST) Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ec002caf3eso29780321fa.1 for ; Sat, 29 Jun 2024 22:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719725456; x=1720330256; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=FUqvubJXJXaAsXasylJUZYgSUnfSPvO/gkzdAI+QK8o=; b=NqUuQZdYEU9U1nXyCHMuzim7QsFW+IiNUhWEpnfwwP/ntX0FGR+s7z1v9Sn0O5EN96 l9mfPo2ZlkoipQm0CapuGT+Hy1ktTcre/lxVoDd9c78NWWkdw5ppjxf/EbRCSNSqfA+S PC26vYTaw4Z8ffV46zRPSEEEALbdUOnTdwO5X2cq2/S0Gg2VOZXaHshLR2vKrCnoFXHl MAytjBEZdZRYDAJh7sBkvsypxbe+j6yzuIeP1T8dqBGJurn/18s9YpinCNM+4AvYBE6B JbpoxROdUDeDaLD+RPXxpyhosYC4NMGS79fv/ngeUjwTrNXWnukjWhyF1B5kGfL3ikHb rneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719725456; x=1720330256; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FUqvubJXJXaAsXasylJUZYgSUnfSPvO/gkzdAI+QK8o=; b=lBsEQmr1f6f3aNn1h+0cIRNieBoqN/hNTYjLKZpty5rXDC0Uy9RG0BRgMNcldXqp36 IMsocnza3SzYp8Yvz8vAXRvCdzNSYA0SxQo17lfCd/Dup/3kVas2UYdXjAVloXsJUr/W +oHjz12BOaAYAgLmossUhcOVxEPfO6nAEJ3L6NkEk4ZMBnbEudqrKHatG6oflKmsmgjp MUh0i6H5ppRtsOryo05I9gbDA7LYtyvM5OUetnyMtb/63ZgDmS8emjvZNVArhTcrLPy2 S5vYHlXXHuxsNNT1r0nx7rE+b98qR+diwH2jt899QygKPQeL5QC4KYQpUPlcHd6EL13v p/eA== X-Gm-Message-State: AOJu0Yzd3pXV7i2YY67506FxjueqG4+zgbfaub/osHLOg/5tVmVovDPe aE8DaUX1+LlZeKmYbtMLkpLCkZVh6tabsq25eLN7+hrp8K//cfxGUcV8ur1m0SOraMBl1yPwWuq dkYyA+oyBPD2roh9peiSChXj77KVMTQ== X-Google-Smtp-Source: AGHT+IGtS8Mz9DTOILsBzhxodImBeafBHpodGn0GgbE4jqKC9YYiHESEZJEorgG13llorsMCiVMqaogFC1BUuQRd+fE= X-Received: by 2002:a2e:a913:0:b0:2ec:5777:aa5c with SMTP id 38308e7fff4ca-2ee5e2c6561mr28911301fa.0.1719725455878; Sat, 29 Jun 2024 22:30:55 -0700 (PDT) MIME-Version: 1.0 References: <20240628044601.60376-1-quinkblack@foxmail.com> In-Reply-To: From: Mark Harris Date: Sat, 29 Jun 2024 22:30:44 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/file_open: Fix build error with wasi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > From: Zhao Zhili > > Don't assume tempnam is available when !HAVE_MKSTEMP. Check tempnam > explicitly in configure. > > Signed-off-by: Zhao Zhili > --- > configure | 2 ++ > libavutil/file_open.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7685c95fbb..bd3c1d4838 100755 > --- a/configure > +++ b/configure > @@ -2413,6 +2413,7 @@ SYSTEM_FUNCS=" > sysconf > sysctl > sysctlbyname > + tempnam > usleep > UTGetOSTypeFromString > VirtualAlloc > @@ -6548,6 +6549,7 @@ check_struct "sys/stat.h" "struct stat" st_mtim.tv_nsec -D_BSD_SOURCE > check_func strerror_r > check_func sysconf > check_func sysctl > +check_func tempnam > check_func usleep > > check_func_headers conio.h kbhit > diff --git a/libavutil/file_open.c b/libavutil/file_open.c > index 24ef33e3da..eef6d83706 100644 > --- a/libavutil/file_open.c > +++ b/libavutil/file_open.c > @@ -112,7 +112,7 @@ int avpriv_tempfile(const char *prefix, char **filename, int log_offset, void *l > { > FileLogContext file_log_ctx = { &file_log_ctx_class, log_offset, log_ctx }; > int fd = -1; > -#if !HAVE_MKSTEMP > +#if HAVE_TEMPNAM If neither HAVE_TEMPNAM nor HAVE_MKSTEMP are defined, this will get the file name from an uninitialized buffer. If both are defined it will not compile because len will be undefined. - Mark > void *ptr= tempnam(NULL, prefix); > if(!ptr) > ptr= tempnam(".", prefix); > -- > 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".