From: Denis Shulyaka <shulyaka@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support
Date: Tue, 11 Jan 2022 18:52:42 +0300
Message-ID: <CAM_Y7Lg==qZazeqq18tWTkW_rnaTGNgrgaFdEGE1q7vSZHc1vA@mail.gmail.com> (raw)
In-Reply-To: <CAM_Y7LjGS1gP9Rz3Z-PBWTbk4PwciQVWdA30CcbrsyoEEqucKg@mail.gmail.com>
Hi all,
Is there anything I could do to kindly ask to review and accept the patch?
Best regards,
Denis Shulyaka
вт, 28 сент. 2021 г. в 17:53, Denis Shulyaka <shulyaka@gmail.com>:
> Hi all,
>
> This is a kind reminder.
>
> Best regards,
> Denis Shulyaka
>
> вс, 11 апр. 2021 г. в 13:21, Denis Shulyaka <shulyaka@gmail.com>:
>
>> Hi Carl,
>>
>> Thanks for the review.
>>
>> сб, 10 апр. 2021 г. в 18:05, Carl Eugen Hoyos <ceffmpeg@gmail.com>:
>>
>>> Please use "&" instead of "%".
>>>
>>
>> Fixed
>>
>> Please remove this line.
>>>
>>
>> Fixed
>>
>> See above.
>>>
>>
>> Fixed
>>
>> Please remove this line or the default branch above.
>>>
>>
>> Fixed. It was there as a safety feature in case someone adds a new
>> condition to the switch which wouldn't return.
>>
>> Is this an unrelated fix?
>>>
>>
>> Yes, you are right, will submit as a separate patch.
>>
>> > + if (!pkt_size)
>>> > + return AVERROR_BUG;
>>>
>>> This looks wrong or do I miss something?
>>>
>>
>> This is also just for safety to verify that future modifications of
>> spdif_read_burst_payload_length() work correctly. Should I remove it?
>>
>> --
>> Best regards,
>> Denis Shulyaka
>>
>
>
> --
> Best regards,
> Denis Shulyaka
>
--
Best regards,
Denis Shulyaka
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2022-01-11 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210410081606.557527-1-Shulyaka@gmail.com>
[not found] ` <CAB0OVGo50s-fxos8FgDw17V68uvfMRprqHS1NuCMVopZmuhr+w@mail.gmail.com>
[not found] ` <CAM_Y7Lid8mSFLjv2x4Ot1vDvh7yXfS+AQsHHTasr=EhXK7AW=g@mail.gmail.com>
[not found] ` <CAM_Y7LjGS1gP9Rz3Z-PBWTbk4PwciQVWdA30CcbrsyoEEqucKg@mail.gmail.com>
2022-01-11 15:52 ` Denis Shulyaka [this message]
2022-01-12 9:46 ` Anton Khirnov
2022-01-12 10:11 ` Denis Shulyaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_Y7Lg==qZazeqq18tWTkW_rnaTGNgrgaFdEGE1q7vSZHc1vA@mail.gmail.com' \
--to=shulyaka@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git