From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E579443B97 for ; Tue, 19 Jul 2022 21:21:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE95D68B761; Wed, 20 Jul 2022 00:21:19 +0300 (EEST) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B14B368B641 for ; Wed, 20 Jul 2022 00:21:12 +0300 (EEST) Received: by mail-yb1-f181.google.com with SMTP id h62so28741101ybb.11 for ; Tue, 19 Jul 2022 14:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=tQF6Mphx5YjTsvFcsqAdnVKqrLznftUdCwVgqmPBEP8=; b=FqSDSIS4zAy9CxIfkbpGRbtl0HU7eVkkpPmx5tGRf3mGZTURuZIYBvg6DZR6jLfnwP PRd+vXLcT8F5Wtzf+xNzSYWxO7EVktY+rrDeQxCh+F7HyqNttR5ReCah0dcuW280VYN8 pvP3VvQsJjoHUA1YnLYArg83PIWPcY/qdWquX/G/tNJFFGW36bug47F1615MNVUvcY9K SCdqauhElBPEVsJJmTStanMPoezbgnr3tiNoRs6+K6DyzvtWOKLBLSzQNax9O6UXPYoD chBKX/9RzCodUxpOb3YuEZ+Tz8QWUTvY+G/h9BSVyPAAM+Ngi+IK63N7vEDPCdg4V65s Dzcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tQF6Mphx5YjTsvFcsqAdnVKqrLznftUdCwVgqmPBEP8=; b=D46OJM71pJmDgbHcof9KSTC2pmGBMgTSk/Y1GqD0VhzWscx5x19DxLnK929A0ySPgg c6nenfOumhj1RkobVBJcKrhArUUK/iN/ZV2DtEBZI5U8emR5ONRILw+zcwQeSy6jJoAs xQwn84WXm//WHW7N4DXZyMKXLW2vf8bVxqRt8fJ3+8u6LiGwFp1BAyCJHWPNxIMcxK2E kc0MgTniS9rvw/x9qqAIm3TqFuBPrBOx2sEmcXhGGkJxc2h77+FpKRMJXQnN+5vT/2ee Stm7xh4JMxNOgWqcdQI+F9Ii+KWHe7CUyF0ww3PC3BPgKouPO2xCvUMj5Kt10SsIEwS+ eQYA== X-Gm-Message-State: AJIora9aU73YfMlBSTS65wXdcxKD6uHkmfXZ0TMJfDCt68O7GXCyxc7m ApDSjZBVPqXGZkW0KwC9KvswvPXfZ36K8rVVm/PcAVo6dqI= X-Google-Smtp-Source: AGRyM1uPKEjEs1rz2QVTmCPHxWLu8U8lbupiuAEpSsTLGtHKZVdFLqc40+Wnm/W5zhATze8S+0pJnqvQmU7n5BVoHMA= X-Received: by 2002:a25:888a:0:b0:669:9661:912 with SMTP id d10-20020a25888a000000b0066996610912mr32796457ybl.348.1658265670956; Tue, 19 Jul 2022 14:21:10 -0700 (PDT) MIME-Version: 1.0 References: <20220709043142.2228184-1-amirmazz@google.com> In-Reply-To: From: Amir Mazzarella Date: Tue, 19 Jul 2022 14:21:00 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Make implicit void pointer cast explicit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thank you for your response! A C++ compiler can't do implicit casts like a C compiler can, in this instance. This is fine for most of FFmpeg's codebase, since these tricks are in C source files, but in this instance it is in a header file. If any C++ code includes this header file, even with extern "C", it won't be able to be compiled. On Tue, Jul 19, 2022 at 12:08 PM Nicolas George wrote: > Hi. Thanks for the patch. > > Amir Mazzarella (12022-07-09): > > Signed-off-by: Amir Mazzarella > > --- > > libavutil/vulkan_loader.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/vulkan_loader.h b/libavutil/vulkan_loader.h > > index 3f1ee6aa46..fa8e5ed171 100644 > > --- a/libavutil/vulkan_loader.h > > +++ b/libavutil/vulkan_loader.h > > @@ -82,7 +82,7 @@ static inline int > ff_vk_load_functions(AVHWDeviceContext *ctx, > > uint64_t extensions_mask, > > int has_inst, int has_dev) > > { > > - AVVulkanDeviceContext *hwctx = ctx->hwctx; > > + AVVulkanDeviceContext *hwctx = (AVVulkanDeviceContext *) ctx->hwctx; > > > > static const struct FunctionLoadInfo { > > int req_inst; > > Why? What is it supposed to fix? > > Regards, > > -- > Nicolas George > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".