From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D7E2401CF for ; Tue, 19 Jul 2022 22:12:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 92FEB68B5D6; Wed, 20 Jul 2022 01:12:45 +0300 (EEST) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 922B868B00F for ; Wed, 20 Jul 2022 01:12:39 +0300 (EEST) Received: by mail-yb1-f169.google.com with SMTP id 64so29059098ybt.12 for ; Tue, 19 Jul 2022 15:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=EaxG3+GlQB1BfouwSS5GiYbN3WobnucIx3Msd9nlzF8=; b=jxApkB1e4a8hqxrlRV9Ftfz4FZHIQIgHuHF5mlIPeK+L9v5VsthAHAr+jUchMpFWlN ATKeqpIOOfH/UNAn3m5mCybeSnJ0XuITG6/xVxtSZpgPTj/sgBDyXFlyc3y9VQ617Dqu go0ql6W/j4CvIibbak5whTyjDtbTCasRw999FcLsazN4oJY2xgJ5kQ/zJxKhLARF3Nu2 Mr7ccJrBd1z3NRQNnTP8lS11KmOiqokK4uaajlHwzUmlcZDaq4OH7YEaB9ZF5F5X2lGj W3CgCpqnR7rQCgfp1G+1r00Jst4ZfuINVqd+jMDysrm17WPyEb3a3Xu4nMw4+n3I18Oy GQZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=EaxG3+GlQB1BfouwSS5GiYbN3WobnucIx3Msd9nlzF8=; b=Z0zEhgRQKHdNmRVNnCHtPlfmwfyuhkPcA01utDhN0UDUSahCNfoeaGpr/W/ScNaVIn OJL0MJJP9cpcS7RFYRgcGtsr1MhOZSXg2OqqxivfVY6fXBji4KhMegRHsQikv/pCZOyN 5IJyDGFK2uKgtYJThH+lq01kCvjmJ55tFy6WOTpCjoOD6JB5S1ldQ++XhezcCk8TaiJj 5DGf29UOeXOWhN+mXP8ltr4BQ0/x+6yC/nKgmZRvFkHGN/7AH89KOxdYfDKcZSPUqHV8 5/UG21ZVkjMcS7Oroo5QodGKDF5LxMtbrLFOXHDy3B8/tmYL7/VQ6hI47I0+OTapaa1r b3vw== X-Gm-Message-State: AJIora8Xfrj7BVzW2mtbKprywhTDzousBrdQXyWfcw9BWhJVy6vHFRxD lckUWolKzJRPh1/lA3LqhdLUUEFxvKyLZ6L2TYFlbXDur2EvlA== X-Google-Smtp-Source: AGRyM1t1L5iP6ZAljf4jx1zL5q5Ma7+0cxXmwj0OkypT9c0l+dfDtf6eV3TYax37MY66bNtz8Op0C2emZirWjbJR/rk= X-Received: by 2002:a05:6902:1209:b0:66e:9640:1447 with SMTP id s9-20020a056902120900b0066e96401447mr35617325ybu.152.1658268757275; Tue, 19 Jul 2022 15:12:37 -0700 (PDT) MIME-Version: 1.0 References: <20220709043142.2228184-1-amirmazz@google.com> In-Reply-To: From: Amir Mazzarella Date: Tue, 19 Jul 2022 15:12:26 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Make implicit void pointer cast explicit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jul 19, 2022 at 2:24 PM Nicolas George wrote: > Thanks for clarifying. I confess I had more or less guessed. FFmpeg is > C, and its headers, public or not, as a rule do not contain > accommodations to be included as is in other languages. I understand that FFmpeg does not contain accommodations, but in my opinion it is less of an accommodation and more for readability, avoiding an implicit cast. An explicit void pointer cast, like the one presented in my patch, is done elsewhere in FFmpeg code as well. See https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/hwcontext_qsv.c#L316 What's the harm in including this one too? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".