From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E23D94DB32 for ; Thu, 3 Jul 2025 22:28:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 136D968F396; Fri, 4 Jul 2025 01:28:51 +0300 (EEST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 837EC68F2A4 for ; Fri, 4 Jul 2025 01:28:44 +0300 (EEST) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-60702d77c60so673847a12.3 for ; Thu, 03 Jul 2025 15:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751581723; x=1752186523; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=KRxJpInIpVoIAKM+8QU3yqLVoWMMiusycCtp7VmU/3c=; b=Ar7sIqSFip+mrn3H3jZWHIPawWyScyAXQNJD9NnGlxrQn6PfZCZFxkzS2Cc4l5cfhe yj8YEc9DtsKKFYTAwbkghIMblEE6dIuX5ogelWzP2pP1ysRBBm7Bdf3DTdJxu5Jkzzsa XWN5oSWC0cuwUWQWer3DBw7XuoywZG7k5y9HfHqc7bc0NxiC3APJ0M5GdqO19Yv0USNn LNQnu8kbbbZp/PH8HJ141KRSES3lXRy5clEAAqAB1ePea9zsNI3UHk8gRZnDnlHDILDc iSIx7MBHRLnP2HKRKlTSwpY4b++tAnFGnw/Yd4umP8rCQTcf9efLCqPSB0XO9VzV4hjb 3KOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751581723; x=1752186523; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KRxJpInIpVoIAKM+8QU3yqLVoWMMiusycCtp7VmU/3c=; b=nLQ8mUsvIPm7vac67ORjKu7DzPqZ1qkQ3n3VKFhDW4kK7bJFoQaZOoMNfFzW84dIGe /dtKVPpzkIIBpPUrs3xzWXzI/91AUEpatJFVHW5Y8EL0/XebtpC7g9MdGpIFZpYbQLUf dlxgQHtkmHxiwCeliufXMOiVMxLrIJ4leuEq4DG1XEn6cTFXP1e7tjmzXN5Da7GVr31p YV1Ya/le4cNYfmflvIkKFoB1YLGMZi0RVm3Or5gjJGx1nF1yMV0kE0hBsvICYF7HwxRW EDzq9+OS8Hxm5JHdhDw+34/F22pmFFZUJ7PskVmfYI9TdJFQCFOSsSH+R/Oix3nadudB hv3Q== X-Gm-Message-State: AOJu0Yw/pB6tS8HI+E1PtXjld+rpwtD3R3w2Hrhxn1ChT3ijOxkEGFZn q+nEeE7761RsW3znbrybiF1Mvkg8r3S4GCWlSWc/tfnpPWAFTpwkKvUebbAhhg36A7o0u6nCCvX ngPgc9XVV2qCe7KOOYIhGkYfVim2acXMkk3Zn X-Gm-Gg: ASbGncsKebOJBc3i1jmMctVSnixXWBiP9IXBydvqpIuAQryP2e7lj3U/iL1w638LxCC aaQbNruK2TiMtf2dhImjl7XVztEU0A60A4zxNexijo1HhYtF1CjNbZNpzeCcQv9xbKiCrixI3Ad SEA4o37/iQDDEZdbU2VsIpFZ0ZzVM2TJibTRalqaBvDO33QFGrWTQXFIpOvNO/jWAVu+2Ltx+LX olgFiEbxRK9aUw= X-Google-Smtp-Source: AGHT+IE2/k4ywpKLS+Py6JEJfelWcY8kmL4CPeIBBkCFo+TVIrJFtKmrdHmA8z/5BGGAS2gkiovnyhh1+WEwvFcpaCo= X-Received: by 2002:a50:9305:0:b0:5fc:9979:78f7 with SMTP id 4fb4d7f45d1cf-60fd30c95a0mr199087a12.14.1751581723450; Thu, 03 Jul 2025 15:28:43 -0700 (PDT) MIME-Version: 1.0 References: <20250624061959.23577-1-roslypav@gmail.com> <20250625221246.GB29660@pb2> <20250625224037.GC29660@pb2> <20250626210807.GF29660@pb2> <20250627213246.GH29660@pb2> In-Reply-To: <20250627213246.GH29660@pb2> From: Pavel Roslyy Date: Thu, 3 Jul 2025 15:28:32 -0700 X-Gm-Features: Ac12FXy4YCDhhFwwjqHL37Ua_lZXjYkKt1pa7vPSzZRBudCUwBgeJ9ZVS0RyaFU Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello, After experimenting, I think it would be a better idea to move the hca_* options into libavcodec/hcadec.c rather than duplicating them into the usm demuxer. Before I try to submit patches that do this I have some questions. 1) I plan on removing the hca_* options from libavformat/hca.c and placing them into libavcodec/hcadec.c. Am I correct in assuming that this would be considered an API deprecation and would require doing deprecation guards in libavformat/hca.c? 2) If considered an API deprecation, would it make sense to consolidate hca_lowkey and hca_highkey into a single hca_key option that takes 16 bits of hexadecimal string (like most other decryption key options) rather than keeping the options as integer hca_highkey / hca_lowkey in libavcodec/hcadec.c? Regards, Pavel Roslyy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".