From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 36F80424CB for ; Thu, 17 Mar 2022 18:30:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 063B068ADD4; Thu, 17 Mar 2022 20:30:31 +0200 (EET) Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 67839687EBB for ; Thu, 17 Mar 2022 20:30:25 +0200 (EET) Received: by mail-ua1-f41.google.com with SMTP id a20so2379329uaq.11 for ; Thu, 17 Mar 2022 11:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=viljoen-com.20210112.gappssmtp.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=hbMwoTQMWmCWsLRMo+hTyCTZyhQmriTjz/xCq3v5New=; b=2odjE48ysa8Dy/vF1NaNzbfxsPV/WFMbHPg+4acmlAAq3ikaEBE3XF9rkQ6C/A5haU mK7UtMjssJ+qJCLfYYx79GlzM5u3cuwjg+gs9QCknJe54XXbS6jTUHExSYQx01PcXc2K CYj70frbxBlY88jZJV5oqZyFpwPOfzkzMxDQrFxxbInx+qoUp7uulRMbyJo4ffc/e3cU inRfo49pzMWkXrh3ObgHN1x5feIpSwIwooWhjdoaXu43OzDAgnE5j/io5MtDuUANb9SV Jl7udCWxufw63qrFRorOYjkzLvaB+eABApPAKNLnD2dJYHe6fQY6kR2PL7L95wToJiQg P2OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hbMwoTQMWmCWsLRMo+hTyCTZyhQmriTjz/xCq3v5New=; b=M/HHkN8JI8lVTsru/oBKeLEbrNhnnO6/xjuGiIim1r6lC+vH3+gv6KbUBifAAp+ZoB mppQZKnsUeDwbUE7PXv1MERNjJUIaIfdFleAeIw9lRHqU0696vqMqor/LwAx4LprD/F8 p6xBkrOeTHetdaycqfv7Y2aSyHne4H+jGZpF897OhRrbrnhyUr6q8JTO+9KbqLmlVRCN mP6/wsE947CoaRIXJ0baTfxxXWQtYOP7/4YHiqqvLFta9UJYD24nQT1/4Goinbfrmu+O 3t1ptrGAxtm8Cb18v3Zh+SkM36uZAyCsXBvQ7C0mOd/UKPfIMN0sJni+u84zOvF68FYt WGqg== X-Gm-Message-State: AOAM530VJloferBqcXx8qQPoWJDGTDtaoKWojO8vOmboEN5/T1ftSUeA B20DTC/wtAM5ExXX8OBpYDkRexAj9WYgBg+r/xsKRhipbdv5oA== X-Google-Smtp-Source: ABdhPJyK9kUCB61VHVk3+kAdyCx2eTOAW5BAM8y7ETwpe4RyIU2DEGw/2GpHKg1FTLIPfJcCOP8wrb7288ZUFlDs7DE= X-Received: by 2002:ab0:6dc1:0:b0:34d:6893:a57b with SMTP id r1-20020ab06dc1000000b0034d6893a57bmr2161485uaf.37.1647541823174; Thu, 17 Mar 2022 11:30:23 -0700 (PDT) MIME-Version: 1.0 From: Pieter Viljoen Date: Thu, 17 Mar 2022 11:30:12 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] ffprobe closed_captions json output not set while text output is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Please reconsider an abandoned patch to allow consistent behavior in closed caption detection between ffprobe with and without "-print_format json". https://patchwork.ffmpeg.org/project/ffmpeg/patch/MN2PR04MB59815313285AA685E37D09AEBAB09@MN2PR04MB5981.namprd04.prod.outlook.com/ I also asked for solutions on reddit, videohelp, IRC, ffmpeg-user, resorting to asking on ffmpeg-devel. I would like to add the ability to detect and remove closed captions from video streams using ffmpeg, in an open source tool I maintain that cleans up media files for direct play on Plex, Emby, Jellyfin, etc. ( https://github.com/ptr727/PlexCleaner) When I run ffprobe in JSON output mode, it is not setting the "closed_captions" attribute. When I run ffprobe in default output mode, it does correctly identify closed captions in video streams and prints "Closed Captions" in the stream descriptor. The divergent behavior appears to be a ffprobe bug. Details of the problem is described where I asked for help on reddit and videohelp: https://www.reddit.com/r/ffmpeg/comments/tcnhto/how_to_detect_closed_captions_in_video_stream/ https://forum.videohelp.com/threads/405123-Detect-embedded-closed-captions-in-video-stream-using-ffprobe-json-output I did not get any help, but after lots of googling I did find an abandoned patch that describes exactly the problem I am experiencing: https://patchwork.ffmpeg.org/project/ffmpeg/patch/MN2PR04MB59815313285AA685E37D09AEBAB09@MN2PR04MB5981.namprd04.prod.outlook.com/ https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=&submitter=&state=*&q=closed_captions&archive=both&delegate= https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg126211.html The proposed patch seemed trivial, but I do not understand the nuances of the objections. I'd like the patch to be please re-considered, or an alternative proposed that allows ffprobe's JSON output to return correct closed_captions values. --- Pieter _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".