Re: [FFmpeg-devel] [PATCH] libavfilter/yadif_cuda: Fix build breakage

Re: [FFmpeg-devel] [PATCH] libavfilter/yadif_cuda: Fix build breakage

[Dennis Mungai]

On Thu, 11 May 2023 at 20:12, Devin Heitmueller <
devin.heitmueller@ltnglobal.com> wrote:

> Address build breakage caused by my latest series when compiling
> with CUDA support.  Thanks to Paul Mahol for pointing it out.
>
> Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
> ---
>  libavfilter/vf_yadif_cuda.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/vf_yadif_cuda.c b/libavfilter/vf_yadif_cuda.c
> index f3f0b56..73f0412 100644
> --- a/libavfilter/vf_yadif_cuda.c
> +++ b/libavfilter/vf_yadif_cuda.c
> @@ -205,7 +205,7 @@ static av_cold void deint_cuda_uninit(AVFilterContext
> *ctx)
>      av_frame_free(&y->prev);
>      av_frame_free(&y->cur);
>      av_frame_free(&y->next);
> -    ff_cc_fifo_freep(&y->cc_fifo);
> +    ff_ccfifo_freep(&y->cc_fifo);
>
>      av_buffer_unref(&s->device_ref);
>      s->hwctx = NULL;
> @@ -295,7 +295,7 @@ static int config_output(AVFilterLink *link)
>      else
>          link->frame_rate = ctx->inputs[0]->frame_rate;
>
> -    if (!(s->cc_fifo = ff_cc_fifo_alloc(link->frame_rate, ctx))) {
> +    if (!(y->cc_fifo = ff_ccfifo_alloc(link->frame_rate, ctx))) {
>          av_log(ctx, AV_LOG_ERROR, "Failure to setup CC FIFO queue\n");
>          ret = AVERROR(ENOMEM);
>          goto exit;
> --
> 1.8.3.1
>


I had literally opened a ticket on the same seconds ago:
https://trac.ffmpeg.org/ticket/10357

Will close as soon as the patch is merged.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavfilter/yadif_cuda: Fix build breakage

[Devin Heitmueller]

Address build breakage caused by my latest series when compiling
with CUDA support.  Thanks to Paul Mahol for pointing it out.

Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
---
 libavfilter/vf_yadif_cuda.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/vf_yadif_cuda.c b/libavfilter/vf_yadif_cuda.c
index f3f0b56..73f0412 100644
--- a/libavfilter/vf_yadif_cuda.c
+++ b/libavfilter/vf_yadif_cuda.c
@@ -205,7 +205,7 @@ static av_cold void deint_cuda_uninit(AVFilterContext *ctx)
     av_frame_free(&y->prev);
     av_frame_free(&y->cur);
     av_frame_free(&y->next);
-    ff_cc_fifo_freep(&y->cc_fifo);
+    ff_ccfifo_freep(&y->cc_fifo);
 
     av_buffer_unref(&s->device_ref);
     s->hwctx = NULL;
@@ -295,7 +295,7 @@ static int config_output(AVFilterLink *link)
     else
         link->frame_rate = ctx->inputs[0]->frame_rate;
 
-    if (!(s->cc_fifo = ff_cc_fifo_alloc(link->frame_rate, ctx))) {
+    if (!(y->cc_fifo = ff_ccfifo_alloc(link->frame_rate, ctx))) {
         av_log(ctx, AV_LOG_ERROR, "Failure to setup CC FIFO queue\n");
         ret = AVERROR(ENOMEM);
         goto exit;
-- 
1.8.3.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavfilter/yadif_cuda: Fix build breakage

[Lance Wang]

On Fri, May 12, 2023 at 1:12 AM Devin Heitmueller <
devin.heitmueller@ltnglobal.com> wrote:

> Address build breakage caused by my latest series when compiling
> with CUDA support.  Thanks to Paul Mahol for pointing it out.
>
> Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
> ---
>  libavfilter/vf_yadif_cuda.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/vf_yadif_cuda.c b/libavfilter/vf_yadif_cuda.c
> index f3f0b56..73f0412 100644
> --- a/libavfilter/vf_yadif_cuda.c
> +++ b/libavfilter/vf_yadif_cuda.c
> @@ -205,7 +205,7 @@ static av_cold void deint_cuda_uninit(AVFilterContext
> *ctx)
>      av_frame_free(&y->prev);
>      av_frame_free(&y->cur);
>      av_frame_free(&y->next);
> -    ff_cc_fifo_freep(&y->cc_fifo);
> +    ff_ccfifo_freep(&y->cc_fifo);
>
>      av_buffer_unref(&s->device_ref);
>      s->hwctx = NULL;
> @@ -295,7 +295,7 @@ static int config_output(AVFilterLink *link)
>      else
>          link->frame_rate = ctx->inputs[0]->frame_rate;
>
> -    if (!(s->cc_fifo = ff_cc_fifo_alloc(link->frame_rate, ctx))) {
> +    if (!(y->cc_fifo = ff_ccfifo_alloc(link->frame_rate, ctx))) {
>          av_log(ctx, AV_LOG_ERROR, "Failure to setup CC FIFO queue\n");
>          ret = AVERROR(ENOMEM);
>          goto exit;
> --
> 1.8.3.1
>
>
LGTM, will apply.


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".