Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lance Wang <lance.lmwang@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance
Date: Wed, 10 May 2023 19:16:14 +0800
Message-ID: <CAM=jba_BAvFdJH9by6x9yaCppOTq5ff7tvw=KWU3Rvsd2igxsw@mail.gmail.com> (raw)
In-Reply-To: <CAHGibzHM6dpohv_9qVvDCY9KhggrJoajG256cx7NwCq5xk8C+g@mail.gmail.com>

On Sat, May 6, 2023 at 8:41 PM Devin Heitmueller <
devin.heitmueller@ltnglobal.com> wrote:

> On Sat, May 6, 2023 at 8:16 AM James Almer <jamrial@gmail.com> wrote:
> > Can you bench with the START_TIMER and STOP_TIMER macros in timer.h?
> > Also, define CACHED_BITSTREAM_READER in bitpacked_dec.c before including
> > git_bits.h and test the actual implementation again, to see if it makes
> > any difference.
>
> Original code:
> 671661910 decicycles in bitpacked_dec,       1 runs,      0 skips
> 669736380 decicycles in bitpacked_dec,       1 runs,      0 skips
> 669370700 decicycles in bitpacked_dec,       1 runs,      0 skips
>
> Original code with CACHED_BITSTREAM_READER defined
> 352599030 decicycles in bitpacked_dec,       1 runs,      0 skips
> 336163810 decicycles in bitpacked_dec,       1 runs,      0 skips
> 344628350 decicycles in bitpacked_dec,       1 runs,      0 skips
>
> My proposed versioned:
> 257353330 decicycles in bitpacked_dec,       1 runs,      0 skips
> 271527000 decicycles in bitpacked_dec,       1 runs,      0 skips
> 252701500 decicycles in bitpacked_dec,       1 runs,      0 skips
>
>
Yes, it's show better performance, so LGTM if nobody have plan to optimize
the bitstream
function.

Devin
>
> --
> Devin Heitmueller, Senior Software Engineer
> LTN Global Communications
> o: +1 (301) 363-1001
> w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-05-10 11:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 21:54 Devin Heitmueller
2023-05-06 11:32 ` Lance Wang
2023-05-06 11:49   ` Devin Heitmueller
2023-05-06 11:52   ` Paul B Mahol
2023-05-06 12:13     ` Devin Heitmueller
2023-05-06 12:16       ` James Almer
2023-05-06 12:40         ` Devin Heitmueller
2023-05-10 11:16           ` Lance Wang [this message]
2023-05-11 22:20             ` Marton Balint
2023-05-12 15:26               ` Devin Heitmueller
2023-12-13 19:58                 ` [FFmpeg-devel] [PATCH] avcodec/bitpacked_dec: optimize bitpacked_decode_yuv422p10 Marton Balint
2023-12-28 20:42                   ` Marton Balint
2023-06-12 16:05               ` [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance Paul B Mahol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM=jba_BAvFdJH9by6x9yaCppOTq5ff7tvw=KWU3Rvsd2igxsw@mail.gmail.com' \
    --to=lance.lmwang@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git