From: Lance Wang <lance.lmwang@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] avformat/flvenc: support mux hevc in enhanced flv
Date: Fri, 2 Jun 2023 23:52:04 +0800
Message-ID: <CAM=jba--sQVkEo8D0GXMt_Y1V6NCd9QOwf2A=ACKGX67vi9Caw@mail.gmail.com> (raw)
In-Reply-To: <CADxeRwmGcu9XyB+rAxe2pcBZ5jnHQz-5707UFjZECfkbcmJw9A@mail.gmail.com>
On Fri, Jun 2, 2023 at 7:29 PM Steven Liu <lingjiujianke@gmail.com> wrote:
> Lance Wang <lance.lmwang@gmail.com> 于2023年6月2日周五 19:09写道：
> >
> > On Fri, Jun 2, 2023 at 3:31 PM Steven Liu <lq@chinaffmpeg.org> wrote:
> >
> > > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > > ---
> > > libavformat/Makefile | 2 +-
> > > libavformat/flv.h | 15 +++++++++++++++
> > > libavformat/flvenc.c | 41 +++++++++++++++++++++++++++++++----------
> > > 3 files changed, 47 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/libavformat/Makefile b/libavformat/Makefile
> > > index f8ad7c6a11..1ef3d15467 100644
> > > --- a/libavformat/Makefile
> > > +++ b/libavformat/Makefile
> > > @@ -214,7 +214,7 @@ OBJS-$(CONFIG_FLAC_MUXER) +=
> flacenc.o
> > > flacenc_header.o \
> > > OBJS-$(CONFIG_FLIC_DEMUXER) += flic.o
> > > OBJS-$(CONFIG_FLV_DEMUXER) += flvdec.o
> > > OBJS-$(CONFIG_LIVE_FLV_DEMUXER) += flvdec.o
> > > -OBJS-$(CONFIG_FLV_MUXER) += flvenc.o avc.o
> > > +OBJS-$(CONFIG_FLV_MUXER) += flvenc.o avc.o hevc.o
> > > OBJS-$(CONFIG_FOURXM_DEMUXER) += 4xm.o
> > > OBJS-$(CONFIG_FRAMECRC_MUXER) += framecrcenc.o framehash.o
> > > OBJS-$(CONFIG_FRAMEHASH_MUXER) += hashenc.o framehash.o
> > > diff --git a/libavformat/flv.h b/libavformat/flv.h
> > > index 3571b90279..91e0a4140c 100644
> > > --- a/libavformat/flv.h
> > > +++ b/libavformat/flv.h
> > > @@ -35,6 +35,12 @@
> > >
> > > #define FLV_VIDEO_FRAMETYPE_OFFSET 4
> > >
> > > +/* Extended VideoTagHeader
> > > + * defined in reference link:
> > > + *
> > >
> https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf
> > > + * */
> > > +#define FLV_IS_EX_HEADER 0x80
> > > +
> > > /* bitmasks to isolate specific values */
> > > #define FLV_AUDIO_CHANNEL_MASK 0x01
> > > #define FLV_AUDIO_SAMPLESIZE_MASK 0x02
> > > @@ -112,6 +118,15 @@ enum {
> > > FLV_CODECID_MPEG4 = 9,
> > > };
> > >
> > > +enum {
> > > + PacketTypeSequenceStart = 0,
> > > + PacketTypeCodedFrames = 1,
> > > + PacketTypeSequenceEnd = 2,
> > > + PacketTypeCodedFramesX = 3,
> > > + PacketTypeMetadata = 4,
> > > + PacketTypeMPEG2TSSequenceStart = 5,
> > > +};
> > > +
> > >
> >
> > format and align the "="?
> yes it is aligned in patch, you can reference in
>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230602073109.14086-2-lq@chinaffmpeg.org/
> >
> >
> >
> > > enum {
> > > FLV_FRAME_KEY = 1 << FLV_VIDEO_FRAMETYPE_OFFSET, ///<
> key
> > > frame (for AVC, a seekable frame)
> > > FLV_FRAME_INTER = 2 << FLV_VIDEO_FRAMETYPE_OFFSET, ///<
> > > inter frame (for AVC, a non-seekable frame)
> > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
> > > index 721f062811..aed0946a2e 100644
> > > --- a/libavformat/flvenc.c
> > > +++ b/libavformat/flvenc.c
> > > @@ -28,6 +28,7 @@
> > > #include "libavcodec/mpeg4audio.h"
> > > #include "avio.h"
> > > #include "avc.h"
> > > +#include "hevc.h"
> > > #include "avformat.h"
> > > #include "flv.h"
> > > #include "internal.h"
> > > @@ -46,6 +47,7 @@ static const AVCodecTag flv_video_codec_ids[] = {
> > > { AV_CODEC_ID_VP6, FLV_CODECID_VP6 },
> > > { AV_CODEC_ID_VP6A, FLV_CODECID_VP6A },
> > > { AV_CODEC_ID_H264, FLV_CODECID_H264 },
> > > + { AV_CODEC_ID_HEVC, MKBETAG('h', 'v', 'c', '1') },
> > > { AV_CODEC_ID_NONE, 0 }
> > > };
> > >
> > > @@ -489,7 +491,7 @@ static void
> flv_write_codec_header(AVFormatContext* s,
> > > AVCodecParameters* par, i
> > > FLVContext *flv = s->priv_data;
> > >
> > > if (par->codec_id == AV_CODEC_ID_AAC || par->codec_id ==
> > > AV_CODEC_ID_H264
> > > - || par->codec_id == AV_CODEC_ID_MPEG4) {
> > > + || par->codec_id == AV_CODEC_ID_MPEG4 || par->codec_id ==
> > > AV_CODEC_ID_HEVC) {
> > > int64_t pos;
> > > avio_w8(pb,
> > > par->codec_type == AVMEDIA_TYPE_VIDEO ?
> > > @@ -532,10 +534,19 @@ static void
> flv_write_codec_header(AVFormatContext*
> > > s, AVCodecParameters* par, i
> > > }
> > > avio_write(pb, par->extradata, par->extradata_size);
> > > } else {
> > > - avio_w8(pb, par->codec_tag | FLV_FRAME_KEY); // flags
> > > - avio_w8(pb, 0); // AVC sequence header
> > > - avio_wb24(pb, 0); // composition time
> > > - ff_isom_write_avcc(pb, par->extradata,
> par->extradata_size);
> > > + if (par->codec_id == AV_CODEC_ID_HEVC) {
> > > + avio_w8(pb, FLV_IS_EX_HEADER |
> PacketTypeSequenceStart |
> > > FLV_FRAME_KEY); // ExVideoTagHeader mode with PacketTypeSequenceStart
> > > + avio_write(pb, "hvc1", 4);
> > >
> > ff_isom_write_hvcc(pb, par->extradata, par->extradata_size, 0);
> >
> >
> > > + } else {
> > > + avio_w8(pb, par->codec_tag | FLV_FRAME_KEY); // flags
> > > + avio_w8(pb, 0); // AVC sequence header
> > > + avio_wb24(pb, 0); // composition time
> > >
> >
> > ff_isom_write_avcc(pb, par->extradata, par->extradata_size);
> >
> >
> > > + }
> > > +
> > > + if (par->codec_id == AV_CODEC_ID_HEVC)
> > > + ff_isom_write_hvcc(pb, par->extradata,
> > > par->extradata_size, 0);
> > > + else
> > > + ff_isom_write_avcc(pb, par->extradata,
> > > par->extradata_size);
> > >
> >
> > merge the if else?
> No, these modify will be used at the patches after this patch,
> >
> > }
> > > data_size = avio_tell(pb) - pos;
> > > avio_seek(pb, -data_size - 10, SEEK_CUR);
> > > @@ -821,6 +832,7 @@ static int flv_write_packet(AVFormatContext *s,
> > > AVPacket *pkt)
> > > unsigned ts;
> > > int size = pkt->size;
> > > uint8_t *data = NULL;
> > > + uint8_t frametype = pkt->flags & AV_PKT_FLAG_KEY ? FLV_FRAME_KEY :
> > > FLV_FRAME_INTER;
> > > int flags = -1, flags_size, ret = 0;
> > > int64_t cur_offset = avio_tell(pb);
> > >
> > > @@ -832,13 +844,13 @@ static int flv_write_packet(AVFormatContext *s,
> > > AVPacket *pkt)
> > > if (par->codec_id == AV_CODEC_ID_VP6F || par->codec_id ==
> > > AV_CODEC_ID_VP6A ||
> > > par->codec_id == AV_CODEC_ID_VP6 || par->codec_id ==
> > > AV_CODEC_ID_AAC)
> > > flags_size = 2;
> > > - else if (par->codec_id == AV_CODEC_ID_H264 || par->codec_id ==
> > > AV_CODEC_ID_MPEG4)
> > > + else if (par->codec_id == AV_CODEC_ID_H264 || par->codec_id ==
> > > AV_CODEC_ID_MPEG4 || par->codec_id == AV_CODEC_ID_HEVC)
> > > flags_size = 5;
> > > else
> > > flags_size = 1;
> > >
> > > if (par->codec_id == AV_CODEC_ID_AAC || par->codec_id ==
> > > AV_CODEC_ID_H264
> > > - || par->codec_id == AV_CODEC_ID_MPEG4) {
> > > + || par->codec_id == AV_CODEC_ID_MPEG4 || par->codec_id ==
> > > AV_CODEC_ID_HEVC) {
> > > size_t side_size;
> > > uint8_t *side = av_packet_get_side_data(pkt,
> > > AV_PKT_DATA_NEW_EXTRADATA, &side_size);
> > > if (side && side_size > 0 && (side_size !=
> par->extradata_size ||
> > > memcmp(side, par->extradata, side_size))) {
> > > @@ -858,7 +870,7 @@ static int flv_write_packet(AVFormatContext *s,
> > > AVPacket *pkt)
> > > "Packets are not in the proper order with respect to
> > > DTS\n");
> > > return AVERROR(EINVAL);
> > > }
> > > - if (par->codec_id == AV_CODEC_ID_H264 || par->codec_id ==
> > > AV_CODEC_ID_MPEG4) {
> > > + if (par->codec_id == AV_CODEC_ID_H264 || par->codec_id ==
> > > AV_CODEC_ID_MPEG4 || par->codec_id == AV_CODEC_ID_HEVC) {
> > > if (pkt->pts == AV_NOPTS_VALUE) {
> > > av_log(s, AV_LOG_ERROR, "Packet is missing PTS\n");
> > > return AVERROR(EINVAL);
> > > @@ -881,7 +893,7 @@ static int flv_write_packet(AVFormatContext *s,
> > > AVPacket *pkt)
> > >
> > > flags = ff_codec_get_tag(flv_video_codec_ids, par->codec_id);
> > >
> > > - flags |= pkt->flags & AV_PKT_FLAG_KEY ? FLV_FRAME_KEY :
> > > FLV_FRAME_INTER;
> > > + flags |= frametype;
> > > break;
> > > case AVMEDIA_TYPE_AUDIO:
> > > flags = get_audio_flags(s, par);
> > > @@ -903,6 +915,10 @@ static int flv_write_packet(AVFormatContext *s,
> > > AVPacket *pkt)
> > > if (par->extradata_size > 0 && *(uint8_t*)par->extradata != 1)
> > > if ((ret = ff_avc_parse_nal_units_buf(pkt->data, &data,
> > > &size)) < 0)
> > > return ret;
> > > + } else if (par->codec_id == AV_CODEC_ID_HEVC) {
> > > + if (par->extradata_size > 0 && *(uint8_t*)par->extradata != 1)
> > >
> >
> > For the annexb format, stricter checks are as follows if follow by
> standard
> > IMO:
> > AV_RB24(par->extradata) == 1 || AV_RB32(par->extradata) == 1)
> Are there have some problems if i use the code if
> (par->extradata_size > 0 && *(uint8_t*)par->extradata != 1) ?
>
>
the pattern is very simple and will be misdetected if extradata is corrupt
etc.
Now the extradata is hvcc or annexb, for hvcc, the
*(uint8_t*)par->extradata == 1,
so the condition is assuming if it's not hvcc, then it's annexb. isn't 100%
correct?
> >
> >
> > > + if ((ret = ff_hevc_annexb2mp4_buf(pkt->data, &data,
> &size, 0,
> > > NULL)) < 0)
> > > + return ret;
> > > } else if (par->codec_id == AV_CODEC_ID_AAC && pkt->size > 2 &&
> > > (AV_RB16(pkt->data) & 0xfff0) == 0xfff0) {
> > > if (!s->streams[pkt->stream_index]->nb_frames) {
> > > @@ -964,7 +980,12 @@ static int flv_write_packet(AVFormatContext *s,
> > > AVPacket *pkt)
> > > avio_wb32(pb, data_size + 11);
> > > } else {
> > > av_assert1(flags>=0);
> > > - avio_w8(pb,flags);
> > > + if (par->codec_id == AV_CODEC_ID_HEVC) {
> > > + avio_w8(pb, FLV_IS_EX_HEADER | PacketTypeCodedFramesX |
> > > frametype); // ExVideoTagHeader mode with PacketTypeCodedFramesX
> > >
> >
> > frametype will << 2, so it's better to use below order:
> > FLV_IS_EX_HEADER | frametype | PacketTypeCodedFramesX
> fixed locally.
> >
> >
> >
> > > + avio_write(pb, "hvc1", 4);
> > > + } else {
> > > + avio_w8(pb, flags);
> > > + }
> > > if (par->codec_id == AV_CODEC_ID_VP6)
> > > avio_w8(pb,0);
> > > if (par->codec_id == AV_CODEC_ID_VP6F || par->codec_id ==
> > > AV_CODEC_ID_VP6A) {
> > > --
> > > 2.40.0
> > >
>
>
> Thanks
> Steven
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-02 15:52 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 9:44 [FFmpeg-devel] [PATCH v8 0/6] Suppor hevc av1 and vp9 codec " Steven Liu
2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 1/6] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
2023-05-11 17:58 ` Andreas Rheinhardt
2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg Steven Liu
2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 1/6] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 2/6] avformat/flvdec: support demux hevc in enhanced flv Steven Liu
2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 3/6] avformat/flvenc: support mux av1 " Steven Liu
2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 4/6] avformat/flvdec: support demux " Steven Liu
2023-05-12 3:59 ` [FFmpeg-devel] [PATCH v9 5/6] avformat/flvenc: support mux vp9 " Steven Liu
2023-05-12 3:59 ` [FFmpeg-devel] [PATCH v9 6/6] avformat/flvenc: support demux " Steven Liu
2023-05-12 10:31 ` [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg Timo Rothenpieler
2023-05-12 10:47 ` Steven Liu
2023-05-12 11:06 ` Timo Rothenpieler
2023-05-12 10:47 ` Vibhoothi
2023-05-12 11:59 ` Steven Liu
2023-05-13 2:40 ` Neal Gompa
2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 " Steven Liu
2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 1/6] avformat/flvenc: support mux hevc in enhanced flv Steven Liu
2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 2/6] avformat/flvdec: support demux " Steven Liu
2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 3/6] avformat/flvenc: support mux av1 " Steven Liu
2023-06-02 4:49 ` Tristan Matthews
2023-06-02 7:19 ` Steven Liu
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 0/6] Support enhanced flv in FFmpeg Steven Liu
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 1/6] avformat/flvenc: support mux hevc in enhanced flv Steven Liu
2023-06-02 11:08 ` Lance Wang
2023-06-02 11:28 ` Steven Liu
2023-06-02 15:52 ` Lance Wang [this message]
2023-06-02 23:44 ` Steven Liu
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 2/6] avformat/flvdec: support demux " Steven Liu
2023-06-02 11:15 ` Lance Wang
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 3/6] avformat/flvenc: support mux av1 " Steven Liu
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 4/6] avformat/flvdec: support demux " Steven Liu
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 5/6] avformat/flvenc: support mux vp9 " Steven Liu
2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 6/6] avformat/flvdec: support demux " Steven Liu
2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 4/6] avformat/flvdec: support demux av1 " Steven Liu
2023-05-15 8:32 ` [FFmpeg-devel] [PATCH v10 5/6] avformat/flvenc: support mux vp9 " Steven Liu
2023-05-15 8:32 ` [FFmpeg-devel] [PATCH v10 6/6] avformat/flvdec: support demux " Steven Liu
2023-05-15 20:41 ` [FFmpeg-devel] [PATCH v10 0/6] Support enhanced flv in FFmpeg Neal Gompa
2023-05-31 5:47 ` Neal Gompa
2023-06-01 0:02 ` Steven Liu
2023-06-01 5:03 ` Tristan Matthews
2023-06-01 6:07 ` Steven Liu
2023-06-01 17:57 ` Tristan Matthews
2023-06-02 1:37 ` Steven Liu
2023-06-01 9:29 ` Jean-Baptiste Kempf
2023-07-17 11:37 ` Jean-Baptiste Kempf
2023-07-17 14:07 ` Steven Liu
2023-06-06 6:42 ` Steven Liu
2023-06-08 0:02 ` Neal Gompa
2023-06-09 22:46 ` Tristan Matthews
2023-05-15 8:37 ` [FFmpeg-devel] [PATCH v9 " Steven Liu
2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 2/6] avformat/flvdec: support demux hevc in enhanced flv Steven Liu
2023-07-26 23:27 ` Michael Niedermayer
2023-07-27 2:43 ` Steven Liu
2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 3/6] avformat/flvenc: support mux av1 " Steven Liu
2023-05-08 23:07 ` Neal Gompa
2023-05-09 1:55 ` Steven Liu
2023-05-09 2:41 ` Neal Gompa
2023-05-09 4:14 ` Gyan Doshi
2023-05-09 10:35 ` Neal Gompa
2023-05-09 10:48 ` Gyan Doshi
2023-05-10 11:05 ` Neal Gompa
2023-05-10 11:13 ` Steven Liu
2023-05-11 1:31 ` Neal Gompa
2023-05-11 1:40 ` Steven Liu
2023-05-11 16:21 ` Neal Gompa
2023-05-11 16:26 ` Jean-Baptiste Kempf
2023-05-12 3:35 ` Neal Gompa
2023-05-12 5:23 ` Jean-Baptiste Kempf
2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 4/6] avformat/flvdec: support demux " Steven Liu
2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 5/6] avformat/flvenc: support mux vp9 " Steven Liu
2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 6/6] avformat/flvenc: support demux " Steven Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=jba--sQVkEo8D0GXMt_Y1V6NCd9QOwf2A=ACKGX67vi9Caw@mail.gmail.com' \
--to=lance.lmwang@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git