From: David Rosca <nowrep@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref
Date: Mon, 3 Mar 2025 14:47:29 +0100
Message-ID: <CAM7PDoiyXjNZe1YP8RO9ezJg18_StbaNd7oPoTW_k55BdLn1Sg@mail.gmail.com> (raw)
In-Reply-To: <20250115214000.73826-2-nowrep@gmail.com>
On Wed, Jan 15, 2025 at 10:41 PM David Rosca <nowrep@gmail.com> wrote:
>
> Don't need to alternate when only one reference is used.
> Fixes fail after bf9f921ef7 ("avcodec/hw_base_encode: restrict size of next_prev")
> due to AV1 writer complaining about incorrect ref_order_hint value.
Ping.
> ---
> libavcodec/vaapi_encode_av1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c
> index 1b350cd936..aca6c26aa2 100644
> --- a/libavcodec/vaapi_encode_av1.c
> +++ b/libavcodec/vaapi_encode_av1.c
> @@ -504,7 +504,7 @@ static int vaapi_encode_av1_init_picture_params(AVCodecContext *avctx,
> fh->base_q_idx = priv->q_idx_p;
> ref = pic->refs[0][pic->nb_refs[0] - 1];
> href = ref->codec_priv;
> - hpic->slot = !href->slot;
> + hpic->slot = ctx->base.ref_l0 > 1 ? !href->slot : 0;
> hpic->last_idr_frame = href->last_idr_frame;
> fh->refresh_frame_flags = 1 << hpic->slot;
>
> --
> 2.48.1
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2025-03-03 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250115214000.73826-2-nowrep@gmail.com>
2025-03-03 13:47 ` David Rosca [this message]
2025-03-04 1:54 ` Wang, Fei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM7PDoiyXjNZe1YP8RO9ezJg18_StbaNd7oPoTW_k55BdLn1Sg@mail.gmail.com \
--to=nowrep@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git