From: David Rosca <nowrep@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] vulkan_encode_h264/5: Fix uninitialized return value in write_extra_headers
Date: Mon, 28 Jul 2025 17:13:32 +0200
Message-ID: <CAM7PDoh3LL8A64xjbFpMGcyFTGqWRqJ+P3bHwFOuQNB9WP9cpw@mail.gmail.com> (raw)
In-Reply-To: <20241114213818.114718-2-nowrep@gmail.com>
On Thu, Nov 14, 2024 at 10:39 PM David Rosca <nowrep@gmail.com> wrote:
>
> ---
> libavcodec/vulkan_encode_h264.c | 1 +
> libavcodec/vulkan_encode_h265.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/libavcodec/vulkan_encode_h264.c b/libavcodec/vulkan_encode_h264.c
> index cdc87fb4ca..fdd3cc8a55 100644
> --- a/libavcodec/vulkan_encode_h264.c
> +++ b/libavcodec/vulkan_encode_h264.c
> @@ -1311,6 +1311,7 @@ static int write_extra_headers(AVCodecContext *avctx,
> if (err < 0)
> goto fail;
> } else {
> + err = 0;
> *data_len = 0;
> }
>
> diff --git a/libavcodec/vulkan_encode_h265.c b/libavcodec/vulkan_encode_h265.c
> index cd50f2f756..8c25cacded 100644
> --- a/libavcodec/vulkan_encode_h265.c
> +++ b/libavcodec/vulkan_encode_h265.c
> @@ -1471,6 +1471,7 @@ static int write_extra_headers(AVCodecContext *avctx,
> if (err < 0)
> goto fail;
> } else {
> + err = 0;
> *data_len = 0;
> }
>
> --
> 2.47.0
>
Ping, this causes random fails in release builds.
David
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
parent reply other threads:[~2025-07-28 15:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241114213818.114718-2-nowrep@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM7PDoh3LL8A64xjbFpMGcyFTGqWRqJ+P3bHwFOuQNB9WP9cpw@mail.gmail.com \
--to=nowrep@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git