[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

[Ramiro Polla]

---
 libavcodec/mpegvideo_enc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 73a9082265..82bab43e14 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc.c
@@ -562,7 +562,7 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx)
 
     if ((s->mpv_flags & FF_MPV_FLAG_QP_RD) &&
         avctx->mb_decision != FF_MB_DECISION_RD) {
-        av_log(avctx, AV_LOG_ERROR, "QP RD needs mbd=2\n");
+        av_log(avctx, AV_LOG_ERROR, "QP RD needs mbd=rd\n");
         return AVERROR(EINVAL);
     }
 
-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 435 bytes --]

On Tue, Jun 04, 2024 at 03:05:35PM +0200, Ramiro Polla wrote:
> ---
>  libavcodec/mpegvideo_enc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

[Ramiro Polla]

On Wed, Jun 5, 2024 at 1:51 AM Michael Niedermayer
<michael@niedermayer.cc> wrote:
> On Tue, Jun 04, 2024 at 03:05:35PM +0200, Ramiro Polla wrote:
> > ---
> >  libavcodec/mpegvideo_enc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM

Pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".