From: Ramiro Polla <ramiro.polla@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments
Date: Wed, 5 Jun 2024 19:42:08 +0200
Message-ID: <CALweWgC=9itVAb1KopuAOMz7XgKV2YsaVBNs3XKbB9sOj4Xe7A@mail.gmail.com> (raw)
In-Reply-To: <20240604131535.47041-1-ramiro.polla@gmail.com>
On Tue, Jun 4, 2024 at 3:15 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
>
> ---
> libswscale/x86/yuv_2_rgb.asm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm
> index e3470fd9ad..a1f9134e08 100644
> --- a/libswscale/x86/yuv_2_rgb.asm
> +++ b/libswscale/x86/yuv_2_rgb.asm
> @@ -195,15 +195,15 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters
> mova m5, m7
> paddsw m3, m0 ; B1 B3 B5 B7 ...
> paddsw m5, m1 ; R1 R3 R5 R7 ...
> - paddsw m7, m2 ; G1 G3 G4 G7 ...
> + paddsw m7, m2 ; G1 G3 G5 G7 ...
> paddsw m0, m6 ; B0 B2 B4 B6 ...
> paddsw m1, m6 ; R0 R2 R4 R6 ...
> paddsw m2, m6 ; G0 G2 G4 G6 ...
>
> %if %3 == 24 ; PACK RGB24
> %define depth 3
> - packuswb m0, m3 ; R0 R2 R4 R6 ... R1 R3 R5 R7 ...
> - packuswb m1, m5 ; B0 B2 B4 B6 ... B1 B3 B5 B7 ...
> + packuswb m0, m3 ; B0 B2 B4 B6 ... B1 B3 B5 B7 ...
> + packuswb m1, m5 ; R0 R2 R4 R6 ... R1 R3 R5 R7 ...
> packuswb m2, m7 ; G0 G2 G4 G6 ... G1 G3 G5 G7 ...
> mova m3, m_red
> mova m6, m_blue
> @@ -248,7 +248,7 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters
> psrlq m5, 32
> movd [imageq + 20], m2 ; -- -- G7 B7
> movd [imageq + 18], m5 ; R6 G6 B6 R7
> -%endif ; mmsize = 8
> +%endif ; cpuflag
> %else ; mmsize == 16
> pshufb m3, [rgb24_shuf1] ; r0 g0 r6 g6 r12 g12 r2 g2 r8 g8 r14 g14 r4 g4 r10 g10
> pshufb m6, [rgb24_shuf2] ; b10 r11 b0 r1 b6 r7 b12 r13 b2 r3 b8 r9 b14 r15 b4 r5
> --
> 2.30.2
>
I'll apply tomorrow.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-05 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 13:15 Ramiro Polla
2024-06-05 17:42 ` Ramiro Polla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALweWgC=9itVAb1KopuAOMz7XgKV2YsaVBNs3XKbB9sOj4Xe7A@mail.gmail.com' \
--to=ramiro.polla@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git