* [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)
@ 2024-05-30 21:20 Ramiro Polla
2024-05-30 21:23 ` Sean McGovern
0 siblings, 1 reply; 4+ messages in thread
From: Ramiro Polla @ 2024-05-30 21:20 UTC (permalink / raw)
To: ffmpeg-devel
---
libavcodec/libxvid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
index b9ac39429d..a490f16b3f 100644
--- a/libavcodec/libxvid.c
+++ b/libavcodec/libxvid.c
@@ -422,13 +422,13 @@ static av_cold int xvid_encode_init(AVCodecContext *avctx)
/* Decide how we should decide blocks */
switch (avctx->mb_decision) {
- case 2:
+ case FF_MB_DECISION_RD:
x->vop_flags |= XVID_VOP_MODEDECISION_RD;
x->me_flags |= XVID_ME_HALFPELREFINE8_RD |
XVID_ME_QUARTERPELREFINE8_RD |
XVID_ME_EXTSEARCH_RD |
XVID_ME_CHECKPREDICTION_RD;
- case 1:
+ case FF_MB_DECISION_BITS:
if (!(x->vop_flags & XVID_VOP_MODEDECISION_RD))
x->vop_flags |= XVID_VOP_FAST_MODEDECISION_RD;
x->me_flags |= XVID_ME_HALFPELREFINE16_RD |
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)
2024-05-30 21:20 [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers) Ramiro Polla
@ 2024-05-30 21:23 ` Sean McGovern
2024-06-04 12:54 ` Ramiro Polla
0 siblings, 1 reply; 4+ messages in thread
From: Sean McGovern @ 2024-05-30 21:23 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Thu, May 30, 2024 at 5:20 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
>
> ---
> libavcodec/libxvid.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
> index b9ac39429d..a490f16b3f 100644
> --- a/libavcodec/libxvid.c
> +++ b/libavcodec/libxvid.c
> @@ -422,13 +422,13 @@ static av_cold int xvid_encode_init(AVCodecContext *avctx)
>
> /* Decide how we should decide blocks */
> switch (avctx->mb_decision) {
> - case 2:
> + case FF_MB_DECISION_RD:
> x->vop_flags |= XVID_VOP_MODEDECISION_RD;
> x->me_flags |= XVID_ME_HALFPELREFINE8_RD |
> XVID_ME_QUARTERPELREFINE8_RD |
> XVID_ME_EXTSEARCH_RD |
> XVID_ME_CHECKPREDICTION_RD;
> - case 1:
> + case FF_MB_DECISION_BITS:
> if (!(x->vop_flags & XVID_VOP_MODEDECISION_RD))
> x->vop_flags |= XVID_VOP_FAST_MODEDECISION_RD;
> x->me_flags |= XVID_ME_HALFPELREFINE16_RD |
> --
> 2.30.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
This gets a +1 from me.
-- Sean McGover
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)
2024-05-30 21:23 ` Sean McGovern
@ 2024-06-04 12:54 ` Ramiro Polla
2024-06-05 17:41 ` Ramiro Polla
0 siblings, 1 reply; 4+ messages in thread
From: Ramiro Polla @ 2024-06-04 12:54 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Thu, May 30, 2024 at 11:24 PM Sean McGovern <gseanmcg@gmail.com> wrote:
> On Thu, May 30, 2024 at 5:20 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
> >
> > ---
> > libavcodec/libxvid.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
> > index b9ac39429d..a490f16b3f 100644
> > --- a/libavcodec/libxvid.c
> > +++ b/libavcodec/libxvid.c
> > @@ -422,13 +422,13 @@ static av_cold int xvid_encode_init(AVCodecContext *avctx)
> >
> > /* Decide how we should decide blocks */
> > switch (avctx->mb_decision) {
> > - case 2:
> > + case FF_MB_DECISION_RD:
> > x->vop_flags |= XVID_VOP_MODEDECISION_RD;
> > x->me_flags |= XVID_ME_HALFPELREFINE8_RD |
> > XVID_ME_QUARTERPELREFINE8_RD |
> > XVID_ME_EXTSEARCH_RD |
> > XVID_ME_CHECKPREDICTION_RD;
> > - case 1:
> > + case FF_MB_DECISION_BITS:
> > if (!(x->vop_flags & XVID_VOP_MODEDECISION_RD))
> > x->vop_flags |= XVID_VOP_FAST_MODEDECISION_RD;
> > x->me_flags |= XVID_ME_HALFPELREFINE16_RD |
> > --
> > 2.30.2
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> This gets a +1 from me.
I'll apply tomorrow.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)
2024-06-04 12:54 ` Ramiro Polla
@ 2024-06-05 17:41 ` Ramiro Polla
0 siblings, 0 replies; 4+ messages in thread
From: Ramiro Polla @ 2024-06-05 17:41 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Jun 4, 2024 at 2:54 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
> On Thu, May 30, 2024 at 11:24 PM Sean McGovern <gseanmcg@gmail.com> wrote:
> > On Thu, May 30, 2024 at 5:20 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
> > >
> > > ---
> > > libavcodec/libxvid.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
> > > index b9ac39429d..a490f16b3f 100644
> > > --- a/libavcodec/libxvid.c
> > > +++ b/libavcodec/libxvid.c
> > > @@ -422,13 +422,13 @@ static av_cold int xvid_encode_init(AVCodecContext *avctx)
> > >
> > > /* Decide how we should decide blocks */
> > > switch (avctx->mb_decision) {
> > > - case 2:
> > > + case FF_MB_DECISION_RD:
> > > x->vop_flags |= XVID_VOP_MODEDECISION_RD;
> > > x->me_flags |= XVID_ME_HALFPELREFINE8_RD |
> > > XVID_ME_QUARTERPELREFINE8_RD |
> > > XVID_ME_EXTSEARCH_RD |
> > > XVID_ME_CHECKPREDICTION_RD;
> > > - case 1:
> > > + case FF_MB_DECISION_BITS:
> > > if (!(x->vop_flags & XVID_VOP_MODEDECISION_RD))
> > > x->vop_flags |= XVID_VOP_FAST_MODEDECISION_RD;
> > > x->me_flags |= XVID_ME_HALFPELREFINE16_RD |
> > > --
> > > 2.30.2
> > >
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
> > > To unsubscribe, visit link above, or email
> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> > This gets a +1 from me.
>
> I'll apply tomorrow.
Pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-05 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-30 21:20 [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers) Ramiro Polla
2024-05-30 21:23 ` Sean McGovern
2024-06-04 12:54 ` Ramiro Polla
2024-06-05 17:41 ` Ramiro Polla
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git