Re: [FFmpeg-devel] [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value

[Ramiro Polla <ramiro.polla@gmail.com>]

Hi Andreas,

On Mon, Mar 3, 2025 at 2:12 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Andreas Rheinhardt:
> > Patches attached; the first few were already sent last year [1], but I
> > have refrained from pushing them because Michael seems to have trouble
> > testing them due to a conflict [2] that existed by the time he tried to
> > test it.
> >
> > - Andreas
> >
> > [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-July/330467.html
> > [2]: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333737.html
> >
> Will apply this patchset tomorrow unless there are objections.

A few nits:

- [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value prematurely
There's a slight phrasing issue in the first paragraph of the commit
message: "it copies the keeps several sets".

- [PATCH 03/30] avcodec/motion_est: Avoid branches for put(_no_rnd) selection
Could you please add to the commit message that [hq]pel_put are
already being set in ff_me_init_pic()?

- [PATCH 06/30] tests/fate/vcodec: Test alternate_scan
Can't we add a new test for alternate_scan instead? It's not that
important though.

- [PATCH 10/30] avcodec/h261dec: Inline constant
Could you please add to the commit message that y_dc_scale was set in
mpeg1_decode_picture(), and maybe even that it will be removed in the
following commit?

- [PATCH 15/30] avcodec/mips/mpegvideo_mmi: Don't check alternate_scan
unnecessarily
Thanks!

- [PATCH 20/30] avcodec/vc1: Add max_b_frames field to VC1Context
Could you please copy the comment for the new field in vc1.h as well?

- [PATCH 26/30] avcodec/mpeg4videodec: Avoid copying packed bitstream data
Could you please note in the commit message that this was done using
referenced AVBuffers?

Ramiro
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".