From: Ramiro Polla <ramiro.polla@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
Date: Wed, 5 Mar 2025 04:17:02 +0100
Message-ID: <CALweWgAB_C14kva_De7497ObKD0p4RJJ1h15Qon4D9FHZFVRfw@mail.gmail.com> (raw)
In-Reply-To: <05a27083-3f19-49e3-b673-b112fb45b1dc@comstyle.com>
Hi Brad,
On Wed, Mar 5, 2025 at 2:24 AM Brad Smith
<brad-at-comstyle.com@ffmpeg.org> wrote:
> On 2023-08-23 4:52 p.m., Michael Niedermayer wrote:
> > On Fri, Aug 18, 2023 at 10:14:04PM -0400, Brad Smith wrote:
> >> lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
> >>
> >> Add a check for the existence of the vec_xl() function. Clang provides
> >> the function even with VSX not enabled.
> >>
> >> v2: test for function if AltiVec is enabled instead of with AltiVec and without VSX
> >> ---
> >> configure | 8 ++++++++
> >> libswscale/ppc/yuv2rgb_altivec.c | 4 ++--
> >> 2 files changed, 10 insertions(+), 2 deletions(-)
> > Has this been tested on an affected platform ?
> > I mean the function is provided but does it also work ?
>
> This has been in the FreeBSD / OpenBSD ports for years. So to a certain
> extent yes. Anyway, I didn't have access to my test VM for quite some
> time but I do now and ran the various tests with FATE and did not see
> any issues.
Build doesn't seem to fail anymore, but that's probably because of the
#if 0 from b9eaf6e05c2ca16d94869e0263236dbdac752400.
Could you please send a rebased patch?
Ramiro
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-03-05 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 2:14 Brad Smith
2023-08-23 20:52 ` Michael Niedermayer
2025-03-05 1:24 ` Brad Smith
2025-03-05 3:17 ` Ramiro Polla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALweWgAB_C14kva_De7497ObKD0p4RJJ1h15Qon4D9FHZFVRfw@mail.gmail.com \
--to=ramiro.polla@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git