From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 310E440267
	for <ffmpegdev@gitmailbox.com>; Thu, 20 Jan 2022 21:06:23 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCCAA68B215;
	Thu, 20 Jan 2022 23:06:21 +0200 (EET)
Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com
 [209.85.219.49])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 705DC68B1B4
 for <ffmpeg-devel@ffmpeg.org>; Thu, 20 Jan 2022 23:06:15 +0200 (EET)
Received: by mail-qv1-f49.google.com with SMTP id u26so8158820qva.7
 for <ffmpeg-devel@ffmpeg.org>; Thu, 20 Jan 2022 13:06:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=ylo-ph.20210112.gappssmtp.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=wPecIj0NKGWj8T+7GggWIhl7Y6WxtYth9Yqtq6roavQ=;
 b=AcbtveYKuZ4xd9JYX3SUFR3+4uZdPOvpN+vlpe0zKaqJDLHAZczjpDT6hp1UHd/qgZ
 gjONxM8pN6IjvzXJYkm6OAdwhGz0kOdvXk4JezhcBXSCMMS9pGV0L06HubsdpNNfytpb
 zqB/c2ap0xIZwZ1Ug12VyYDJGtzlqzowRUPrdBrb0vVh7dA2dffafYj4rJv9PB/zJxif
 qivNY+D0PS+5sgv1nKNUWKTfe7Z6mXfTm/EzSSNU0dv26iThyPSX+W4YTRi4N6GE8dtC
 I/xIClueQRMnisQVJhztyYRUTt1SSQa1Btxfuf6YB76gp33GbHw9anWodyGnmY7NazJ3
 vjhQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=wPecIj0NKGWj8T+7GggWIhl7Y6WxtYth9Yqtq6roavQ=;
 b=yy57+Qipb4BKzjVXyo04fx8amro2G/z5Fi9Cm96W8xjNRoAJLL15spSn5z7HKNnEhI
 9gCu6VtRhBu+b2aEOaeLFDOw0SbGjVyA15feKfKnUfAL3DantayNmguXKmbTOajD8kyQ
 OKK7QlafQZB1MlALxzv7meONH/vsV9zFktwbm2pW/xOvLuEFdym9PRcxdJgBlqYmdYQq
 JJrGBsirmxKfUDaVWJ3kj4oBSDOi18uMR62ZYoNJj+XfjpTUc44nkLAsQbXHyc7nPn/v
 y8CnJfIbsMWh8OhBF5haNb9+0+HMsXUFAhnE5EQKNooCuiYNo7bQORVeADypY0/yQNXa
 +k5A==
X-Gm-Message-State: AOAM533+5wuEfB75gcy4NdarqtrtNQ2QPGDBQGSYuLstZ1m4pn3r8iMz
 zK9oV4pOSK17wcNQzpECwzdhphfjO+sjyShjda5SZ7/KnKQ=
X-Google-Smtp-Source: ABdhPJxY+QZMBxSFNV7WIX/bdGGeMQF8vktcFq0XDz+jmD1Ax8AsUdGaXkHg502rQn05E061I2jKs2xkh2RkB22+8mc=
X-Received: by 2002:a05:6214:c41:: with SMTP id r1mr860970qvj.76.1642712773808; 
 Thu, 20 Jan 2022 13:06:13 -0800 (PST)
MIME-Version: 1.0
References: <CALbjROLP4=3xmpvM8EW1A3fA4==oo=YpK+vjeB-ueoQSpomoKA@mail.gmail.com>
 <CALbjROJOuyUN8gL6eJ2KGHQV4VRQ5-kcdkOUNg2SC8L4wF-hUA@mail.gmail.com>
 <YNx3sBpzP3r6p++p@sunshine.barsnick.net>
 <CALbjROK0dZq0oQyh8eZHJb5D2yo7bUB-bnoD55L00zcS8EJ+Tg@mail.gmail.com>
 <CAPYw7P7RYkgjP_kZw7_EiW4VurQ-Sqp13kZMYVvOoOCYGa8sdw@mail.gmail.com>
 <CALbjROKe18KkXcABP4YAv3txaBbNOBAB6xOLJpVs5K017F0LQA@mail.gmail.com>
 <AM7PR03MB666052D545FBD63EF3FBE87A8F499@AM7PR03MB6660.eurprd03.prod.outlook.com>
 <CALbjRO+2dqAwvbfQZE-QdMjiyP9oL9zCX3rHg+6THVuJcpnHpA@mail.gmail.com>
 <AM7PR03MB6660859C925C0A9DC3F0AAF28F509@AM7PR03MB6660.eurprd03.prod.outlook.com>
 <CALbjROLT3wVnkWUFJ2bu9-doVyh4JKgHz5s7AbXD4X2k2UF3QQ@mail.gmail.com>
 <CALbjROJf9HsJKNi_HfOLbv4z6YTKA_nudTsUq2++ht_VdVCLEg@mail.gmail.com>
In-Reply-To: <CALbjROJf9HsJKNi_HfOLbv4z6YTKA_nudTsUq2++ht_VdVCLEg@mail.gmail.com>
From: Kyle Swanson <k@ylo.ph>
Date: Thu, 20 Jan 2022 13:06:03 -0800
Message-ID: <CALbjROLxQ_qh8ch8Bf4kZE_Ez0TEpZhiiuv0RyP7UY8iNZjvOQ@mail.gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for
 libvmaf v2.0.0
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/CALbjROLxQ_qh8ch8Bf4kZE_Ez0TEpZhiiuv0RyP7UY8iNZjvOQ@mail.gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Hi,

On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson <k@ylo.ph> wrote:
>
> Hi,
>
> On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson <k@ylo.ph> wrote:
> >
> > Hi,
> >
> > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt
> > <andreas.rheinhardt@outlook.com> wrote:
> > > 1. FFmpeg uses the ancient C90 rule that only allows variable
> > > declarations at the beginning of a block (before all statements). You
> > > should actually have received a compiler warning because of the above
> > > code (unless you use Clang, which claims to support this type of
> > > warning, yet doesn't).
> > > 2. You jump over the initializion of str_copy if the dict allocation
> > > fails and consequently you free an uninitialized string.
> >
> > New patch attached. Fixes all of the GCC -Wdeclaration-after-statement
> > warnings. You're right, I didn't notice because I was building with
> > Clang. Andreas, I will just wait for your LGTM before merging.
> >
> > Thanks,
> > Kyle
>
> Updated patch attached. Thank you to mkver for the mini review on IRC.
> The `delimited_dict_parse` multi-delimiter corner case should be
> sorted now.
>
> Thanks,
> Kyle

Will push this soon.

Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".