From: Kyle Swanson <k@ylo.ph>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0
Date: Thu, 20 Jan 2022 13:06:03 -0800
Message-ID: <CALbjROLxQ_qh8ch8Bf4kZE_Ez0TEpZhiiuv0RyP7UY8iNZjvOQ@mail.gmail.com> (raw)
In-Reply-To: <CALbjROJf9HsJKNi_HfOLbv4z6YTKA_nudTsUq2++ht_VdVCLEg@mail.gmail.com>
Hi,
On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson <k@ylo.ph> wrote:
>
> Hi,
>
> On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson <k@ylo.ph> wrote:
> >
> > Hi,
> >
> > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt
> > <andreas.rheinhardt@outlook.com> wrote:
> > > 1. FFmpeg uses the ancient C90 rule that only allows variable
> > > declarations at the beginning of a block (before all statements). You
> > > should actually have received a compiler warning because of the above
> > > code (unless you use Clang, which claims to support this type of
> > > warning, yet doesn't).
> > > 2. You jump over the initializion of str_copy if the dict allocation
> > > fails and consequently you free an uninitialized string.
> >
> > New patch attached. Fixes all of the GCC -Wdeclaration-after-statement
> > warnings. You're right, I didn't notice because I was building with
> > Clang. Andreas, I will just wait for your LGTM before merging.
> >
> > Thanks,
> > Kyle
>
> Updated patch attached. Thank you to mkver for the mini review on IRC.
> The `delimited_dict_parse` multi-delimiter corner case should be
> sorted now.
>
> Thanks,
> Kyle
Will push this soon.
Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-20 21:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALbjROLP4=3xmpvM8EW1A3fA4==oo=YpK+vjeB-ueoQSpomoKA@mail.gmail.com>
[not found] ` <CALbjROJOuyUN8gL6eJ2KGHQV4VRQ5-kcdkOUNg2SC8L4wF-hUA@mail.gmail.com>
[not found] ` <YNx3sBpzP3r6p++p@sunshine.barsnick.net>
2021-12-24 20:51 ` Kyle Swanson
2021-12-24 20:54 ` Timo Rothenpieler
2021-12-31 1:01 ` Kyle Swanson
2021-12-25 9:24 ` Paul B Mahol
2021-12-31 1:03 ` Kyle Swanson
2022-01-02 18:24 ` Kyle Swanson
2022-01-03 5:21 ` Andreas Rheinhardt
2022-01-03 22:32 ` Kyle Swanson
2022-01-08 22:08 ` Kyle Swanson
2022-01-10 18:22 ` Andreas Rheinhardt
2022-01-14 2:38 ` Kyle Swanson
2022-01-19 18:23 ` Kyle Swanson
2022-01-20 21:06 ` Kyle Swanson [this message]
2022-01-23 21:22 ` Kyle Swanson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALbjROLxQ_qh8ch8Bf4kZE_Ez0TEpZhiiuv0RyP7UY8iNZjvOQ@mail.gmail.com \
--to=k@ylo.ph \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git