From: Kyle Swanson <k@ylo.ph>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c
Date: Thu, 30 Nov 2023 14:19:45 -0800
Message-ID: <CALbjROLt9wG10G-vyrqgRJ+g5GhZ+4i_L6SSJQJtbYgQgPBByA@mail.gmail.com> (raw)
In-Reply-To: <CAPYw7P62VfZ4TaNgpywTy2=NbGWkpAmBmYZ1RnDXzk1LL_AsRQ@mail.gmail.com>
Hi,
On Thu, Nov 30, 2023 at 1:36 PM Paul B Mahol <onemda@gmail.com> wrote:
>
> Loudnorm filter is big pile of hacks, I wanted to move forward and I
> improved it.
>
> I received nothing in return just some politics talks.
>
> I will apply this soon unless technical comments arise.
>
> Why would I spend on this more my precious time? For no real gain as I will
> again
> receive nothing in return except some useless comment and no single
> technical aspect.
Please don't merge this as-is. I'm sure there are good changes/fixes
here that we should merge, but you need to help your reviewers
understand what is going on. One big commit that combines both
refactoring across files with introduction of new filter behavior is
very hard to review. That's why I'm suggesting we do this in two
steps, I think Anton's suggestion is the same.
Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-30 22:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 21:46 Paul B Mahol
2023-11-15 20:46 ` Paul B Mahol
2023-11-17 6:38 ` Kyle Swanson
2023-11-19 11:56 ` Paul B Mahol
2023-11-19 21:55 ` Marton Balint
2023-11-19 23:37 ` Paul B Mahol
2023-11-21 18:53 ` Kyle Swanson
2023-11-28 16:51 ` Paul B Mahol
2023-11-30 11:43 ` Anton Khirnov
2023-11-30 12:48 ` Paul B Mahol
2023-11-30 13:47 ` Anton Khirnov
2023-11-30 14:01 ` Paul B Mahol
2023-11-30 13:57 ` Anton Khirnov
2023-11-30 14:20 ` Paul B Mahol
2023-11-30 18:34 ` Kyle Swanson
2023-11-30 21:44 ` Paul B Mahol
2023-11-30 22:19 ` Kyle Swanson [this message]
2023-11-30 22:51 ` Paul B Mahol
2023-11-30 23:29 ` Kyle Swanson
2023-12-01 10:45 ` Paul B Mahol
2023-12-01 21:12 ` Kyle Swanson
2023-12-01 21:27 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALbjROLt9wG10G-vyrqgRJ+g5GhZ+4i_L6SSJQJtbYgQgPBByA@mail.gmail.com \
--to=k@ylo.ph \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git