[FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

[FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

[Gyan Doshi]

3d29724c00 removed the doc entry for the option pool while adding
a parser function for it at the same time!

The option remains available and undeprecated.
---
 doc/filters.texi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/filters.texi b/doc/filters.texi
index 5268b2003c..80ffbb2c65 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -16864,6 +16864,10 @@ Set the file path to be used to store log files.
 @item log_fmt
 Set the format of the log file (xml, json, csv, or sub).
 
+@item pool
+Set the pool method to be used for computing vmaf.
+Options are @code{min}, @code{harmonic_mean} or @code{mean} (default).
+
 @item n_threads
 Set number of threads to be used when initializing libvmaf.
 Default value: @code{0}, no threads.
-- 
2.39.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

[Gyan Doshi]

Will push soon.

On 2023-11-26 04:08 pm, Gyan Doshi wrote:
> 3d29724c00 removed the doc entry for the option pool while adding
> a parser function for it at the same time!
>
> The option remains available and undeprecated.
> ---
>   doc/filters.texi | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 5268b2003c..80ffbb2c65 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -16864,6 +16864,10 @@ Set the file path to be used to store log files.
>   @item log_fmt
>   Set the format of the log file (xml, json, csv, or sub).
>   
> +@item pool
> +Set the pool method to be used for computing vmaf.
> +Options are @code{min}, @code{harmonic_mean} or @code{mean} (default).
> +
>   @item n_threads
>   Set number of threads to be used when initializing libvmaf.
>   Default value: @code{0}, no threads.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

[Kyle Swanson]

Hi,

On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
> Will push soon.

This filter can take any number of models now, each defining their own
pooling methods. Looking at the docs now, I can see that it's not
clear how to do this, I'll need to send a patch on that. The global
`pool` option has been deprecated and removed already.

Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

[Gyan Doshi]

On 2023-11-27 11:38 pm, Kyle Swanson wrote:
> Hi,
>
> On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>> Will push soon.
> This filter can take any number of models now, each defining their own
> pooling methods. Looking at the docs now, I can see that it's not
> clear how to do this, I'll need to send a patch on that. The global
> `pool` option has been deprecated and removed already.

Do you mean in the lib? Because in ffmpeg git master, in the wrapper, 
the option remains available and undeprecated.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

[Kyle Swanson]

Hi,

On Mon, Nov 27, 2023 at 10:15 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
> Do you mean in the lib? Because in ffmpeg git master, in the wrapper,
> the option remains available and undeprecated.
>
> Regards,
> Gyan

Oops, you're right. Ignore everything I just said, sorry for the noise.

Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".