From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 853A843E15 for ; Wed, 14 Sep 2022 21:27:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E975168B8EC; Thu, 15 Sep 2022 00:27:18 +0300 (EEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D7F5768B8EC for ; Thu, 15 Sep 2022 00:27:12 +0300 (EEST) Received: by mail-wr1-f49.google.com with SMTP id bq9so27718726wrb.4 for ; Wed, 14 Sep 2022 14:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ylo-ph.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=9UMbrDcTxMVtnPTOJ24Y0Z5+srrQzFZvUkevEKMFf/s=; b=sWkJ3QZjsGDIKBF25l6mmV0Jbu41qCbOX8WKUe4wA+7Afe2ArcLlCpudGrZM85merq HT+DC0/G4XoHvIHEX1XwxuREdlYYSh7AsePPxk1TRjQ0J8RrXR3PW/NLPsu4I1RVfLnp BuYqQ3VBhmdxQjSRuVEbZbh3K4v7CP+tn05oSGNYqzDRiKW5zOlSO7ssus9iLG7TxhV9 AO/2enjqqhXMSuSTHXFGnE0T/ivyfPGHinZYTZH07j1Xfg8C7AyrwV6Pteeug3Ae/OLV VcvKR+vH/FNzETatTeSfyGnZYvKTUl7mUzg2nET0788V7qn0H0eYy/jX70BvlQEf8WLF RNaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=9UMbrDcTxMVtnPTOJ24Y0Z5+srrQzFZvUkevEKMFf/s=; b=3ZvKG7XQHXBjP9S4s/3cUgHBD6kwixzcjBRFLQWDtfWfQ/G8FnAX93uOXliIc1vLI5 JXPkLvYzaF3YJOeZPzoOhSFWkFfehRqH1O4j9f+PCeZ8t8d7XH4LkOvYozKf4h/nfwCe 6Y+6+VhR4FP3H4eYaquCd0dYRwlQjDz3puoiMWPi3awdpV5CrJMabNcyCNtUFLMMNhB2 l76jq3iUvSBO9YbAPNEeQOAXxM3fqTPPs6sRtFqOyH3cabTxI8aHeo54/WmxOljcU18M cfJN661vaJiRlXTAmP43ekMrB6iqmhq58TyT+I5A3AmEJyE7PVMlk/4J9nVrBq+GfORk NBOA== X-Gm-Message-State: ACgBeo2anS30jgXEaKGYvsl5JUIe55Z4rZ2dUhv086/VlT2L/0WFzOLP 4N8bk8IIW4OI10hh2VXGq97aTgApaIGi2OJLWb4Xe+q/cgI= X-Google-Smtp-Source: AA6agR6WZ6R1XUOF7K2yeQThP1bMh4LBq7sZ2rmoTw4/7KjombsLo5el9yHKwwXpFWKy4DeOgqRaCfKVsQ9r/pAuFhQ= X-Received: by 2002:adf:ea05:0:b0:229:9c4c:ec78 with SMTP id q5-20020adfea05000000b002299c4cec78mr22074496wrm.213.1663190832063; Wed, 14 Sep 2022 14:27:12 -0700 (PDT) MIME-Version: 1.0 References: <20220909175402.82657-1-yondon.fu@gmail.com> In-Reply-To: <20220909175402.82657-1-yondon.fu@gmail.com> From: Kyle Swanson Date: Wed, 14 Sep 2022 14:27:01 -0700 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Yondon Fu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Fri, Sep 9, 2022 at 10:58 AM Yondon Fu wrote: > Update description for ssim and ms_ssim libvmaf options to specify > feature=float_ssim and feature=float_ms_ssim which are used to request > ssim and ms_ssim values in the latest versions of libvmaf. > > Signed-off-by: Yondon Fu > --- > libavfilter/vf_libvmaf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index eee1c280ef..e4b439685e 100644 > --- a/libavfilter/vf_libvmaf.c > +++ b/libavfilter/vf_libvmaf.c > @@ -70,8 +70,8 @@ static const AVOption libvmaf_options[] = { > {"enable_transform", "use model='enable_transform=true'.", > OFFSET(enable_transform), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > {"phone_model", "use model='enable_transform=true'.", > OFFSET(phone_model), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > {"psnr", "use feature='name=psnr'.", > OFFSET(psnr), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > - {"ssim", "use feature='name=ssim'.", > OFFSET(ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > - {"ms_ssim", "use feature='name=ms_ssim'.", > OFFSET(ms_ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > + {"ssim", "use feature='name=float_ssim'.", > OFFSET(ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > + {"ms_ssim", "use feature='name=float_ms_ssim'.", > OFFSET(ms_ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, > FLAGS|AV_OPT_FLAG_DEPRECATED}, > {"pool", "Set the pool method to be used for computing vmaf.", > OFFSET(pool), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > {"n_threads", "Set number of threads to be used when computing > vmaf.", OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, > UINT_MAX, FLAGS}, > {"n_subsample", "Set interval for frame subsampling used when > computing vmaf.", OFFSET(n_subsample), AV_OPT_TYPE_INT, {.i64=1}, 1, > UINT_MAX, FLAGS}, > -- > 2.26.2 > Thanks for the fix, I will apply this soon. Kyle _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".