From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 04C444289A for ; Sat, 8 Jan 2022 22:08:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C58F68AB2E; Sun, 9 Jan 2022 00:08:47 +0200 (EET) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1CB3368A375 for ; Sun, 9 Jan 2022 00:08:40 +0200 (EET) Received: by mail-qt1-f178.google.com with SMTP id a1so9767693qtx.11 for ; Sat, 08 Jan 2022 14:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ylo-ph.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ko6WO5YHIlve2gGOW9A3NaHyDKjY0H0Ky7LS8DLNTG8=; b=vnGjRYrcvSm4A2y9sBpmiGIysm3lf89B/D368mnnTZoXGWbuHDPMRZuC1EdEoULyIn IDry+wwdURmmuMi6eSSjoWZ0/blkZt0zC90AxR8BaYvb0AirLfI4ue1O1e2u781t1D15 q+FxhlQfWllyaHk7R1hEEpKrl3tI8OWya1gxxb2iR/f4qij35H7D+FHHr9BIkfjXpFuL fwoYs+OhJnLlR/XROQBkngxMSKTdBH0EpKOic6bpbjFAjIu4CrY19DJcJcSOa/14oCGZ G4V4FWWmRRmGD9BagI7LjZ/zchw7MErBPZIh+d7H4sCWOT17ihz6kTRjUNcbhBJXaC2j 7jXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ko6WO5YHIlve2gGOW9A3NaHyDKjY0H0Ky7LS8DLNTG8=; b=7AmVYYPq9xQR4acJJSDiyUgi9I7ka87BfdxmaCUtsOsAlvEOO+84pdnIINRRNNwCU9 GY+DuJJT+ASrCiggyVINZ+/Mga1VjOJMkj5eSUyS8KTuYXbGN19ViBU/yuE5n32QKuWS KYEbda3P6TGhRrbpeu9o/Os2bxF4iqJM6rqAn1DoDhJchvci22otpNKLdv/9vnkPxmnm WDnXPj/abKUTlM5jGML0vz34wLM1zvWuicRTi9v4SXYiL2fZteiWR90RrQJ9vofr6Ytn 8lNdds9s85nRKenNtf0nlL/lJlP6ATD88WF3Z3JdG9gqi6ofjiB8CzB7uBYJ9XVu1WcH 8LVg== X-Gm-Message-State: AOAM530BraK8brbOPv0jtebSkp3VxiZIUDACSPcOmm1cey1/oDJgllFN R/VqsgkXNmSagYtzghUshpQ0KNnsaWVY4ISgwhMEVLN+dbM= X-Google-Smtp-Source: ABdhPJyxKpTZ2WFdC+Uc9cJj7t84Ei7L5RFQLzsf+0BMDZQ/336BjHVVRyBbX1BavuLvTFS944WC7ih8Pzm0a+DeLns= X-Received: by 2002:a05:622a:590:: with SMTP id c16mr61177949qtb.289.1641679716943; Sat, 08 Jan 2022 14:08:36 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kyle Swanson Date: Sat, 8 Jan 2022 14:08:26 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Mon, Jan 3, 2022 at 2:32 PM Kyle Swanson wrote: > > Hi, > > On Sun, Jan 2, 2022 at 9:21 PM Andreas Rheinhardt > wrote: > > > > > > static const AVOption libvmaf_options[] = { > > > - {"model_path", "Set the model to be used for computing vmaf.", OFFSET(model_path), AV_OPT_TYPE_STRING, {.str="/usr/local/share/model/vmaf_v0.6.1.pkl"}, 0, 1, FLAGS}, > > > - {"log_path", "Set the file path to be used to store logs.", OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > > > - {"log_fmt", "Set the format of the log (csv, json or xml).", OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > > > - {"enable_transform", "Enables transform for computing vmaf.", OFFSET(enable_transform), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > > - {"phone_model", "Invokes the phone model that will generate higher VMAF scores.", OFFSET(phone_model), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > > - {"psnr", "Enables computing psnr along with vmaf.", OFFSET(psnr), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > > - {"ssim", "Enables computing ssim along with vmaf.", OFFSET(ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > > - {"ms_ssim", "Enables computing ms-ssim along with vmaf.", OFFSET(ms_ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > > - {"pool", "Set the pool method to be used for computing vmaf.", OFFSET(pool), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > > > + {"model", "Set the model to be used for computing vmaf.", OFFSET(model_cfg), AV_OPT_TYPE_STRING, {.str="version=vmaf_v0.6.1"}, 0, 1, FLAGS}, > > > + {"feature", "Set the feature to be used for computing vmaf.", OFFSET(feature_cfg), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > > > + {"log_path", "Set the file path to be used to write log.", OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > > > + {"log_fmt", "Set the format of the log (csv, json, xml, or sub).", OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str="xml"}, 0, 1, FLAGS}, > > > {"n_threads", "Set number of threads to be used when computing vmaf.", OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, UINT_MAX, FLAGS}, > > > {"n_subsample", "Set interval for frame subsampling used when computing vmaf.", OFFSET(n_subsample), AV_OPT_TYPE_INT, {.i64=1}, 1, UINT_MAX, FLAGS}, > > > - {"enable_conf_interval", "Enables confidence interval.", OFFSET(enable_conf_interval), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > > > { NULL } > > > }; > > > > You are removing lots of options; removing options is only permissible > > during a major break and even then the options need to have been > > deprecated before that. > > Good point, thanks. New patch attached. No more missing options, > everything that should be deprecated has been marked as deprecated and > appropriate fallback behavior implemented. > > Thanks, > Kyle I think this patch should be ready to go. Any other comments let me know, otherwise I will plan on merging in ~48 hrs. Thanks, Kyle _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".