Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

From: Kyle Swanson <k@ylo.ph>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c
Date: Tue, 21 Nov 2023 10:53:10 -0800
Message-ID: <CALbjROJerAVHdLk25ck1a6emGS3RQnWF81+CP4ofgqKsYaVqLQ@mail.gmail.com> (raw)
In-Reply-To: <CAPYw7P4JMu6J6dWMo=fy4S95=46m_j1SO_aKMzTh1CzQj3E0Sw@mail.gmail.com>

Hi,

On Sun, Nov 19, 2023 at 3:48 AM Paul B Mahol <onemda@gmail.com> wrote:
>
> On Fri, Nov 17, 2023 at 7:38 AM Kyle Swanson <k@ylo.ph> wrote:
>
> > Hi,
> >
> > On Wed, Nov 15, 2023 at 12:39 PM Paul B Mahol <onemda@gmail.com> wrote:
> > >
> > > Attached.
> >
> > Only had a few minutes to look at this. Seems like more than just
> > merging two filters, I see a bunch of new filter options for example.
> > Can you explain?
> >
>
> The linear mode and scanning, both input to filter and filter output itself
> should give similar results.
> The dynamic mode now actually can be configured how aggressively it will
> expand / compress audio.
> Because current state of filter have numerous issues:
>
>  - using unmaintained old libebur128 module, when same functionality is
> already available in existing filter.
>  - code duplication and functionality duplication due the above
>  - buggy limiter - causing clipped samples randomly
>  - buggy first and final frame filtering
>  - over-complicated flow path for dynamic code in filter
>  - excessive compressing of audio dynamic range, causing extreme smaller
> LRU from output audio
>  - and probably more that I forgot
>
> Some options from this patch can be probably removed, like attack/release
> options, and just use defaults as currently in patch.
>
>
> > Thanks,
> > Kyle

OK. Give me some time to review this. Unfortunately, I can't be quick
since it is a Holiday week here and the diff is pretty hard to read.
I'm hoping this still gives exact/equivalent loudnorm output, since
this is a pretty widely used filter. My first reaction is combining
the filters like this might make things more complicated, but I will
keep an open mind while reviewing.

Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".