From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D58DA47F32 for ; Wed, 6 Dec 2023 17:55:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C41C368CF9B; Wed, 6 Dec 2023 19:55:05 +0200 (EET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D71A68CCBF for ; Wed, 6 Dec 2023 19:54:58 +0200 (EET) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40c09f4814eso797375e9.1 for ; Wed, 06 Dec 2023 09:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ylo-ph.20230601.gappssmtp.com; s=20230601; t=1701885297; x=1702490097; darn=ffmpeg.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I2Agwcocw8IYo7QA5RdigoMsf+tzBtioUS1mME5GZX0=; b=iYw6h33x5Dpm8eg3bX9CaYelZsj76WRNzhhC4lBe1FezTnkUFET35VuHRCbTJRKFPY NIBPD+t061ldkxRlSLXE4epxY5nDjsAJ4QfJpZBTjuxnSkR85mxx3uYQGlrftymX8SAJ /ISWUs6pJWFOYJ0+blXqvXUQOGNIGrXz57wP8iJEJR1/ZkVGFswF4yXx6IT0yQOEZk90 VbTMIja2HifjPQodkzeTYE0C6cjBNG+INIdTRUgkr7gcGXtONoex+5/Q6taOop5ZtolK TUjWNvTYtQnpumohFRbzU0QjZYs6Q7+1ll/jTESdIGorSr+rYq6GrrNCsgv+/JLLzEsn Lz0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701885297; x=1702490097; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I2Agwcocw8IYo7QA5RdigoMsf+tzBtioUS1mME5GZX0=; b=V4j5wyyqQ+PjPlp5ezJqpa3V5o2s7NrzCKsvIp7/Mu3koZFi9HWkGdAVG8PYgluNV6 qCYhRpdduNO9qujf1wA8XeHB86CH35yF1/AMf5RGY91PLUshThcuS4pc8X7yC3roxD90 rSwk2l9geTURwkFan0l5PO3jdd9D3I/ykDJBUOYxnAfD4xCO6QLZjt7g3gARD6ToYztk kcjjLvpgnA9tQJMZ2AMnZVhwL2typ7v6igHlLjZFtMn5SFlBb4UnX0FZZuDU5bROfrHN K8v4GJQUhPZhM/u0Yh9MFf7C3rlDgM7/QEZ+mQZNpKSYVLNl8P1imLPxaBhkKqmblMzt 7pAQ== X-Gm-Message-State: AOJu0YyJu+xKr3aB+HO/CTwSpboyDw+USRiRPFIXNJjbliPEJ0Xk2J+y 7dq70OtqQxKsDZy+ewh55mqKZmLzDpYZf7l/cqPdo7pX9MCBzb6i X-Google-Smtp-Source: AGHT+IH17L3UVGrzfC6VCHR1JMiLmSnE1hoqxyrXOXHzTDy/MyyRQEKhDPvL3JOh7Dh/8X82EK1CHS1DuQvvSpDY/vY= X-Received: by 2002:a05:600c:1c26:b0:40b:5e1d:839a with SMTP id j38-20020a05600c1c2600b0040b5e1d839amr950604wms.46.1701885297263; Wed, 06 Dec 2023 09:54:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kyle Swanson Date: Wed, 6 Dec 2023 09:54:46 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nil Fons Miret , Kyle Swanson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: SGksCgpPbiBNb24sIERlYyA0LCAyMDIzIGF0IDc6NTnigK9BTSBOaWwgRm9ucyBNaXJldCB2aWEg ZmZtcGVnLWRldmVsCjxmZm1wZWctZGV2ZWxAZmZtcGVnLm9yZz4gd3JvdGU6Cj4KPiBUaGUgbGli dm1hZiBmaWx0ZXIgd2FzIGRvaW5nIHN1YnN0cmluZyBjaGVja3MgaW4gcGxhY2Ugb2Ygc3RyaW5n Cj4gZXF1YWxpdHkgY29tcGFyaXNvbnMuIFRoaXMgbGVkIHRvIGEgYnVnIHdoZW4gdGhlIHVzZXIg c3BlY2lmaWVkIHRoZQo+IHBvb2xpbmcgbWV0aG9kICJoYXJtb25pY19tZWFuIiwgc2luY2UgIm1l YW4iIHdhcyBjaGVja2VkIGZpcnN0IGFuZCB0aGUKPiBzdWJzdHJpbmcgY29tcGFyaXNvbiByZXR1 cm5lZCB0cnVlLiBUaGlzIHBhdGNoIGNoYW5nZXMgYWxsIHN1YnN0cmluZwo+IGNvbXBhcmlzb25z IGZvciBzdHJpbmcgZXF1YWxpdHkgY29tcGFyaXNvbnMuIFRoaXMgaXMgYm90aCBjb3JyZWN0IGFu ZAo+IG1vcmUgZWZmaWNpZW50IHRoYW4gdGhlIGV4aXN0aW5nIG1ldGhvZC4KPgo+IFNpZ25lZC1v ZmYtYnk6IG5pbGZtIDxuaWxmQG5ldGZsaXguY29tPgo+IC0tLQo+IGxpYmF2ZmlsdGVyL3ZmX2xp YnZtYWYuYyB8IDMwICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+IDEgZmlsZSBjaGFu Z2VkLCAxNSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9s aWJhdmZpbHRlci92Zl9saWJ2bWFmLmMgYi9saWJhdmZpbHRlci92Zl9saWJ2bWFmLmMKPiBpbmRl eCAxMjgxMGI3MjY3Li40NmZmODE1NGVmIDEwMDY0NAo+IC0tLSBhL2xpYmF2ZmlsdGVyL3ZmX2xp YnZtYWYuYwo+ICsrKyBiL2xpYmF2ZmlsdGVyL3ZmX2xpYnZtYWYuYwo+IEBAIC0yNTEsNyArMjUx LDcgQEAgc3RhdGljIGludCBwYXJzZV9mZWF0dXJlcyhBVkZpbHRlckNvbnRleHQgKmN0eCkKPiAg ICAgICAgIGNvbnN0IEFWRGljdGlvbmFyeUVudHJ5ICplID0gTlVMTDsKPgo+ICAgICAgICAgd2hp bGUgKGUgPSBhdl9kaWN0X2l0ZXJhdGUoZGljdFtpXSwgZSkpIHsKPiAtICAgICAgICAgICAgaWYg KGF2X3N0cmlzdHIoZS0+a2V5LCAibmFtZSIpKSB7Cj4gKyAgICAgICAgICAgIGlmICghc3RyY21w KGUtPmtleSwgIm5hbWUiKSkgewo+ICAgICAgICAgICAgICAgICBmZWF0dXJlX25hbWUgPSBlLT52 YWx1ZTsKPiAgICAgICAgICAgICAgICAgY29udGludWU7Cj4gICAgICAgICAgICAgfQo+IEBAIC0z MTIsMjkgKzMxMiwyOSBAQCBzdGF0aWMgaW50IHBhcnNlX21vZGVscyhBVkZpbHRlckNvbnRleHQg KmN0eCkKPiAgICAgICAgIGNoYXIgICpwYXRoID0gTlVMTDsKPgo+ICAgICAgICAgd2hpbGUgKGUg PSBhdl9kaWN0X2l0ZXJhdGUoZGljdFtpXSwgZSkpIHsKPiAtICAgICAgICAgICAgaWYgKGF2X3N0 cmlzdHIoZS0+a2V5LCAiZGlzYWJsZV9jbGlwIikpIHsKPiAtICAgICAgICAgICAgICAgIG1vZGVs X2NmZy5mbGFncyB8PSBhdl9zdHJpc3RyKGUtPnZhbHVlLCAidHJ1ZSIpID8KPiArICAgICAgICAg ICAgaWYgKCFzdHJjbXAoZS0+a2V5LCAiZGlzYWJsZV9jbGlwIikpIHsKPiArICAgICAgICAgICAg ICAgIG1vZGVsX2NmZy5mbGFncyB8PSAhc3RyY21wKGUtPnZhbHVlLCAidHJ1ZSIpID8KPiAgICAg ICAgICAgICAgICAgICAgIFZNQUZfTU9ERUxfRkxBR19ESVNBQkxFX0NMSVAgOiAwOwo+ICAgICAg ICAgICAgICAgICBjb250aW51ZTsKPiAgICAgICAgICAgICB9Cj4KPiAtICAgICAgICAgICAgaWYg KGF2X3N0cmlzdHIoZS0+a2V5LCAiZW5hYmxlX3RyYW5zZm9ybSIpKSB7Cj4gLSAgICAgICAgICAg ICAgICBtb2RlbF9jZmcuZmxhZ3MgfD0gYXZfc3RyaXN0cihlLT52YWx1ZSwgInRydWUiKSA/Cj4g KyAgICAgICAgICAgIGlmICghc3RyY21wKGUtPmtleSwgImVuYWJsZV90cmFuc2Zvcm0iKSkgewo+ ICsgICAgICAgICAgICAgICAgbW9kZWxfY2ZnLmZsYWdzIHw9ICFzdHJjbXAoZS0+dmFsdWUsICJ0 cnVlIikgPwo+ICAgICAgICAgICAgICAgICAgICAgVk1BRl9NT0RFTF9GTEFHX0VOQUJMRV9UUkFO U0ZPUk0gOiAwOwo+ICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAgICAgICAgICAgICB9Cj4K PiAtICAgICAgICAgICAgaWYgKGF2X3N0cmlzdHIoZS0+a2V5LCAibmFtZSIpKSB7Cj4gKyAgICAg ICAgICAgIGlmICghc3RyY21wKGUtPmtleSwgIm5hbWUiKSkgewo+ICAgICAgICAgICAgICAgICBt b2RlbF9jZmcubmFtZSA9IGUtPnZhbHVlOwo+ICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAg ICAgICAgICAgICB9Cj4KPiAtICAgICAgICAgICAgaWYgKGF2X3N0cmlzdHIoZS0+a2V5LCAidmVy c2lvbiIpKSB7Cj4gKyAgICAgICAgICAgIGlmICghc3RyY21wKGUtPmtleSwgInZlcnNpb24iKSkg ewo+ICAgICAgICAgICAgICAgICB2ZXJzaW9uID0gZS0+dmFsdWU7Cj4gICAgICAgICAgICAgICAg IGNvbnRpbnVlOwo+ICAgICAgICAgICAgIH0KPgo+IC0gICAgICAgICAgICBpZiAoYXZfc3RyaXN0 cihlLT5rZXksICJwYXRoIikpIHsKPiArICAgICAgICAgICAgaWYgKCFzdHJjbXAoZS0+a2V5LCAi cGF0aCIpKSB7Cj4gICAgICAgICAgICAgICAgIHBhdGggPSBlLT52YWx1ZTsKPiAgICAgICAgICAg ICAgICAgY29udGludWU7Cj4gICAgICAgICAgICAgfQo+IEBAIC01MjksMTMgKzUyOSwxMyBAQCBz dGF0aWMgaW50IGFjdGl2YXRlKEFWRmlsdGVyQ29udGV4dCAqY3R4KQo+IHN0YXRpYyBlbnVtIFZt YWZPdXRwdXRGb3JtYXQgbG9nX2ZtdF9tYXAoY29uc3QgY2hhciAqbG9nX2ZtdCkKPiB7Cj4gICAg IGlmIChsb2dfZm10KSB7Cj4gLSAgICAgICAgaWYgKGF2X3N0cmlzdHIobG9nX2ZtdCwgInhtbCIp KQo+ICsgICAgICAgIGlmICghc3RyY21wKGxvZ19mbXQsICJ4bWwiKSkKPiAgICAgICAgICAgICBy ZXR1cm4gVk1BRl9PVVRQVVRfRk9STUFUX1hNTDsKPiAtICAgICAgICBpZiAoYXZfc3RyaXN0cihs b2dfZm10LCAianNvbiIpKQo+ICsgICAgICAgIGlmICghc3RyY21wKGxvZ19mbXQsICJqc29uIikp Cj4gICAgICAgICAgICAgcmV0dXJuIFZNQUZfT1VUUFVUX0ZPUk1BVF9KU09OOwo+IC0gICAgICAg IGlmIChhdl9zdHJpc3RyKGxvZ19mbXQsICJjc3YiKSkKPiArICAgICAgICBpZiAoIXN0cmNtcChs b2dfZm10LCAiY3N2IikpCj4gICAgICAgICAgICAgcmV0dXJuIFZNQUZfT1VUUFVUX0ZPUk1BVF9D U1Y7Cj4gLSAgICAgICAgaWYgKGF2X3N0cmlzdHIobG9nX2ZtdCwgInN1YiIpKQo+ICsgICAgICAg IGlmICghc3RyY21wKGxvZ19mbXQsICJzdWIiKSkKPiAgICAgICAgICAgICByZXR1cm4gVk1BRl9P VVRQVVRfRk9STUFUX1NVQjsKPiAgICAgfQo+Cj4gQEAgLTU0NSwxMSArNTQ1LDExIEBAIHN0YXRp YyBlbnVtIFZtYWZPdXRwdXRGb3JtYXQgbG9nX2ZtdF9tYXAoY29uc3QKPiBjaGFyICpsb2dfZm10 KQo+IHN0YXRpYyBlbnVtIFZtYWZQb29saW5nTWV0aG9kIHBvb2xfbWV0aG9kX21hcChjb25zdCBj aGFyICpwb29sX21ldGhvZCkKPiB7Cj4gICAgIGlmIChwb29sX21ldGhvZCkgewo+IC0gICAgICAg IGlmIChhdl9zdHJpc3RyKHBvb2xfbWV0aG9kLCAibWluIikpCj4gKyAgICAgICAgaWYgKCFzdHJj bXAocG9vbF9tZXRob2QsICJtaW4iKSkKPiAgICAgICAgICAgICByZXR1cm4gVk1BRl9QT09MX01F VEhPRF9NSU47Cj4gLSAgICAgICAgaWYgKGF2X3N0cmlzdHIocG9vbF9tZXRob2QsICJtZWFuIikp Cj4gKyAgICAgICAgaWYgKCFzdHJjbXAocG9vbF9tZXRob2QsICJtZWFuIikpCj4gICAgICAgICAg ICAgcmV0dXJuIFZNQUZfUE9PTF9NRVRIT0RfTUVBTjsKPiAtICAgICAgICBpZiAoYXZfc3RyaXN0 cihwb29sX21ldGhvZCwgImhhcm1vbmljX21lYW4iKSkKPiArICAgICAgICBpZiAoIXN0cmNtcChw b29sX21ldGhvZCwgImhhcm1vbmljX21lYW4iKSkKPiAgICAgICAgICAgICByZXR1cm4gVk1BRl9Q T09MX01FVEhPRF9IQVJNT05JQ19NRUFOOwo+ICAgICB9Cj4KPiAtLQo+IDIuMzcuMSAoQXBwbGUg R2l0LTEzNy4xKQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdAo+IGZmbXBlZy1kZXZlbEBmZm1wZWcub3Jn Cj4gaHR0cHM6Ly9mZm1wZWcub3JnL21haWxtYW4vbGlzdGluZm8vZmZtcGVnLWRldmVsCj4KPiBU byB1bnN1YnNjcmliZSwgdmlzaXQgbGluayBhYm92ZSwgb3IgZW1haWwKPiBmZm1wZWctZGV2ZWwt cmVxdWVzdEBmZm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgoKV2lsbCBwdXNo IHRoaXMgdG9tb3Jyb3cuCgpUaGFua3MsCkt5bGUKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdApmZm1wZWctZGV2 ZWxAZmZtcGVnLm9yZwpodHRwczovL2ZmbXBlZy5vcmcvbWFpbG1hbi9saXN0aW5mby9mZm1wZWct ZGV2ZWwKClRvIHVuc3Vic2NyaWJlLCB2aXNpdCBsaW5rIGFib3ZlLCBvciBlbWFpbApmZm1wZWct ZGV2ZWwtcmVxdWVzdEBmZm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgo=