Re: [FFmpeg-devel] [PATCH 3/3] lavfi/vf_libvmaf: add warning when color ranges differ

From: Kyle Swanson <k@ylo.ph>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Chema Gonzalez <chemag@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavfi/vf_libvmaf: add warning when color ranges differ
Date: Mon, 17 Apr 2023 12:09:22 -0700
Message-ID: <CALbjROJJ5WiFA+0VTMv9migX_rmuYCHS95n_rhZo21pGNRA3MQ@mail.gmail.com> (raw)
In-Reply-To: <20230401174737.85192-3-chemag@gmail.com>

Hi,

I think the warning is probably OK, but maybe better to put it into
config_input_ref along with the other input checks.

On Sat, Apr 1, 2023 at 10:48 AM Chema Gonzalez <chemag@gmail.com> wrote:

> ---
>  libavfilter/vf_libvmaf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c
> index 2586f37d99..67f0d6a22f 100644
> --- a/libavfilter/vf_libvmaf.c
> +++ b/libavfilter/vf_libvmaf.c
> @@ -141,6 +141,13 @@ static int do_vmaf(FFFrameSync *fs)
>      if (ctx->is_disabled || !ref)
>          return ff_filter_frame(ctx->outputs[0], dist);
>
> +    if (dist->color_range != ref->color_range) {
> +        av_log(ctx, AV_LOG_WARNING, "distorted and reference "
> +               "frames use different color ranges (%s != %s)\n",
> +               av_color_range_name(dist->color_range),
> +               av_color_range_name(ref->color_range));
> +    }
> +
>      err = copy_picture_data(ref, &pic_ref, s->bpc);
>      if (err) {
>          av_log(s, AV_LOG_ERROR, "problem during vmaf_picture_alloc.\n");
> --
> 2.39.2
>

Thanks,
Kyle
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".