From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 557C3403C8 for ; Sun, 23 Jan 2022 21:22:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4CD6568AFB3; Sun, 23 Jan 2022 23:22:43 +0200 (EET) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E29068AF2E for ; Sun, 23 Jan 2022 23:22:37 +0200 (EET) Received: by mail-qt1-f170.google.com with SMTP id z26so1524231qto.13 for ; Sun, 23 Jan 2022 13:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ylo-ph.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=WYno+mE5JrdIWC20dDR9eOJPsHU82LpYAHD9zcrW7nI=; b=0LScDT1tXLo6jB7PTbC7auXNpkeHX3n6xmI6Q8Df2FE6JzAivJ8soM03krYuS/lb7V BR8Hv04GAgQQ+xoaurTr9XVBSHfsyz5RCBJGSMMBmCRoMsmSuaw75cwTYXMTyQ4xFaAn ube3zE/Gln887vTOiRxB7qQK+80Pg3I7HiI7NwCW/6CnVe26xX0Eq7uvbgXIPCLRrCU+ Bqaxsoe18442a3ijoECTvlP8L1TeoggnO4j6M5DwoYDXTN8YAhF/QPLuqzsHg5caqMEa OdJK+FlbFNrKS3OBLt4bgcsB8wYyP0FpqM9p8VIY3xKy1StJOeQAD93ts3hLu1npqGTP WkZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=WYno+mE5JrdIWC20dDR9eOJPsHU82LpYAHD9zcrW7nI=; b=lKrnYBK4M5/pAnSSaSZzGOSWkBk5EyD+f5w73nHJJb4FWaf4mJw37uGjEoyH9ebs6w Nl5ga3mW7k8jV+zvOoTgxiSi1kWnYtlIuX4EvJ6ci7fWK6xs+srUC/82zZiOeYiSB6Cc Oly76oNonUYaCpqwrQb0KSAAKmEL0S4K4+A35fum18b1Q5MIbT49O05RpGEz6kGjj3Kt yqZVI0gKtdpjEh4Hpf105s5JYB0sQ1Sqdz5zYSfOcw0RD8z083FsDT1vejY4/Y1UQTyD FsVSbDTUeEMChPCcQWKIXkVp9H7rtH5yranGzgCdcT009myCr0XiE4vNvq8bX9YZhA1b zffw== X-Gm-Message-State: AOAM530Kyva/+QiGuaQs/3lO4Fh+3XxcBwmeOuZzQ8FPbZoJFP5E1xWj yjFdXELxQfcX5YpGKcpqw+2hlf0awdLwMC+4ao3FIygn3Vo= X-Google-Smtp-Source: ABdhPJzLMjEJtXE9tOENEt9BmjKd1CKBuraYUmrIQsCMjNI13fG/x0DjNrL961SjwXNcUUhbX185oBprf30gasQecQ4= X-Received: by 2002:ac8:5a89:: with SMTP id c9mr10562078qtc.520.1642972955049; Sun, 23 Jan 2022 13:22:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kyle Swanson Date: Sun, 23 Jan 2022 13:22:24 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Thu, Jan 20, 2022 at 1:06 PM Kyle Swanson wrote: > > Hi, > > On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson wrote: > > > > Hi, > > > > On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > > > > > Hi, > > > > > > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt > > > wrote: > > > > 1. FFmpeg uses the ancient C90 rule that only allows variable > > > > declarations at the beginning of a block (before all statements). You > > > > should actually have received a compiler warning because of the above > > > > code (unless you use Clang, which claims to support this type of > > > > warning, yet doesn't). > > > > 2. You jump over the initializion of str_copy if the dict allocation > > > > fails and consequently you free an uninitialized string. > > > > > > New patch attached. Fixes all of the GCC -Wdeclaration-after-statement > > > warnings. You're right, I didn't notice because I was building with > > > Clang. Andreas, I will just wait for your LGTM before merging. > > > > > > Thanks, > > > Kyle > > > > Updated patch attached. Thank you to mkver for the mini review on IRC. > > The `delimited_dict_parse` multi-delimiter corner case should be > > sorted now. > > > > Thanks, > > Kyle > > Will push this soon. > > Thanks, > Kyle Pushed. Thanks, Kyle _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".