Re: [FFmpeg-devel] 2nd ping

From: Bang He <hezhanbang@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] 2nd ping
Date: Mon, 25 Apr 2022 07:56:17 +0800
Message-ID: <CALZOGtRVwG321r9b-9Bi-55=NYmmv_or0YjiOs1wPHP1j06muw@mail.gmail.com> (raw)
In-Reply-To: <trinity-891770f4-9d10-403f-ae71-567a2521749c-1650549315908@3c-app-mailcom-bs05>

look good for me

On Thu, Apr 21, 2022 at 9:55 PM MCC CS <mcccs@gmx.com> wrote:

> It would be great if anyone who reads this could review this small patch
> (original:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295351.html):
>
> This is a repost of the patch by Chris Snowhill who originally sent this
> patch
> on 31 December - which didn't receive any replies. As you can see
> on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works
> perfectly.
>
> I have rebased it and recompiled it.
>
> Original commit description:
>
> Monterey needs mBytesPerFrame and mBytesPerPacket to be set, and I'm
> surprised this didn't break any previous system versions.
>
> Fixes bug #9564: Cannot decode xHE-AAC with audiotoolbox (aac_at) on
> Mac OS Monterey. Fixes likely bug that none of the AudioToolbox
> decoders work on Monterey.
> ---
> libavcodec/audiotoolboxdec.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
> index b8d0e868f7..daccf4abf8 100644
> --- a/libavcodec/audiotoolboxdec.c
> +++ b/libavcodec/audiotoolboxdec.c
> @@ -375,6 +375,11 @@ static av_cold int ffat_create_decoder(AVCodecContext
> *avctx,
>      avctx->ch_layout.order       = AV_CHANNEL_ORDER_UNSPEC;
>      avctx->ch_layout.nb_channels = out_format.mChannelsPerFrame =
> in_format.mChannelsPerFrame;
>
> +    out_format.mBytesPerFrame =
> +        out_format.mChannelsPerFrame * (out_format.mBitsPerChannel / 8);
> +    out_format.mBytesPerPacket =
> +        out_format.mBytesPerFrame * out_format.mFramesPerPacket;
> +
>      if (avctx->codec_id == AV_CODEC_ID_ADPCM_IMA_QT)
>          in_format.mFramesPerPacket = 64;
>
> --
> 2.35.1
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".