[FFmpeg-devel] Chromium 110 and ffmpeg 5.1.2

[FFmpeg-devel] Chromium 110 and ffmpeg 5.1.2

[Drew Abbott]

Hello,

I am trying to build Chromium 110 with ffmpeg version 5.1.2. One of
the errors I get while building has to do with the API for accessing
first_dts. It looks like previously it was just a member of AVStream,
but now it can only be accessed with av_stream_get_first_dts:
https://github.com/chromium/chromium/commit/b94755e4633045be96ab5e0bdde0db7e16a804bd
I can see now first_dts is a member of FFStream, but I don't know how
to go from an AVStream to an FFStream without using internals of
libavformat, if that is even possible. How was first_dts accessed in
5.1.2 from an AVStream?

Thanks,
Drew
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Chromium 110 and ffmpeg 5.1.2

[Timo Rothenpieler]

On 22.02.2023 21:41, Drew Abbott wrote:
> Hello,
> 
> I am trying to build Chromium 110 with ffmpeg version 5.1.2. One of
> the errors I get while building has to do with the API for accessing
> first_dts. It looks like previously it was just a member of AVStream,
> but now it can only be accessed with av_stream_get_first_dts:
> https://github.com/chromium/chromium/commit/b94755e4633045be96ab5e0bdde0db7e16a804bd
> I can see now first_dts is a member of FFStream, but I don't know how
> to go from an AVStream to an FFStream without using internals of
> libavformat, if that is even possible. How was first_dts accessed in
> 5.1.2 from an AVStream?

first_dts is a purely internal field of libavformat, you can't access it 
from outside of it.
av_stream_get_first_dts() is not a function I see anywhere in the ffmpeg 
codebase.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Chromium 110 and ffmpeg 5.1.2

[Hendrik Leppkes]

On Wed, Feb 22, 2023 at 9:42 PM Drew Abbott <abbotta4@gmail.com> wrote:
>
> Hello,
>
> I am trying to build Chromium 110 with ffmpeg version 5.1.2. One of
> the errors I get while building has to do with the API for accessing
> first_dts. It looks like previously it was just a member of AVStream,
> but now it can only be accessed with av_stream_get_first_dts:
> https://github.com/chromium/chromium/commit/b94755e4633045be96ab5e0bdde0db7e16a804bd
> I can see now first_dts is a member of FFStream, but I don't know how
> to go from an AVStream to an FFStream without using internals of
> libavformat, if that is even possible. How was first_dts accessed in
> 5.1.2 from an AVStream?

Chrome hacks their ffmpeg rather then fixing their code. You can't
build it with anything but their canned version.

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Chromium 110 and ffmpeg 5.1.2

[Neal Gompa]

On Wed, Feb 22, 2023 at 7:28 PM Hendrik Leppkes <h.leppkes@gmail.com> wrote:
>
> On Wed, Feb 22, 2023 at 9:42 PM Drew Abbott <abbotta4@gmail.com> wrote:
> >
> > Hello,
> >
> > I am trying to build Chromium 110 with ffmpeg version 5.1.2. One of
> > the errors I get while building has to do with the API for accessing
> > first_dts. It looks like previously it was just a member of AVStream,
> > but now it can only be accessed with av_stream_get_first_dts:
> > https://github.com/chromium/chromium/commit/b94755e4633045be96ab5e0bdde0db7e16a804bd
> > I can see now first_dts is a member of FFStream, but I don't know how
> > to go from an AVStream to an FFStream without using internals of
> > libavformat, if that is even possible. How was first_dts accessed in
> > 5.1.2 from an AVStream?
>
> Chrome hacks their ffmpeg rather then fixing their code. You can't
> build it with anything but their canned version.
>

There's an upstream bug for it:
https://bugs.chromium.org/p/chromium/issues/detail?id=1306560

There was an attempt by Andreas Schneider to fix this, but the fix
wasn't complete enough for their testsuite:
https://chromium-review.googlesource.com/c/chromium/src/+/3525614

The Chromium people don't seem to engage with upstream projects (in
particular ffmpeg) based on this lovely gem:
https://bugs.chromium.org/p/chromium/issues/detail?id=1306560#c8

In Fedora, we're carrying the patch, as it seems to work for us. I
hope the fix lands upstream someday.




--
真実はいつも一つ！/ Always, there's only one truth!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".