From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 54FD54116E for ; Mon, 3 Jan 2022 23:32:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7FA768B1FC; Tue, 4 Jan 2022 01:32:08 +0200 (EET) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 51AF168B1F4 for ; Tue, 4 Jan 2022 01:32:02 +0200 (EET) Received: by mail-lf1-f42.google.com with SMTP id h2so67349042lfv.9 for ; Mon, 03 Jan 2022 15:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q0DW7+QqOx8CRhgfT//eqYJI3RfGzt3L5Lin/aSppaY=; b=Kw0j0gTLdU0HV9k9g8XrfKMY9uTaId++MyS1s+bVW9GkT3faddYUsL8om/ojPzgoX6 W0T4dgJ1eFzpCkT2jD3aia1g6rUanrYxLuduKCd+9cNONOxZzUjqvUuxcTlXo3dnWBvW ltVciSsXoFapXiFAMBMWih9S38980mxH6sq2D07YTtfqXN4qdRo2HXvXPCzKSMA3TEdn oLUvXe1oh50GADFVO8y4e9feu3CKJdNhEnjCzUqftcJmb1uA1mBBZt1npyJSzOAzuvJn GkqZhf/TtSmFWQQUjDokkN2cv+t3piWuswt827neufyqkcAeG40HzYXYamUaCrqZlT9K YApg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q0DW7+QqOx8CRhgfT//eqYJI3RfGzt3L5Lin/aSppaY=; b=2nUxj5KIYYTmi3KWuudh2DP8U1xlO42VYgz4qpsMvtoPYVGBE5NwteO6IRETs1wpr4 mRF6PCwh0SbCvrdJQ50MURZhVOX302gB3IIwysAQQmQ8pvUl4kdAX0K7UjaiRpXz4Nw7 Up7uWQcI/zBpvZqNKOtn4cpOUGtb+0hE+8fATjJU1Ukp47CXRWuTIjuFiyKSIdnubCIr j1Z7lW2BYnoXqVsShvWdcrP3ZUAEn51YolcgDH+5R8zsl1kQVQZtdB8mO1hDv8RX4NPp mnGSgg9SO21kKGRw1tLmnmP6OpqOu5vVGVOgOLYjyGJ8xXn7hXioIZMssyDehG4LjLjR 79nA== X-Gm-Message-State: AOAM532g7/9ZUcnWdb8MC4u+WPzhEvh70tFRiemITijyVugR/5QejJ+F 2GMn61YpMwt6FJxkSboTVYNAIpkkClw4QoZTD+Oz/OsMJu3vJmcr X-Google-Smtp-Source: ABdhPJxxCn2hqvfZBMkLg/76/eUB+NYEe/7tdUTtuTRn6krqYtoKqIY88/rk5R7aa4REOcsdi+nnCF4fyO46xzAns9w= X-Received: by 2002:a19:6f08:: with SMTP id k8mr42628548lfc.16.1641252721437; Mon, 03 Jan 2022 15:32:01 -0800 (PST) MIME-Version: 1.0 References: <20220102094940.1765-1-dcnieho@gmail.com> In-Reply-To: <20220102094940.1765-1-dcnieho@gmail.com> From: Roger Pack Date: Mon, 3 Jan 2022 16:32:07 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 0/5] avdevice/dshow fixups X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Diederick Niehorster Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: These LGTM. Feel free to add yourself as a dshow maintainer if so interested, as well! :) On Sun, Jan 2, 2022 at 2:50 AM Diederick Niehorster wrote: > > These five patches fix two regressions (one crashing bug making dshow > unusable on x86, and one regression introduced by my recent patches due > to which devices that seem to not behave according to spec but worked > fine before my patches could no longer be used. > They furthermore fix three small issues i found looking through the dshow code: 2x needed cleanup not being done, and one where to skip setting format for a pin when its useless. > > new in v2 is fixing of the x86 crash > > Diederick Niehorster (5): > avdevice/dshow: tv_tuner_audio_dialog cleanup missing > avdevice/dshow: proper cleanup of queried media types > avdevice/dshow: fix crash on x86 > avdevice/dshow: only set pin format if wanted > avdevice/dshow: ensure pin's default format is set > > libavdevice/dshow.c | 93 +++++++++++++--------- > libavdevice/dshow_capture.h | 120 ++++++++++++++--------------- > libavdevice/dshow_crossbar.c | 4 + > libavdevice/dshow_enummediatypes.c | 8 +- > libavdevice/dshow_enumpins.c | 8 +- > libavdevice/dshow_filter.c | 24 +++--- > libavdevice/dshow_pin.c | 48 ++++++------ > 7 files changed, 165 insertions(+), 140 deletions(-) > > -- > 2.28.0.windows.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".