From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D5001426B5 for ; Tue, 22 Mar 2022 14:10:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3890368B072; Tue, 22 Mar 2022 16:10:43 +0200 (EET) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A67F468003D for ; Tue, 22 Mar 2022 16:10:36 +0200 (EET) Received: by mail-lf1-f51.google.com with SMTP id m3so18032070lfj.11 for ; Tue, 22 Mar 2022 07:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZeAy6QD9bRbmfYlizNijQbsaItLJCdgF3gW2pTQBn6Q=; b=STdUBemOnmiNBWI48zdobReVvbBhJg8XS3LJ2MgxJNHr0Uz2XuMDgjNyGF0hYoycKW O/UcNEOov8jgZ67p9f0RaUrd5sQw3M6tgIG4kaUUrRV7zM9FAhbVKvDSzzLO4q7MBXY3 usKT7tJHNK09bOiYSlvpnY1p4IOPJUhktIEksn4ZNnq7Dvz6/F1wsnaGqRWcIXPq6f44 tUFfSdp/MBEuTKnENLA/Dd3/qQx/+HzAgFOfq5D73pwIm5R/itG0khjtgLodaFF7prrl M9gVMZeq6ZojSw1o9E7TtT5z8nWErp27FhMM9Q81HiRJrBUW1LPmoMcFaf1qjKeYEmhO 2LTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZeAy6QD9bRbmfYlizNijQbsaItLJCdgF3gW2pTQBn6Q=; b=dr5X8Bz6zNxwp68x22C+CoG0cXllv7SPD2FK7UBmQJDM+GPrZucW5Ja9C+yxbsFW5m CIpcb4RQmniGqlbfHH1WPCGE7tgmi5Zlc4mNLgfp6OnvhKtavkcyO2NvBO5I2qvhJkdW Yp50wtrDIZfRGl3N46pBbHl01A0nKVwFQfKAlqjclyx1ekyPCbSFFb8Yl/60z6IUzC1e HTzPiF5s43BFmXcksCJt1iZ1TuYZGnJYd2+gHkwYRVJvWltxpb0tkPkYfn+DlPtzqgpo 99Qzb3fhp3i76nK/Pg+bYT+iq59mwFId2MZ9TwPblHH1u90cAktB/dsSCaejRt1HHIHH cnfQ== X-Gm-Message-State: AOAM530Pbk2RoP3QlaR1CU7Mtuu6vy/2xukkxi+SeSaKySnvVbb8C951 mGfl9ks4Dml3Itf7zWEUNA796Sodm1BoPxUpCzBylBqY X-Google-Smtp-Source: ABdhPJzU6/qQWxuIqxExAlQ5j/E/gJL2asYbt18BAMh+0I7uq3pdiDioF/JpzugD9yyuiClpIbXYHcGskqaa3ow5Qy0= X-Received: by 2002:a05:6512:3152:b0:448:2622:e77f with SMTP id s18-20020a056512315200b004482622e77fmr17991072lfi.407.1647958234871; Tue, 22 Mar 2022 07:10:34 -0700 (PDT) MIME-Version: 1.0 References: <20220322133957.81743-1-toots@rastageeks.org> <20220322133957.81743-2-toots@rastageeks.org> In-Reply-To: <20220322133957.81743-2-toots@rastageeks.org> From: Roger Pack Date: Tue, 22 Mar 2022 08:10:22 -0600 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/6] Fix dshow device name/description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Romain Beauxis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Mar 22, 2022 at 7:40 AM wrote: > > From: Romain Beauxis > > diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c > index 6039578ff9..4ee3f6e194 100644 > --- a/libavdevice/dshow.c > +++ b/libavdevice/dshow.c > @@ -552,8 +552,8 @@ dshow_cycle_devices(AVFormatContext *avctx, ICreateDevEnum *devenum, > if (!device) > goto fail; > > - device->device_name = av_strdup(friendly_name); > - device->device_description = av_strdup(unique_name); > + device->device_name = av_strdup(unique_name); > + device->device_description = av_strdup(friendly_name); > if (!device->device_name || !device->device_description) > goto fail; > LGTM. The device enumeration API was added only recently to dshow, guess a bug crept in. Thanks! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".