From: Roger Pack <rogerdpack2@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Romain Beauxis <romain.beauxis@nextstep.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] Fix dshow device name/description
Date: Tue, 22 Mar 2022 08:10:22 -0600
Message-ID: <CAL1QdWdRAzsAx_im8Be-zmcRp65NvgTPbB11aYf_pUkWTX+Wzg@mail.gmail.com> (raw)
In-Reply-To: <20220322133957.81743-2-toots@rastageeks.org>
On Tue, Mar 22, 2022 at 7:40 AM <toots@rastageeks.org> wrote:
>
> From: Romain Beauxis <romain.beauxis@nextstep.com>
>
> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
> index 6039578ff9..4ee3f6e194 100644
> --- a/libavdevice/dshow.c
> +++ b/libavdevice/dshow.c
> @@ -552,8 +552,8 @@ dshow_cycle_devices(AVFormatContext *avctx, ICreateDevEnum *devenum,
> if (!device)
> goto fail;
>
> - device->device_name = av_strdup(friendly_name);
> - device->device_description = av_strdup(unique_name);
> + device->device_name = av_strdup(unique_name);
> + device->device_description = av_strdup(friendly_name);
> if (!device->device_name || !device->device_description)
> goto fail;
>
LGTM.
The device enumeration API was added only recently to dshow, guess a
bug crept in.
Thanks!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-22 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 13:39 [FFmpeg-devel] [PATCH 0/6] Various libavdevice cleanup & enhancements toots
2022-03-22 13:39 ` [FFmpeg-devel] [PATCH 1/6] Fix dshow device name/description toots
2022-03-22 14:10 ` Roger Pack [this message]
2022-03-22 19:07 ` Diederick C. Niehorster
2022-04-09 19:39 ` Marton Balint
2022-03-22 13:39 ` [FFmpeg-devel] [PATCH 2/6] Use appropriate method for device discovery, fix crash with bogus device index toots
2022-03-22 13:39 ` [FFmpeg-devel] [PATCH 3/6] libavdevice/avfoundation.m: Allow to select devices by unique ID toots
2022-03-22 13:39 ` [FFmpeg-devel] [PATCH 4/6] libavdevice/avfoundation.m: use setAudioSettings, extend supported formats toots
2022-03-22 13:39 ` [FFmpeg-devel] [PATCH 5/6] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length toots
2022-03-22 13:39 ` [FFmpeg-devel] [PATCH 6/6] Add AudioToolbox audio input device toots
2022-03-22 14:12 ` [FFmpeg-devel] [PATCH 0/6] Various libavdevice cleanup & enhancements Roger Pack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1QdWdRAzsAx_im8Be-zmcRp65NvgTPbB11aYf_pUkWTX+Wzg@mail.gmail.com \
--to=rogerdpack2@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=romain.beauxis@nextstep.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git