From: Roger Pack <rogerdpack2@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avdevice/dshow: silence warnings about unused variable
Date: Tue, 19 Apr 2022 00:05:15 -0600
Message-ID: <CAL1QdWdFfeumxy+e-MwWQFaTu7ZN2BatYUv3nwb9P7+TP_dDjw@mail.gmail.com> (raw)
In-Reply-To: <20220413161515.6999-2-jamrial@gmail.com>
On Wed, Apr 13, 2022 at 10:15 AM James Almer <jamrial@gmail.com> wrote:
>
> Use av_unused instead of wrapping the declaration under the DSHOWDEBUG check
> in case future changes make use of it.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavdevice/dshow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
> index ac8b64366f..6277a27453 100644
> --- a/libavdevice/dshow.c
> +++ b/libavdevice/dshow.c
> @@ -976,7 +976,7 @@ dshow_cycle_formats(AVFormatContext *avctx, enum dshowDeviceType devtype,
> }
> } else {
> WAVEFORMATEX *fx;
> - AUDIO_STREAM_CONFIG_CAPS *acaps = caps;
> + AUDIO_STREAM_CONFIG_CAPS av_unused *acaps = caps;
> #if DSHOWDEBUG
> ff_print_AUDIO_STREAM_CONFIG_CAPS(acaps);
> #endif
Or maybe put it within the #if ? Just an idea.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-19 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 16:15 [FFmpeg-devel] [PATCH 1/2] avdevice/dshow: remove unused variables James Almer
2022-04-13 16:15 ` [FFmpeg-devel] [PATCH 2/2] avdevice/dshow: silence warnings about unused variable James Almer
2022-04-19 6:05 ` Roger Pack [this message]
2022-04-19 11:19 ` James Almer
2022-04-19 6:10 ` [FFmpeg-devel] [PATCH 1/2] avdevice/dshow: remove unused variables Roger Pack
2022-04-19 7:09 ` Diederick C. Niehorster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1QdWdFfeumxy+e-MwWQFaTu7ZN2BatYUv3nwb9P7+TP_dDjw@mail.gmail.com \
--to=rogerdpack2@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git