From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D22284365A for ; Sat, 20 Aug 2022 09:52:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D06A68B97C; Sat, 20 Aug 2022 12:52:56 +0300 (EEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F4A368A467 for ; Sat, 20 Aug 2022 12:52:49 +0300 (EEST) Received: by mail-lj1-f177.google.com with SMTP id e2so1614125ljj.1 for ; Sat, 20 Aug 2022 02:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=GxX1wLBVYW/Y5RBemVA5i6AXNhbrYDLE03xl3k2Gnx4=; b=OvLK8APZCx5yuXOwcc/dogpQeIKgVWZfzejcomP5zzuuFeG7Jz5nVxpbq8qQYJsmJR kWSdJzTgSogcStv4P1NJb5sTIkOzO/4xOH8GdA+pK+YIFLJu0MRkWy+tCgzbAiwHV/WF SLq4NN1qw9D7+XfbcjZxngpoRlHlvcP+xUDu3xJsQI2b7UpGkz6/9gbfRDE+hN3DLdoH PpJQvQLT3WstAcHJ7Vy1JM1kxOauQuP/jQ9N7FHs2I7n8umhGUxQPVjYIBccY2s3GYIz UfG29QgyZdtzSw/47/7ea1YwbYHrGT6YZWDoeeKFNKb2lBdgteor4rVY/jmZKOVY2uCL MZcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=GxX1wLBVYW/Y5RBemVA5i6AXNhbrYDLE03xl3k2Gnx4=; b=CkEvcxMxqdhnbM8ThfMg1yMz23DJ2BZIrQTnanBQws3l7JlwFiXyaU7FXglY2S6MKm w7iuurnCM+OJnZYrr1gfX0BHPSzrx7bVqZuoQG3IY7NCCeJp2XkbvoVAznqcTrFqiboh acQmZqyp/9B7X6XHcqxIul8gXqhxH8333evqndugeeVypnLYyGN+VAiiDLrfbzUVKKO2 POF06mYH95ajj54z5tKsTRrkhJDgXIP/xJxwt5JSJeLNqk7jDbLtnmG/yVN+hqifH9Nn yqWJdqVvyOABk3jwgzJ6Vr1R2gbuBGA9jFF3dAXGskQhdAYKm2Oq1BJxCYeW/oYmeFuZ s/4g== X-Gm-Message-State: ACgBeo1Dl4oGmWk/vJQVi8kwFnzv15CIzcpASjjo4BPLQurYtLp6qCaM c5rQboWow331QadT4eJ04kA+GtQIiZNebD0JM97Ak37OkptpH+Q5 X-Google-Smtp-Source: AA6agR7Avvzw7/J/ahMQS9+TitRDAgVEwZ1/4ZBT5489s22pyffu/jFw8muiZJlmX3j9yOQp57nr4KmDxHuTum6DAzw= X-Received: by 2002:a05:651c:179a:b0:247:d37b:6ec5 with SMTP id bn26-20020a05651c179a00b00247d37b6ec5mr3430574ljb.112.1660989167457; Sat, 20 Aug 2022 02:52:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jack Waller Date: Sat, 20 Aug 2022 17:52:35 +0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Please check the code:line 209 if (c == 0 || fabs(buf[index + c]) > max_peak) max_peak = fabs(buf[index + c]); 'max_peak' is initialized. On Sat, Aug 20, 2022 at 5:39 PM jagad hariseno wrote: > Hi All, > > at af_loudnorm.c in line number 188: > double this, next, max_peak; > > max_peak is not initialized with 0. and could be contains any value or > noise. > I could be wrong but I think init with 0. should be better: > > double this, next, max_peak=0.; > > Best Regards > > jagad. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".