[FFmpeg-devel] Possibly a little bug in af_loudnorm.c

[FFmpeg-devel] Possibly a little bug in af_loudnorm.c

[jagad hariseno]

Hi All,

at af_loudnorm.c in line number 188:
double this, next, max_peak;

max_peak is not initialized with 0. and could be contains any value or
noise.
I could be wrong but I think init with 0. should be better:

double this, next, max_peak=0.;

Best Regards

jagad.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c

[Jack Waller]

Please check the code:line 209

                    if (c == 0 || fabs(buf[index + c]) > max_peak)
                        max_peak = fabs(buf[index + c]);

'max_peak' is initialized.


On Sat, Aug 20, 2022 at 5:39 PM jagad hariseno <jagadhariseno@gmail.com>
wrote:

> Hi All,
>
> at af_loudnorm.c in line number 188:
> double this, next, max_peak;
>
> max_peak is not initialized with 0. and could be contains any value or
> noise.
> I could be wrong but I think init with 0. should be better:
>
> double this, next, max_peak=0.;
>
> Best Regards
>
> jagad.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c

[jagad hariseno]

yes you're right.
Thanks for your fast response

Best Regards

jagad

On Sat, Aug 20, 2022 at 4:53 PM Jack Waller <ffmpeg@gmail.com> wrote:

> Please check the code:line 209
>
>                     if (c == 0 || fabs(buf[index + c]) > max_peak)
>                         max_peak = fabs(buf[index + c]);
>
> 'max_peak' is initialized.
>
>
> On Sat, Aug 20, 2022 at 5:39 PM jagad hariseno <jagadhariseno@gmail.com>
> wrote:
>
> > Hi All,
> >
> > at af_loudnorm.c in line number 188:
> > double this, next, max_peak;
> >
> > max_peak is not initialized with 0. and could be contains any value or
> > noise.
> > I could be wrong but I think init with 0. should be better:
> >
> > double this, next, max_peak=0.;
> >
> > Best Regards
> >
> > jagad.
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".