From: Jack Waller <ffmpeg@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c
Date: Sat, 20 Aug 2022 17:52:35 +0800
Message-ID: <CAKqR_u5CfqTfoBsQkACmtQNB52uXAKLsOnMc2zf=sswnhxEAuw@mail.gmail.com> (raw)
In-Reply-To: <CAAaac4Vb2VuiN_StzLCT=2cQLZpjhQvnHEGhKeFL=LvBTXgXaw@mail.gmail.com>
Please check the code:line 209
if (c == 0 || fabs(buf[index + c]) > max_peak)
max_peak = fabs(buf[index + c]);
'max_peak' is initialized.
On Sat, Aug 20, 2022 at 5:39 PM jagad hariseno <jagadhariseno@gmail.com>
wrote:
> Hi All,
>
> at af_loudnorm.c in line number 188:
> double this, next, max_peak;
>
> max_peak is not initialized with 0. and could be contains any value or
> noise.
> I could be wrong but I think init with 0. should be better:
>
> double this, next, max_peak=0.;
>
> Best Regards
>
> jagad.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-20 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 9:39 jagad hariseno
2022-08-20 9:52 ` Jack Waller [this message]
2022-08-20 9:57 ` jagad hariseno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKqR_u5CfqTfoBsQkACmtQNB52uXAKLsOnMc2zf=sswnhxEAuw@mail.gmail.com' \
--to=ffmpeg@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git