From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2E0142192 for ; Thu, 28 Apr 2022 14:13:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2C7D68B41D; Thu, 28 Apr 2022 17:13:51 +0300 (EEST) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC0D368B367 for ; Thu, 28 Apr 2022 17:13:45 +0300 (EEST) Received: by mail-lj1-f169.google.com with SMTP id q185so6885068ljb.5 for ; Thu, 28 Apr 2022 07:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Y/vsHgzhyJPnXW0iA4eTKBFg46BY25ML94tbcZW/mmk=; b=kFBcZufkJDTh651c3UbTU/rl7ob02N71mS5k166ZPuO031t8xnk38NzouJ0AHGyxVo tTxhVUlcmIvVzXXvGnui5ZcSXXQUkNAV/hcbWTbJjbOitImnqPDWdFW9UHMIybIxz7tT FoRLg6TMNKY3CCOfDyiETRo2KNLidZI4sPrtkFhkWgbz3vaMm3GD80BnUU/knXlfIUZV So4jz1r1hFzrbEcGCFAXFUt/jRvCF0B7FWN6stQa0yKfHcdY2pdfJXtkasvHvkZZO1l7 ZdeH/fmJzR+zZkigcXh5Zxjtp5QThpRwNzpalSXAei9+3IfgrfiztwHTIqpQsoGWmN04 5NwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Y/vsHgzhyJPnXW0iA4eTKBFg46BY25ML94tbcZW/mmk=; b=N4p7COetvWmAKhbFFyrHen9tVW9OeOhmAU5Ye0bnfbS07zqpPUbkutvRki0Aal7Yit uP4msf3ln31LZlhqO8r9SzQvMRJpep8N1ON3Q7VvKOp1zkvEeKZ+PbFbv8pcfks3Ir68 j2T7gthUwd4odcW+2qWa+JsDm4JxiygBYQBshUhPvZ/P5WtfvR6RXuxfqPiGcm8Z9Kjl t2uovv1+4Qxoiq9M0d48hLcAPBSk4FNwMm0xs8uivsoHMJuOhPhZ8OQa/yhEfHMBMqla FdkwYjA8nzxDna+rtNUis5FyAO06IcL+3IqN0vx6X1+A2p31U61nfZhvEwi6HQsNvY/K zMQg== X-Gm-Message-State: AOAM531AbApch4t0C9DzxQhnC4kiAzg3D0fgIAvsZcdyl01ykhQFnN4r N9S1K1xwDKoZp+HPc0lmBlal57pae/zY8OM2YtAU3f1smy0= X-Google-Smtp-Source: ABdhPJxarxhDn5s+dqEw0CL2p/6TZTJAVG1OzuOWa6S3WKS3aO01fUSN9E1KqE+DmCFojIcH+i0+a4P23575CyqSNaU= X-Received: by 2002:a2e:3c17:0:b0:24d:a54b:7f5 with SMTP id j23-20020a2e3c17000000b0024da54b07f5mr21287940lja.396.1651155225192; Thu, 28 Apr 2022 07:13:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andreas Unterweger Date: Thu, 28 Apr 2022 16:13:35 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 28 Apr 2022 at 05:23, Andreas Rheinhardt wrote: > > Andreas Unterweger: > > Previously, the default timebase caused two warnings during decoding > > about not being able to update timestamps for skipped and discarded > > samples, respectively. > > > > Signed-off-by: Andreas Unterweger > > --- > > doc/examples/transcode_aac.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c > > index c9b93f6439..6197369756 100644 > > --- a/doc/examples/transcode_aac.c > > +++ b/doc/examples/transcode_aac.c > > @@ -1,5 +1,5 @@ > > /* > > - * Copyright (c) 2013-2018 Andreas Unterweger > > + * Copyright (c) 2013-2022 Andreas Unterweger > > * > > * This file is part of FFmpeg. > > * > > @@ -120,6 +120,10 @@ static int open_input_file(const char *filename, > > avformat_close_input(input_format_context); > > return error; > > } > > + > > + /* Set the packet timebase for the decoder. The input file's sample > > + * rate is used as the denominator for simplicity. */ > > + avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate }; > > > > /* Save the decoder context for easier access later. */ > > *input_codec_context = avctx; > > The timebase of the packets sent to the decoder is given by > AVStream.time_base; this need not be the natural time base (i.e. the > inverse of the sample rate). > > - Andreas I changed the code in versions 5 and 6 to use the stream time base. However, the new patches, again, seem to cause issues in Patchwork. I don't know what is the issue exactly. I double-checked for broken lines before sending the e-mails. I prepared version 5 and 6 exactly as version 4, which is fine (green) on Patchwork. Is the patch o.k. now in terms of its content, and, if so, how can I send it in such a way that Patchwork is happy? Best, Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".