From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D26EE44365 for ; Mon, 10 Oct 2022 08:03:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B9F9468BC93; Mon, 10 Oct 2022 11:03:21 +0300 (EEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2059.outbound.protection.outlook.com [40.107.244.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C4E668BC64 for ; Mon, 10 Oct 2022 11:03:14 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FOv+QVLMh3v+TiKPLDow0N/h4F3Kq06OsGGI3VEgyDYvbwZ3oR94NSBSiezRGHSoFpLn+YuzpmTXy/PvPHpHKI4lGWF4ss8ivTn7kX4qIvpnR80aeMRXSOy0MX7xtwJB7m2PJ/LO/FuK68wMOtps457wa/JWLOkh5dOZVeRlH6Xb+TgbldF7pj5nQEodspkUGBfrA7LPblyJuClkokHolgIQmX65vu3p5fmdQTffy5egVtXlJyQlrNp/DVd1IlCH2v+slA9/OU8JLGfS/ETYcs0FUbtSibrkfdOqgjidwXozynX9DV+P6c3iYvnHfM6j82stS4poLrll1qPd72Mypg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6jyCA4LMRscD0LPGDtZj0oBgUQJVOC3F3RqZytGy2Ec=; b=XwejPfkGx/DC8UsF68/SYFws+sj96RDpEmapNfjuKxKXPA6WtrbEX1dXxQsWNykswweMcXKCRo0iUWeyh9JDRJEmg8IlwMLXZ48OpqJzGi28jHkCxTis64Eh0mMIOJVI86cOTrWXRHl4YH4t2+hnVfU0+2rRjmRrzN7J2bxV4zfSDCm8A1A9yJIZVwDYYKZXQv/lPhrlmMQLemoY4B0kpMbrPHto6cXcYk+0rCkE7gVjJbrtrvpbWUWR2SA7U7870LEr0yeMAIV6vKI1du2+h/QHqmbCUBmHOYVPeq9B4uHNLV1kecMzS5zu19GfqZ9FWI6FrzEyEImvVD6m+MH5Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=rocha.red; dmarc=pass action=none header.from=rocha.red; dkim=pass header.d=rocha.red; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rocha.red; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jyCA4LMRscD0LPGDtZj0oBgUQJVOC3F3RqZytGy2Ec=; b=mHfFzTcdv2OJUvqP2RhPK/R0aRxI6+wB0HO5N4qiKwPm1H9WkdSE05C8aiTlNpCW0cjW7XD7lztxZmdK8r901dR142BYYbl0gCPuRJ6FlxPOSvYSrjG6yg+BnZYR000nWKDvgQa2xXJTXOCHxKvw2uXMHOQB+xsplAk1ibXB1jLHfh/L05Y09ZZWr0qzRcYUojI9dojmju9vQTvMo8Gr7/ACnrh5dAWiIje79IIzEzvXNso+2Qi81m/+VT0ETe3DLGaColY32a5uCN5NSbPPta8sqKb0d7r2LlsMJSjxV4isPQtNX4zMkZiD2/ABAsG9TUL4lq3RIfXYrHWkdppFmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=rocha.red; Received: from MN2PR04MB6767.namprd04.prod.outlook.com (2603:10b6:208:1e7::23) by SN6PR04MB5119.namprd04.prod.outlook.com (2603:10b6:805:9f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct 2022 08:03:10 +0000 Received: from MN2PR04MB6767.namprd04.prod.outlook.com ([fe80::2fb6:5df7:3c10:fa53]) by MN2PR04MB6767.namprd04.prod.outlook.com ([fe80::2fb6:5df7:3c10:fa53%7]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 08:03:10 +0000 X-Gm-Message-State: ACrzQf1RlYaaiOlNdLrqFYbdnQEAStCC67jFU33O7WjpuxbxwQO/IHXm Ycd4QbdJXzcL+qPs6U+tEf3q5d1uh4Rnp+BZYg== X-Google-Smtp-Source: AMsMyM6IBF3Y8PNW37iZziJtTp4j8pZ08058i4WZ5PvoUA1Jo9QhgsbgYxsKNEFzQTdeNqTf1z1eVwiwl+pQHI9zvKE= X-Received: by 2002:a2e:834b:0:b0:26d:ffb1:dae7 with SMTP id l11-20020a2e834b000000b0026dffb1dae7mr6377307ljh.128.1665388984115; Mon, 10 Oct 2022 01:03:04 -0700 (PDT) References: <20221002234755.3354-1-dev@rocha.red> <20221002234755.3354-2-dev@rocha.red> In-Reply-To: From: "Julio C. Rocha" Date: Mon, 10 Oct 2022 01:02:52 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-ClientProxiedBy: GV3P280CA0038.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:9::16) To MN2PR04MB6767.namprd04.prod.outlook.com (2603:10b6:208:1e7::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR04MB6767:EE_|SN6PR04MB5119:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b8882fb-127a-4585-3deb-08daaa95defa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: taL2SH7kd+LxSvvQLDSG/sFQW1wbg3II7JrUTC/cI+XpbsMSTG8i2B+AyG/1LtRaYyv5Q+NjA5xkHRbUjLquDyt1qY8sbjin6R1LhQBi7AuHhssK6HNZgC6ikr8RXOsyzgWXuPw45C+sZ0IekQ9svQccycA5RnjCGvCpW/626uSStmJ0AEMbVeUIzB6bvoOLbJiLhrEFdZ+19ibMM856KoMyQwlCHCAfcZ1HVxD7WlQngrUcITlCX+lCzVL+vGoAAfgxp1SKQ3fg1YxXZB+XNtRJPsqpj993io/ra2wHtgio5LU7PFvwzJ4XJuXS9HurRs/zMOPVYgda/Ad2fxH3W1Fc36a9Id8mjzOoHbDRCVwY86mVlBDU9mXcjVTQs5NJ+zpIfDS3l/V4nJvXRHf8XyiUPsSJyB3Fdi72+wg4MKTQPdLRoucpVI3nplVIQBItxsKwqb1j7yMkZz6ikM0Op2pNPVt9AnMunIbI599jD64NHdrhMkkzVnJyvs2HquhutLXArhOmsN2S8wNdvwg5D0NOQ5WomHzVX0Q/GHw8l6ED009O7nmv0kPunE1LoStNZ96wJsjpyKeCp0lw2C3DtgVVCtQ7TzJ2bZ0n21J+p+CuF/kzbqQJSOoqT4/t+XWm6tn6EL5LFzVRz53vsg8qIpTfRLlJo3k3mQGjSZo/tsiTQLr0gVQsBCPzQ0MtnZQtF8G6qqXzTxRRIT2xkJ5yr72fNuwiOZfm8Vr9gdXH0I+zy+Jo5Stb9nfzXmZ570T+dkiJH2hR6TusCcC7G+TZXw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6767.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(376002)(39830400003)(396003)(366004)(451199015)(316002)(66946007)(55446002)(66476007)(6916009)(45080400002)(66556008)(2906002)(8936002)(41300700001)(5660300002)(55236004)(186003)(83380400001)(38100700002)(6666004)(38350700002)(52116002)(478600001)(6506007)(6486002)(26005)(6512007)(53546011)(33964004)(9686003)(8676002)(460985005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTBONEtDMkZ5aHdoUXdwOXNaRlFuOVBNRVI2ODQ3SWZCVFExOTl1U1RxV3d0?= =?utf-8?B?RnFFSWpkNGVNMk4yWVo5WHNzMkxnZEg3VmgrcGtwYmZOYzBlbW9QRGVsdGoz?= =?utf-8?B?bTRiZVMrMm5FbVhsWG0rYmVHOUdCVmNQM3RQNTI3U0NUdWYxNkhvZjBrTzVq?= =?utf-8?B?YVdqOE13S04yUHc2WWs1dFBJdWlzOHF2UWV0WWwweTNabGZvYzQvT2FHTGdP?= =?utf-8?B?MWRSK2ZYbitNaUkyQzBoYnd3SHBkQkRPRXJEZEZsODRKdFF6RkF0TE1vWUMy?= =?utf-8?B?MTFkNzRQQ3BDbjkzb2t6NVNaVWVDTWZwbzBmRnFiem51eldlTGlFZHUyV3RJ?= =?utf-8?B?aXU4RGpWRWIzUmNYZzVmNHdWcy9BTEcrMGxqUGNoSWlsOVNZcTRrT2ZuR2t3?= =?utf-8?B?NDlMVU5SL2xYcDl2eEZTanlSS21pOWI0TjlrUTNVcFNzM0FMZ3RlTGgvS21t?= =?utf-8?B?RGM3aVVkM0w2aWxVQmdXZHRTRzJPYzlmOGtlbDdJUkhYTEdLM1c0NlpYM3JK?= =?utf-8?B?U0xXYWQ0U2YxSUR0bmljMlJHZFB2K3Z1NWJwb0RDd0h4emtBWHRxaWVPd2xy?= =?utf-8?B?L3Y1Zm5Jb1dLSThneGh2M2pTS3RCVk94TTV0TXZxb0NjbmtONDRmb1VhcERn?= =?utf-8?B?ekdGdGQyU3hkZWxLU3Q1ZXBMMkVtM0Rxd24wQUpSNHB6Vi9ZdmxoS1JZNzBG?= =?utf-8?B?Z1gwRnNBYzQxTEFYK2VXcXdqbnByM0RtTTREWEgwTU1WZForamsyQThvazZZ?= =?utf-8?B?T0FUMDBiRHlzRDZIQ1BaOFhrYjVnOVZwNWphMFQ2NkFFckIxbnk5WStzRzR0?= =?utf-8?B?RWttM0hzZm9OZVpTODlqeWlJZW1hWUFnSUd0V0FDc0pXbkhGTmpnQ2p5eXoz?= =?utf-8?B?VHdId0t6bFdEdzAzdldMN3dxeVlvOFMrT3dZUkxuM2JwUThWbUNmY1JtRnh2?= =?utf-8?B?TzhqMmJDaTFTMEJad3NHQkl0ZWNSOTAzR21wSVg0b05XL1drK1VRS2xNblJj?= =?utf-8?B?a1lhUG1QUXhQN2JOL2FBeWtGRFpqeTI1eE92a3hIcW1mOHI0akpzVlFnaVlP?= =?utf-8?B?QUN6ZE1lRmJFdzJma0FCRXEwNTBOZ2dWejhtc3ozbWl1MnIydCtBQVFaRW9Y?= =?utf-8?B?TWE3cUlmZEVBWE11akZ3RnBCWDc1Z0RWR2V5YlMycTZtUUlSUU4zQVc2SVhm?= =?utf-8?B?cVRFTkJyeTdtTVRyWkJLV1o2QXRhTDF4bDNoOWJtSzBjc3l4TEw4aFA5OGxy?= =?utf-8?B?NitaOXB1MTVGOVlQdDJwc0R5VDNQV203ejJVOXJiRU5QZVNTdUx2VFdOOUZn?= =?utf-8?B?MlMxZHNXcHd1RGhGSVptMERaeWxXTEZTenA1LzhnSjZTQjVRY3cyWUVRekx5?= =?utf-8?B?L29pUDBuU09lRVVuQlpFN1Z4Smk2NC81VWhveTJVT1N4V0crRkRadkdoM3dB?= =?utf-8?B?WFN4ZGlVaFozcXV0MVQyTHp3SEZERFIza1BvUlY2RlZ2dzRHeDBFQ0pSdjhk?= =?utf-8?B?ZGxDcEZCMGFXUUV0dzBJU2t2akdlbzA4bFAvSDh1NE5pVjhlbTNiWFpGdVBz?= =?utf-8?B?MXkyNmw2VWtiWWpUWkZGU2JQV1hveUdVMzJVcTl4UFJwS1dlM2RZQlg4eFB4?= =?utf-8?B?bjR5a2pCSnFrd2hzckozdW41NDhBOXM0MFhtaWVlRk56YlJCUEZNK1Y1OHdC?= =?utf-8?B?eFdSODUweFdpUzBIRDcvSy9NbVFWcmNFcDFWMXBJRVV5eWdEZ2h4eUdMeGcx?= =?utf-8?B?VlUzNURMeEtsSTNCUFRQNmhkemlPTm5IYTMxdzNtbDNXdm0wSlJ5QnZIT0NR?= =?utf-8?B?M3gyR2FKTkJDL1lUSysxZFNTNmJsT0FhL0piWWlxVHA2eXN6akNLNDYySG1r?= =?utf-8?B?T1pHVUl4aDFSTWt5N2FVWmZEMnVYS0ZKekNYNjZOd2NkT1l3MEhsYWlaV3Bt?= =?utf-8?B?WkJxOFlmVDdMRC9qUGpLV0tPQ0ZYUGVHaVB6TmlZYXZKYis2UTFtRmJYUUlw?= =?utf-8?B?OEN3OE9sRFkxZ2lUMndVWkcvOE0zWnBZdXhFSDEyY2F5TG1oMFdNamlpQ3k5?= =?utf-8?B?eWxiTVNZMGliSDRFVHQ5cXg1aU9oWHFyci9jMzdiS2JwQXJVNFozcWVOeGJw?= =?utf-8?Q?0WI0dvJY/ykZtiMUfPK6SSfTY?= X-OriginatorOrg: rocha.red X-MS-Exchange-CrossTenant-Network-Message-Id: 9b8882fb-127a-4585-3deb-08daaa95defa X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6767.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 08:03:10.0698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2c16853d-bf35-4b77-abbf-d72bc4d340dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O6jzoYYBB4YXtsZIDKejbsRaCJtHDtz1sCOA80wF/WfKU5Jwm56AU4MdqUahzDSCaW+2Nh3hBn4bjBwOpfaizw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5119 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Oct 8, 2022 at 4:37 PM Carl Eugen Hoyos wrote: > Am Sa., 8. Okt. 2022 um 10:39 Uhr schrieb Julio C. Rocha : > > > > On Sun, Oct 2, 2022 at 4:48 PM Julio C. Rocha wrote: > > > > > --- > > > configure | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/configure b/configure > > > index 6712d045d9..f5f5eb29dd 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -4847,7 +4847,12 @@ probe_cc(){ > > > else > > > _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d > '\r') > > > fi > > > - _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | > > > awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > > (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > > + if [ "$(grep -i Microsoft /proc/version)" ]; then > > > + # Windows Subsystem for Linux > > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< > 2>&1 > > > | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > > (!match($$0, / /)) { cmd="/usr/bin/wslpath \x27" $$0 "\x27"; cmd |& > getline > > > pth; print "$@:", pth } }'\'' > $(@:.o=.d)' > > > + else > > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< > 2>&1 > > > | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > > (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > > + fi > > > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs' > > > _cflags_speed="-O2" > > > _cflags_size="-O1" > > > -- > > > 2.37.0 (Apple Git-136) > > > > > > > > Hi! I'd like to re-request feedback for this patch. > > > > To clarify, it allows building FFmpeg using MSVC over WSL, without any > > dependency on MinGW or MSYS. > > Hi Carl. I'm new to building FFmpeg, so need to make some follow-up questions. > You write in your own explanations "Succeeds" - this and what the patch > is meant to fix are missing from your commit message. > Should I resubmit the patch from scratch with an improved commit message? > Your patch would not work here - sadly, cl.exe does not print "including" > for all installations. > Can you please elaborate? If I understand correctly, you are saying older versions of CL.EXE would not print "including". Wouldn't that also be an issue for the non-WSL case currently existing in the configure script?: else _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' To finish this point, what sort of installations would fail with the proposed patch? > I build FFmpeg regularly with wsl and msvc and others do as well. > Dependency files are simply empty here (because cl.exe prints > "Einlesen der Datei" here). Do you still rely on msys/mingw packages? This patch tries to address this by removing such dependency. How can I configure FFmpeg to ignore/leave empty the dependency files? > Dependency generation works for me with --dep-cc=clang-cl.exe but > I normally just build without it. > > Using clang-cl may not be an option when the software to be integrated with a specific FFmpeg build expects binary compatibility with plain MSVC. Looking forward to applying the suggestions once clarified. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".