From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 453D644257 for ; Tue, 4 Oct 2022 00:29:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D8EDC68BC13; Tue, 4 Oct 2022 03:29:05 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2077.outbound.protection.outlook.com [40.107.94.77]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D44368B9E7 for ; Tue, 4 Oct 2022 03:28:58 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AahZuwOxFzmflgWelLqn7WrGwC6spYjdC7J15aFqQZBod9ekgiUfmTIGG0UW102DoHOG48qWe3+GEJ8nHGdAbo2pP9fXrnqoH+8vi+Om1QJdcLBnLtpbrAsf6ex6XCO4y+5Xx/Bya6cL61jcmRDqcmp0fuNgNZZ6htNeKZPY45GUD61SI7vV1QcbpmqyMg36Aku54Uh9L91qgUuP+kQ59GrlEhDjVvOU3Kavqd89XjE+aSYt7PRnmbv5CPa/bxssZw89oICKt1HCL4rv+iW34torp2W3Q6zj0jrT99AJa/IwuEXXXhviFI3qwyup5j5WxUhzCi8rnHc4lFeoEjOfOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2zeXbQdMYk8UBdXD4yLhvh/V8Kgg9nYhe+88f1vWsdc=; b=A2C5OiH/GA+d4Q7ShHC1SQYmZLSI0Quo7mVDVmGYPfoneG+xUMXVY/jQxUFVbCQdUylkYpwg+gA3wGNfGyprrNJMyOo3NbzkvD9wjcoFIylVruz20bvAmA3/L8nqVhzrhrS2LaLSTGFTLj9yT608TgPwR9R0Cl8jEBjb3ECF786ELIr8tsVumD/JNtHLsv3wDSgi+iQ5D+t5C+TgAGc2RmDuo6AFecT1FSDiQKRW39vFQPA5hUxkqmrIUx1Bp474/KKguwyl+cQTL0Rx8P3mIBpqlDEap26ADU65o+fLNduJ1UosyQM/LAybdjdvWT263MvVI4FNryRLOjCHVq2P+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=rocha.red; dmarc=pass action=none header.from=rocha.red; dkim=pass header.d=rocha.red; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rocha.red; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2zeXbQdMYk8UBdXD4yLhvh/V8Kgg9nYhe+88f1vWsdc=; b=Q9TgylvKBOo0BEnjByBGUNTjINAWglmWzOEqVovlUpZIbZdavG9Q4yVIkbHXwpN2BR8rH/s08MNNStA9N7rsFkmVjR67ShmJgAd1QX1jMjMXHjLchhslNwiBTKRDaYd5Y8Sa5BhsOyK581rAKh3qw8ofHeniWK6hbabPXI7BLgwgax1jy6MckEdmPzfM/VW8qtMiM93bOlPJ6QpTO+gNUS/YMBjx9bZTaAcWBmFoVfUBTkH4oO7zUOvHcIze1LOp+FhhtDnTG9IHid6GyMTlO8e06/K0GJeDghoSG8eHr2TMyV87ojb/DZtAXbFCxR4B6bQtqCXCDUpMwlqGipw2bA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=rocha.red; Received: from MN2PR04MB6767.namprd04.prod.outlook.com (2603:10b6:208:1e7::23) by BYAPR04MB3864.namprd04.prod.outlook.com (2603:10b6:a02:b1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct 2022 00:28:52 +0000 Received: from MN2PR04MB6767.namprd04.prod.outlook.com ([fe80::c935:131d:5dac:944b]) by MN2PR04MB6767.namprd04.prod.outlook.com ([fe80::c935:131d:5dac:944b%9]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 00:28:52 +0000 X-Gm-Message-State: ACrzQf0eqVmgpJ+y5AodVEtBFZx3e9zsoUSOKlXNzrQkNEdz7umwxnv7 zEDY6841SkqR9zNgYYyEUII8wM098MYQDtTlwg== X-Google-Smtp-Source: AMsMyM6OgwhezIucnssuQC3LgDsyWyuSpbAv2EcG4fTVg/EM2zsqDlQhF+ylT3bB3Bj5C6v9UzD1RQ6ZxTgZgNqRtSE= X-Received: by 2002:a05:6512:4024:b0:4a2:ec0:c887 with SMTP id br36-20020a056512402400b004a20ec0c887mr6263664lfb.680.1664843326378; Mon, 03 Oct 2022 17:28:46 -0700 (PDT) References: <20221002234755.3354-1-dev@rocha.red> <20221002234755.3354-2-dev@rocha.red> <81454a2b-417e-9ff3-36d1-c02b7be4271b@rothenpieler.org> In-Reply-To: From: "Julio C. Rocha" Date: Mon, 3 Oct 2022 17:28:35 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-ClientProxiedBy: GV3P280CA0068.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::20) To MN2PR04MB6767.namprd04.prod.outlook.com (2603:10b6:208:1e7::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR04MB6767:EE_|BYAPR04MB3864:EE_ X-MS-Office365-Filtering-Correlation-Id: e7fe0bc9-bda8-4bf5-f00d-08daa59f698c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OMrTDqImhnQnPQdj0HkPZIyZY2r4XFW2i4gzxMccg/q1uik640HrfAHZj+uNqY3XYn9p1RCzua2TUgU3FyMkBczk1/FDoXSjzhMPmq/+nZwqMMSUenwV/aqi7E+s1Xg1wG9FGmJI7oklhDyJoSqGbgzLH+NXnR5JFu6ZBnVY0xc3xYVcSFPo4kN3MiwJzyxqHe/kEnKHYlGq80xuxO9pTdoVCrtzsWH0ufzm4WMnOtc0aO+MfuwmcnZJ/nYMn4HBSEcFzwYBX8an0GEHnYAWmXvtp3J1trC1KRybGwB1gENt3CcWOlB3iv5Dw+h3m7loMXRnr+oNz49Mn1QHZTGr97TUEr877VGy9tH1rDAMoRdwH9QP0yTlRaMRBmfKVWFD9Pv3puEUL+MhVsVYKYUEfMbhoM7rRuSgDT1/kRn1Hpm984V6FvBNpays8kTWjqCGj6adC6O4bI4LEEqP3uFZ3889AIkrk8hL4YvNdQSTWppfUKke63qfbwGqb8cldpkIwRc7iHm71AJLvIkHLARTahGxcMIJmHCjQ06rO9szYgRElO/wGhl90zzo72qGHaFhyRpOZkiJ9KPsYeafdQpk1042rVg+4DbtkOk3RFXOFFXXp+xFgAvr+RUVx0fCy+6jQwHgp1R0mzTDzDJz1xRfOpHnx4AUSzdHhG571gixr0Py/pC32HPGUK00w1xISL73VNSm3ZLTl9yzxdW31iLUXp26mmJ+7O9Gdz/5x4Do4PPT6rv8BO/ElEBb15fZr9WIhk6udxt7usMnUbsbiHy1RSFeS8lTxE/NsZ7umC+/ZAIpznotCFloq9lRB2oOaiJ+ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6767.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39830400003)(396003)(366004)(136003)(376002)(346002)(451199015)(53546011)(45080400002)(66946007)(8676002)(66476007)(66556008)(6916009)(52116002)(33964004)(316002)(6506007)(19627235002)(26005)(5660300002)(478600001)(186003)(6512007)(2906002)(9686003)(966005)(83380400001)(6486002)(41300700001)(8936002)(55236004)(6666004)(55446002)(166002)(38100700002)(38350700002)(460985005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFAxMXBYeXNJcTRtNWpBa0VucjkwSFR4WHY3UWFRVXdaSHAyaUY1a1Y4bUJB?= =?utf-8?B?dDZac1Z0SUtLTkxGRW5wZ2hhRVAvZjBsZEV6OU9LNGJBS1BraTMxQ2lieE9Y?= =?utf-8?B?SmlGbnFOZUVQdGt3N0xXZDA1NWpQUmVvVERFbnBHYXgzV2hSSTF2NXBLOFpa?= =?utf-8?B?SktUMFNCcHpmVXZZRUtjZnQ0M2F1U21rU2lTZk1QaktGVTdFYnFtalAzTWxP?= =?utf-8?B?V2tMc2puUVhLMlh5MFZqb2VUMXpCZk9LUll0QjJOQjNueVFlRGx4TG9lUmlt?= =?utf-8?B?T3lBcXpXUjhyaEkwYzlIZmxpYXRqOGJzaDBacDJOSzk3MTNnWkE0SkhKcmZJ?= =?utf-8?B?djk3OHVMYTVWWXE1NWhqSEsvMHo5eTF0TXVNR0RWVE5nWWw3ZG1JSVAwTW5F?= =?utf-8?B?Y0h3NEZEZ1pmaEVXUVRPK0pqdW1DV1pqZDB4d3RJK2JrQ3RUK0tQN3RWQU9Z?= =?utf-8?B?aWZSVzhvTGxYMWR6Slo1SEV5UHVTWlptQUxQSzdORFZ5c2tXK0lQZUo2OURx?= =?utf-8?B?V0lTR0JZY3YzTE5OL0l6R0hYZk54MnVyWjRsTTdrWGx3YmF6clZnK1VSZ0Rk?= =?utf-8?B?YzV1L1UzVG5TK1FQeEMrYVZkVFN2bXhIbm5qcXRTUmFUMk5oenFQejREcGVo?= =?utf-8?B?TGxzV1gxdWdDZ3I0Qm9QSTljTGpMVnVXUEN0bXpWU0RCUlU1R2s4R29mOERR?= =?utf-8?B?VWVJU25EMytzeXpFckdXczRPK0g5Y3ZGc3hEMzJqVk8xZHlGMnlJbXZKZ21W?= =?utf-8?B?M0FQeDRqdzl6NXpnSjdKMUUzQTFHVXBTZXJicVhwZllvY3NKZFoyK0VRUHBT?= =?utf-8?B?RENLc0dlS2ZaZWoySE5ETkhKdVFHUG5QMjZPT0o0QUNQTWUzOWIxeDM3c2ZD?= =?utf-8?B?R3FoRFd2d2pIZzhhMWdScmpZSVpZWjJIM3JFYXNCSUV2ZDRLMkJPeWdWTS9M?= =?utf-8?B?dGVKb0h5MW45bm1BT3BwQU5Vb1VadjBzRFFhRjlGb1ZJb2NJVWozSFVMekpI?= =?utf-8?B?RXkyeTd4N3ZBOWJJM1lDOTIwZ2pBWjQ1d1hZRjU0SG85VFhrR3Q0aVl2ME02?= =?utf-8?B?VVZvZHJnTlN5Z3BlWHVyM3dDVWo4a0VPR294STdNZ1RjQXk5c1hTMVJiNzVZ?= =?utf-8?B?U3N5NHhSeCtMNVNtM3NlRncxOFBjWnF4VUwzOVd0WmVUQmxwQ3N0WnFwUUFz?= =?utf-8?B?czBiNnJyd1R0QzNvdno2K3ZRa3lNQnhZQ2ViRzVHdG9pUjFEU3dhQ1RsMUd4?= =?utf-8?B?ZCtWODc2ckNoWDZoNHNaRVEyWHd6S0JxcjN6VU1ncXJBdTFPeStUYXpxb1gx?= =?utf-8?B?UWNKQjhmeVV1NTNDOUJQUUdGZ2FLS2dNYm1QMzBndUJNSkNCbWJZS3c4ME91?= =?utf-8?B?QWsvMUdKUnhqNlVkbUt5MTA2TGU1REFvYXNWVy83SFpOWERjVVlUc0R5VFpa?= =?utf-8?B?YW9NNmVqZ0dKbi9NdERiVGRwM1U0d1d4cGpBajF0bENGdUUwdGNSWHdqZnNs?= =?utf-8?B?SlhFMHFoT2YvTDVZc0Z4VTBEb3VCNmxCR1hwT1dIaHZuUWhqM2hsMU1aUG5R?= =?utf-8?B?VFhBQVRTMG1KcmF1d2d2TkY5RTU3MDk0eC9iV0N5d3VBUThYN0FvcDJTZVhS?= =?utf-8?B?ckVvT08rdFlFUFhTZktPUnl3cmZvR1daYS9lS0k3bGtBZzhkS3NDOVNzRjM2?= =?utf-8?B?SUhtSEQ2SkxyOWdLTjRVNEoyRG5kd2FHajdnVUh1bkNFWWVONkNrQkI3MUE0?= =?utf-8?B?TXhrdnRaSDUrbWo5MEcvdGJXRGlUU1p1VnBVQjhzU3ZBSG1rcklERmxDNnVy?= =?utf-8?B?NmkzNk5jYmwrZjlqM2dZdVBzby9EZEFhOU93NmswT0FJbG1oZ1J4RHpRYTdM?= =?utf-8?B?cElSYlAxUTNESXl1UUh0L2VsRjZMd3FxTXZFSmswN1d1cVZtcVZqSWt5SUto?= =?utf-8?B?ckRnZTM1NndGV0tSTG1Edy8xYWEyYU52Y0RjbUJWWmFaeERyV1JXSkQ3eVk2?= =?utf-8?B?SURKQTN0dlQwblFKT2d2SVdIc1ZKN0dHMDF4MGhkOVkyRnVLZUNsNWt0eklD?= =?utf-8?B?ZzhxdzhkTFBsditiQzFZUU40NVpjUGlwMkQ3QVQ5bnh6d2tudk1tRUxLVnh3?= =?utf-8?Q?VxodaR4Y4peGUCnbgBbKRWtfV?= X-OriginatorOrg: rocha.red X-MS-Exchange-CrossTenant-Network-Message-Id: e7fe0bc9-bda8-4bf5-f00d-08daa59f698c X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6767.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 00:28:51.9947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2c16853d-bf35-4b77-abbf-d72bc4d340dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yZ1TPPbpf9p8jK/F3SvxTyWInKZx7lIVyEQh9ZrZpHiP9DBkj0tCPlW4deoAU6Ce88XD0LTrU+JG0pVgllJ8Tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3864 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Oct 3, 2022 at 8:21 AM Pierre-Anthony Lemieux wrote: > On Mon, Oct 3, 2022 at 1:11 AM Julio C. Rocha wrote: > > > > On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux > > wrote: > > > > > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler < > timo@rothenpieler.org> > > > wrote: > > > > > > > > On 03.10.2022 01:47, Julio C. Rocha wrote: > > > > > --- > > > > > configure | 7 ++++++- > > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/configure b/configure > > > > > index 6712d045d9..f5f5eb29dd 100755 > > > > > --- a/configure > > > > > +++ b/configure > > > > > @@ -4847,7 +4847,12 @@ probe_cc(){ > > > > > else > > > > > _ident=$($_cc --version 2>/dev/null | head -n1 | tr > -d > > > '\r') > > > > > fi > > > > > - _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< > 2>&1 > > > | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > > (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > > > > + if [ "$(grep -i Microsoft /proc/version)" ]; then > > > > > > > > Not convinced that this is a good check. > > > > I can think of a few other situations where Microsoft might appear in > > > > there. Like, for example on one of their servers, Azure Cloud, Github > > > > Actions and so on. > > > > > > > > > + # Windows Subsystem for Linux > > > > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) > $< > > > 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > > (!match($$0, / /)) { cmd="/usr/bin/wslpath \x27" $$0 "\x27"; cmd |& > getline > > > pth; print "$@:", pth } }'\'' > $(@:.o=.d)' > > > > > + else > > > > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) > $< > > > 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > > (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > > > > + fi > > > > > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs' > > > > > _cflags_speed="-O2" > > > > > _cflags_size="-O1" > > > > > > > > > > > > What actual issue is this solving? > > > > I've been building in WSL for years, including MSVC builds, and never > > > > encountered any problems. > > > > > > FWIW. I am currently building on WSL: > > > > > > $ uname -a > > > Linux pal-xxxxx 5.10.102.1-microsoft-standard-WSL2 #1 SMP Wed Mar 2 > > > 00:30:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux > > > > > > $ lsb_release -a > > > No LSB modules are available. > > > Distributor ID: Ubuntu > > > Description: Ubuntu 20.04.4 LTS > > > Release: 20.04 > > > Codename: focal > > > > > > > Noted, Pierre. > > Are you able to build using the Visual Studio compilers (MSVC) without > any > > further hacking? > > I had never tried it. Quick attempt results in: > > $ ./configure --toolchain=msvc > cl.exe is unable to create an executable file. > If cl.exe is a cross-compiler, use the --enable-cross-compile option. > There are a couple of missing steps: 1. Enter the Visual Studio Developer Command Prompt (or Native Tools Command Prompt). See https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022 2. Add the following entries to the `WSLENV` environment variable (so the necessary paths are passed to the wsl instance): CommandPromptType DevEnvDir ExtensionSdkDir EXTERNAL_INCLUDE INCLUDE LIB LIBPATH UCRTVersion UniversalCRTSdkDir VCIDEInstallDir VCINSTALLDIR VCToolsInstallDir VCToolsRedistDir VCToolsVersion VisualStudioVersion VS170COMNTOOLS VSCMD_ARG_app_plat VSCMD_ARG_HOST_ARCH VSCMD_ARG_TGT_ARCH VSCMD_ARG_VCVARS_VER VSCMD_ARG_winsdk VSCMD_VER VSINSTALLDIR VSSDK150INSTALL VSSDKINSTALL WindowsLibPath WindowsSDK_ExecutablePath_x64 WindowsSDK_ExecutablePath_x86 WindowsSdkBinPath WindowsSdkDir WindowsSDKLibVersion WindowsSdkVerBinPath WindowsSDKVersion 3. Start WSL from that command prompt. 4. Go to the ffmpeg clone. 5. ./configure --toolchain=msvc 6. make Succeeds, because it only generates the .d files without using them this first time around. 7. make install Or clean, or pretty much any other subsequent make target. Will fail with the following message: doc/print_options.d:1: *** target pattern contains no '%'. Stop. Looking into doc/print_options.d (or any other generated .d file), contents are like this: doc/print_options.o: D:/Extra/ffmpeg/wsl/libavutil/attributes.h ... Such paths work fine with CYGWIN, but not with a real Linux userland (such as WSL). Running ./configure with this proposed patch fixes the issue, generating .d files with content like this: doc/print_options.o: /mnt/d/Extra/ffmpeg/wsl/libavutil/attributes.h _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".