From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 636F1443C5 for ; Thu, 8 Sep 2022 17:03:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86FF868BAB0; Thu, 8 Sep 2022 20:03:39 +0300 (EEST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 189E468B441 for ; Thu, 8 Sep 2022 20:03:34 +0300 (EEST) Received: by mail-ej1-f49.google.com with SMTP id y3so39585393ejc.1 for ; Thu, 08 Sep 2022 10:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=OYy06blR7Stmzxtzb8VatYiMWysVIYllVFXg77fguIc=; b=MAS4FPxxgrDN13b6w3GGyTmv1PS/FtwBstiONSFY8ZVm75JXsiQLNqEkQ3OmbvCjq8 LEjWnqEq3+JKVwLVKs4iLWgLlaiEp5ORP12/9qtux48jVusQU1ld+ASYMaOdd/biFOh2 D8PDgrdmGLp8i/KYlIaPoaooLg2fePFvcyyaBrpiMaYv0XSwqidUqF1W9lnTPVd1gpnq Asg4tqOX3ygOyHpDdPYD97mgOYbQuo8iKKVCvr/FAxQmIEelryFwydkRtjilgVtE7sdR R7eMy4r22KSzKFK+IDxMD4m3XrOsve15RnX9gUvO+42TiD3qicP62DlrYPq6nwOzW1Ug ymbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=OYy06blR7Stmzxtzb8VatYiMWysVIYllVFXg77fguIc=; b=sMGzH/CVwPDQfFi3pVltIbX2td5SyFmA6+/YdfQ+GOC+RS1l1Xq2vUcXKBNVrsseRV KTtZAgyIY0rwQJkRBcmwsJkvF1fed+GwZVDh0iyUUZm4fGUXnUBNPOCOK+EuvpKlemDO ikO/kgwQpdvoEFiTFgaKrjLjqdTqMFszp6M9j58WfT43WLEK8vfCBUvU1M9A9u8OPjHx eRq+W2IhNYejqT7Uv7lcGuaQJ34tobYJXCcu3j6zDBUFZHfqY62wJSL90JSMwDkR7GXM Zf+R1FTPI+L7O8cZgGMkv3VE4cmnDvI+U55H5vuqBMa/9tbgLn0exXGJwCq/SeNnC3XH 70Hw== X-Gm-Message-State: ACgBeo35K3WXc/BLaatBBNZyRhA7JJXLNx2ljHw5YKSg27ju05Rmxvb5 UkMtlLRRRJ2iKYBRvb6dhG84ccCukU95dgJj707nodoZMNk= X-Google-Smtp-Source: AA6agR6lQ/W0GBs770cViD3s+8xrl952G/axGgzb0ulJL8jNMC0Zyq4Ow7Xy0tR0HvwW89lSQAXbwkyq7INh4h+nfbY= X-Received: by 2002:a17:907:a0c7:b0:739:7ea:88ec with SMTP id hw7-20020a170907a0c700b0073907ea88ecmr6742646ejc.363.1662656612747; Thu, 08 Sep 2022 10:03:32 -0700 (PDT) MIME-Version: 1.0 References: <20220417172658.GN3529341@pb2> <20220906214704.704687-1-izadi@google.com> <0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com> <20220908163119.GY2088045@pb2> In-Reply-To: <20220908163119.GY2088045@pb2> From: Mohammad Izadi Date: Thu, 8 Sep 2022 10:03:21 -0700 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael, I appreciate it if you can take a look and give me your feedback. On Thu, Sep 8, 2022 at 9:31 AM Michael Niedermayer wrote: > On Wed, Sep 07, 2022 at 02:12:46PM +0100, Derek Buitenhuis wrote: > > On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > > > + if (side_data && side_data_size > 0) > > > + > ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, > &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size); > > > > You can't use ff_-prefixed functions across library boundaries. > > > > It nees to be either public (av*) or avpriv. I suspect people won't want > it to > > be avpriv. > > > > Personally, I think having serialization as a public API is useful, but > YMMV. Mostly > > because I was just writing my own serialization to make use of the > exported side data :P. > > I agree > > on a related subject, side data serialization should be moved to a common > API > We have common APIs for parsers, decoder, bitstream filters but for > parsing/decoding side data this is heading toward something less structured > > Above is not a comment on this patch, the patch is fine. I just want to > point > to this before we have several dozen such functions which need to be > deprecated and supported when a more structured system is introduced > > thx > > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Into a blind darkness they enter who follow after the Ignorance, > they as if into a greater darkness enter who devote themselves > to the Knowledge alone. -- Isha Upanishad > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".