From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B0A48432B6 for ; Tue, 25 Oct 2022 23:39:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B225A68BC19; Wed, 26 Oct 2022 02:39:08 +0300 (EEST) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0808A68BA61 for ; Wed, 26 Oct 2022 02:39:02 +0300 (EEST) Received: by mail-io1-f41.google.com with SMTP id r142so11917068iod.11 for ; Tue, 25 Oct 2022 16:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=YmDxtWUOjbwHmqQ3MMRJ2WAvYusPckxxhSQFXJpXLNs=; b=RIzfF4Ppd8DjUG1gfqsuZgDS13JWqxOtahorIsmePGajw7Rode9CgbuJ3XtwYV3bqB HMzIRTAHLEdw9CNBa7M+DGvrLNSIHODNps3DNrLHTirbcb+45GW4DQHEup7mLGIPNKXF GqQ+zGe91G/nVmHvT2KeKjFlL7Ed7cokiSiO4l3uS6wWKBfXFOMWJXfUSVJOrD/1BkEn zlt2XjuoWe58vEfeorKzNXUHEAwjTME70QJnT92NmuzQqZ0QF/UY9+uqPNy/jeOuOq/2 ck0Xc77eklC22WRziiYE0I8S/ntwZRgge4iLW97isY6uBIzz9IgXSYmrA3+zPKgnliM2 bSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YmDxtWUOjbwHmqQ3MMRJ2WAvYusPckxxhSQFXJpXLNs=; b=d27p6oqTYJU6u0reQE9qF5cWquESM5hpQvZ8LbOiYF1sxIKSgs51NNzBFcdqOjNhbg Mq81S9UAoilQ5G9DqySt03Xw4N7fUEgHplrTOCoYZ69LlriVoQcffj4eiaYABoc4bcvc XxKaD8P9CNfOQCTDlFrXz7whI3hyYr5bltmTpCI/dPlikmieDyJxVzLfjlKkTHJpCzGo ZLEZalZ4mIBbW+68x3cIILoKDZjk95Pxhsz2BMhuh6U/BelXSM7rAGE+Bki6br6XZSVu zj3thHOssgGfvTApV441yzTBnkTLMSyWW8b3LsUEHHPQ1FNpRynXEbZbxXvEt098xdqb RZFg== X-Gm-Message-State: ACrzQf3xG2Tu6bvumC1SeDPAAG7yUwI4WsRPJv6BcVDPw/PldqEODWUL /ifZcBxz2bxivC+tOy+JI52POKiVUTx7+hZOx7aIp7y4mWjW+A== X-Google-Smtp-Source: AMsMyM6R49rJouM2DYZpp0sKUeDKunSN34n2ldZeu3l8JK4NliaQJReCiQUJiL6FK1jIJwToOTPOPhLW3OYiBWZglkg= X-Received: by 2002:a5d:965a:0:b0:6a4:5999:fb9e with SMTP id d26-20020a5d965a000000b006a45999fb9emr23455175ios.89.1666741140607; Tue, 25 Oct 2022 16:39:00 -0700 (PDT) MIME-Version: 1.0 References: <20220417172658.GN3529341@pb2> <20220906214704.704687-1-izadi@google.com> <0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com> <20220908163119.GY2088045@pb2> In-Reply-To: From: Mohammad Izadi Date: Tue, 25 Oct 2022 16:38:48 -0700 Message-ID: To: FFmpeg development discussions and patches , Thierry Foucu X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael, I appreciate it if you can take a look and give me your feedback. Thanks, Mohammad On Thu, Sep 8, 2022 at 10:03 AM Mohammad Izadi wrote: > Michael, I appreciate it if you can take a look and give me your feedback. > > > On Thu, Sep 8, 2022 at 9:31 AM Michael Niedermayer > wrote: > >> On Wed, Sep 07, 2022 at 02:12:46PM +0100, Derek Buitenhuis wrote: >> > On 9/6/2022 10:47 PM, Mohammad Izadi wrote: >> > > + if (side_data && side_data_size > 0) >> > > + >> ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, >> &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size); >> > >> > You can't use ff_-prefixed functions across library boundaries. >> > >> > It nees to be either public (av*) or avpriv. I suspect people won't >> want it to >> > be avpriv. >> > >> > Personally, I think having serialization as a public API is useful, but >> YMMV. Mostly >> > because I was just writing my own serialization to make use of the >> exported side data :P. >> >> I agree >> >> on a related subject, side data serialization should be moved to a common >> API >> We have common APIs for parsers, decoder, bitstream filters but for >> parsing/decoding side data this is heading toward something less >> structured >> >> Above is not a comment on this patch, the patch is fine. I just want to >> point >> to this before we have several dozen such functions which need to be >> deprecated and supported when a more structured system is introduced >> >> thx >> >> >> [...] >> -- >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >> >> Into a blind darkness they enter who follow after the Ignorance, >> they as if into a greater darkness enter who devote themselves >> to the Knowledge alone. -- Isha Upanishad >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".