* [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.
@ 2022-05-19 20:42 Mohammad Izadi
2022-05-31 17:06 ` Mohammad Izadi
2022-05-31 17:17 ` Ronald S. Bultje
0 siblings, 2 replies; 4+ messages in thread
From: Mohammad Izadi @ 2022-05-19 20:42 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Mohammad Izadi
ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support YCGCO as input. Added YCOCG to the inputs.
---
libavfilter/vf_colorspace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
index 3c8b3b20eb..bccd04528e 100644
--- a/libavfilter/vf_colorspace.c
+++ b/libavfilter/vf_colorspace.c
@@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = {
ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"),
ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"),
ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"),
+ ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"),
ENUM("gbr", AVCOL_SPC_RGB, "csp"),
ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"),
ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"),
--
2.36.1.124.g0e6072fb45-goog
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.
2022-05-19 20:42 [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace Mohammad Izadi
@ 2022-05-31 17:06 ` Mohammad Izadi
2022-05-31 17:17 ` Ronald S. Bultje
1 sibling, 0 replies; 4+ messages in thread
From: Mohammad Izadi @ 2022-05-31 17:06 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Thierry Foucu
FYI
On Thu, May 19, 2022 at 1:42 PM Mohammad Izadi <izadi@google.com> wrote:
> ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support
> YCGCO as input. Added YCOCG to the inputs.
> ---
> libavfilter/vf_colorspace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
> index 3c8b3b20eb..bccd04528e 100644
> --- a/libavfilter/vf_colorspace.c
> +++ b/libavfilter/vf_colorspace.c
> @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = {
> ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"),
> ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"),
> ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"),
> + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"),
> ENUM("gbr", AVCOL_SPC_RGB, "csp"),
> ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"),
> ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"),
> --
> 2.36.1.124.g0e6072fb45-goog
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.
2022-05-19 20:42 [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace Mohammad Izadi
2022-05-31 17:06 ` Mohammad Izadi
@ 2022-05-31 17:17 ` Ronald S. Bultje
2022-06-01 15:12 ` Vittorio Giovara
1 sibling, 1 reply; 4+ messages in thread
From: Ronald S. Bultje @ 2022-05-31 17:17 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Mohammad Izadi
Hi,
On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi <
izadi-at-google.com@ffmpeg.org> wrote:
> ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support
> YCGCO as input. Added YCOCG to the inputs.
> ---
> libavfilter/vf_colorspace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
> index 3c8b3b20eb..bccd04528e 100644
> --- a/libavfilter/vf_colorspace.c
> +++ b/libavfilter/vf_colorspace.c
> @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = {
> ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"),
> ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"),
> ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"),
> + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"),
> ENUM("gbr", AVCOL_SPC_RGB, "csp"),
> ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"),
> ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"),
> --
> 2.36.1.124.g0e6072fb45-goog
>
Could you elaborate on why you think AVCOL_SPC_YCGCO might be missing from
the LumaCoefficients table? Is this a typo/mixup? Should it be added?
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.
2022-05-31 17:17 ` Ronald S. Bultje
@ 2022-06-01 15:12 ` Vittorio Giovara
0 siblings, 0 replies; 4+ messages in thread
From: Vittorio Giovara @ 2022-06-01 15:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Mohammad Izadi
On Tue, May 31, 2022 at 7:17 PM Ronald S. Bultje <rsbultje@gmail.com> wrote:
> Hi,
>
> On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi <
> izadi-at-google.com@ffmpeg.org> wrote:
>
> > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only
> support
> > YCGCO as input. Added YCOCG to the inputs.
> > ---
> > libavfilter/vf_colorspace.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
> > index 3c8b3b20eb..bccd04528e 100644
> > --- a/libavfilter/vf_colorspace.c
> > +++ b/libavfilter/vf_colorspace.c
> > @@ -906,6 +906,7 @@ static const AVOption colorspace_options[] = {
> > ENUM("smpte170m", AVCOL_SPC_SMPTE170M, "csp"),
> > ENUM("smpte240m", AVCOL_SPC_SMPTE240M, "csp"),
> > ENUM("ycgco", AVCOL_SPC_YCGCO, "csp"),
> > + ENUM("ycocg", AVCOL_SPC_YCOCG, "csp"),
> > ENUM("gbr", AVCOL_SPC_RGB, "csp"),
> > ENUM("bt2020nc", AVCOL_SPC_BT2020_NCL, "csp"),
> > ENUM("bt2020ncl", AVCOL_SPC_BT2020_NCL, "csp"),
> > --
> > 2.36.1.124.g0e6072fb45-goog
> >
>
> Could you elaborate on why you think AVCOL_SPC_YCGCO might be missing from
> the LumaCoefficients table? Is this a typo/mixup? Should it be added?
>
from pixfmt.h
AVCOL_SPC_YCGCO = 8, ///< used by Dirac / VC-2 and H.264 FRext,
see ITU-T SG16
AVCOL_SPC_YCOCG = AVCOL_SPC_YCGCO,
this input option seems redundant, in which use case do you strictly need
it?
thanks
--
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-01 15:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 20:42 [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace Mohammad Izadi
2022-05-31 17:06 ` Mohammad Izadi
2022-05-31 17:17 ` Ronald S. Bultje
2022-06-01 15:12 ` Vittorio Giovara
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git