From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 301374AEEC for ; Tue, 25 Jun 2024 12:38:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE45068D3BB; Tue, 25 Jun 2024 15:38:31 +0300 (EEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D36EE68CBC0 for ; Tue, 25 Jun 2024 15:38:25 +0300 (EEST) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2c81ce83715so3158375a91.3 for ; Tue, 25 Jun 2024 05:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719319104; x=1719923904; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VToEEK27VrtHCiVo1ESZPaoAkRGUjl1OiLQ949MyaAI=; b=gmot1fP0NlQ9NX/79QA2+ZJSwvTFHoYVzJiIRfKnqKajY/cqSH437a/gZEk45i/FdO UzGFvK7MOp4F2tD9Cb+klVQqkA833q3fC4Tolh++/35CtrTi8CGZrDodVvABlxyMWDWo vzg1iF00uaABtPf+rBrswD4DAybnrRBgZaYVRfoDaf7qu/G4vfkMIR4sxobkqzUEDkfR 7aUkDPgljoWEYXI6IlpXHfzzc+4K0/W1qkR/HfQYihUJBrp/1e7aBlThhK82Djs4m1br ES6nIFQR9tFEakjsDwrTq2jogWo0yl3JGiqwWcSadk2B+KJWNrafFI2dfMhfSvdpFEG/ MoJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719319104; x=1719923904; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VToEEK27VrtHCiVo1ESZPaoAkRGUjl1OiLQ949MyaAI=; b=Eg23JnBSpvq8ZaTTT0LtxjfIYauBsF90Cm2JP3/WCMELDZVVCsLIvPT4JM85iMMUbe ZCi2OGv6bb/y+LV6Dwj/X+QfFTKFUMVbLuseAi/cn0lF16X57hBVEq3AA67nHzGG+dUV UOH6bOQdZUr1tOQbKHu2kle3leD7vU6LdBQrMulhw3YqEGNzmqSjyV7QQHClFOfWievM 9H3Aoq8wtxPB2zV4M6wJn9+Y1YidYgDemsjf2ztiNCZ1M2h1qeOhIatU33sCSx7BgBGc DZ0BK00vgJICd1Xo5dZPFPWfQhSzbH1spZsKlFQwu2U6lAqGy45VNNrn+Gr1szT/DI0h VSqA== X-Gm-Message-State: AOJu0Yxq4AMJl+/vteJ7vuhqSmyGbRflqGijHt9fhcBEKD+pXVHZYHJh U2HSYM4cIMy0A10TGw73h2qtcoAotwc0cUa1PDtoFE5/bX9pC6dfnbXrB19+8AhY+l3+D9HoGP4 7yDPxlV1d9r3Gm3yBQ3sz0TKzwY7ukw== X-Google-Smtp-Source: AGHT+IGjonTvWTnAIjSz2PHfQeKqIXmW+Fa8w6wf/hQX7MwbbBhUcPtWK/m7AVNW6R2voGoX2xmnLUVvskqbo1Z724w= X-Received: by 2002:a17:90a:7444:b0:2c8:84b:580e with SMTP id 98e67ed59e1d1-2c85829734amr6795920a91.41.1719319103026; Tue, 25 Jun 2024 05:38:23 -0700 (PDT) MIME-Version: 1.0 References: <20200624201636.24828-1-onemda@gmail.com> <129aa6d8-10c2-d955-d0a7-2c2370037bce@gmail.com> <8f34accb-9723-f539-eb93-e4db821bd87f@gmail.com> In-Reply-To: From: Dennis Mungai Date: Tue, 25 Jun 2024 15:37:46 +0300 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 28 Jun 2020 at 16:59, James Almer wrote: > On 6/27/2020 7:54 AM, Paul B Mahol wrote: > > On 6/26/20, James Almer wrote: > >> On 6/26/2020 4:16 PM, Lynne wrote: > >>> Jun 26, 2020, 19:05 by jamrial@gmail.com: > >>> > >>>> On 6/26/2020 1:58 PM, Paul B Mahol wrote: > >>>> > >>>>> On 6/26/20, James Almer wrote: > >>>>> > >>>>>> On 6/26/2020 1:13 PM, Paul B Mahol wrote: > >>>>>> > >>>>>>> On 6/26/20, Paul B Mahol wrote: > >>>>>>> > >>>>>>>> On 6/24/20, Paul B Mahol wrote: > >>>>>>>> > >>>>>>>>> Signed-off-by: Paul B Mahol > >>>>>>>>> --- > >>>>>>>>> Please test it and reports benchmark results on non toyish GPUs. > >>>>>>>>> > >>>>>>>> > >>>>>>>> Please, I really need it! > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Why nobody wants to help? > >>>>>>> > >>>>>>> This makes me really really sad. > >>>>>>> > >>>>>> > >>>>>> I can try. Can you give an example command line with a publicly > >>>>>> available sample? > >>>>>> > >>>>> > >>>>> You can use any sample, samples are irrelevant. just report > resolution > >>>>> used. > >>>>> Also compare with CPU solution with just v360 filter. > >>>>> > >>>>> For yuv420p inputs: > >>>>> > >>>>> ffmpeg -init_hw_device vulkan=vulkan -i INPUT -filter_hw_device > vulkan > >>>>> -vf > >>>>> > hwupload,v360_vulkan=fisheye:e:ih_fov=180:iv_fov=180:w=2048:h=1024,hwdownload,format=yuv420p > >>>>> -f null - > >>>>> > >>>>> ffmpeg -i INPUT -vf > v360=fisheye:e:ih_fov=180:iv_fov=180:w=2048:h=1024 > >>>>> -f null - > >>>>> > >>>>> Just make sure that you get same output resolution in both cases. If > >>>>> not, adjust w/h accordingly. > >>>>> > >>>> > >>>> I'm getting a segfault on vkGetInstanceProcAddr, and i don't know if > >>>> it's your filter or some issue in the driver. gdb is not being > helpful. > >>>> _______________________________________________ > >>>> ffmpeg-devel mailing list > >>>> ffmpeg-devel@ffmpeg.org > >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >>>> > >>>> To unsubscribe, visit link above, or email > >>>> ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe". > >>>> > >>> > >>> Can you test again but replace EXT_EXTERNAL_HOST_MEMORY in > >>> optional_device_exts > >>> with EXT_NO_FLAG? > >> > >> Applying > >> > >>> diff --git a/libavutil/hwcontext_vulkan.c > b/libavutil/hwcontext_vulkan.c > >>> index 5e51d0390f..49fb7827ba 100644 > >>> --- a/libavutil/hwcontext_vulkan.c > >>> +++ b/libavutil/hwcontext_vulkan.c > >>> @@ -228,7 +228,7 @@ static const VulkanOptExtension > optional_device_exts[] > >>> = { > >>> { VK_EXT_EXTERNAL_MEMORY_DMA_BUF_EXTENSION_NAME, > >>> EXT_EXTERNAL_DMABUF_MEMORY, }, > >>> { VK_EXT_IMAGE_DRM_FORMAT_MODIFIER_EXTENSION_NAME, > >>> EXT_DRM_MODIFIER_FLAGS, }, > >>> { VK_KHR_EXTERNAL_SEMAPHORE_FD_EXTENSION_NAME, > >>> EXT_EXTERNAL_FD_SEM, }, > >>> - { VK_EXT_EXTERNAL_MEMORY_HOST_EXTENSION_NAME, > >>> EXT_EXTERNAL_HOST_MEMORY, }, > >>> + { VK_EXT_EXTERNAL_MEMORY_HOST_EXTENSION_NAME, > >>> EXT_NO_FLAG, }, > >>> }; > >>> > >>> /* Converts return values to strings */ > >> > >> I still get a segfault: > >> > >>> Thread 1 received signal SIGSEGV, Segmentation fault. > >>> 0x00007ff8ed9274c0 in vkGetInstanceProcAddr () > >>> from > >>> > C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_ccad5caddc3a3d35\nvoglv64.dll > >> > >> Debug output shows > >> > >>> [AVHWDeviceContext @ 000001532a762800] GPU listing: > >>> [AVHWDeviceContext @ 000001532a762800] 0: GeForce GTX 1660 > (discrete) > >>> (0x2184) > >>> [AVHWDeviceContext @ 000001532a762800] Using queue family 0 (total > queues: > >>> 16) for graphics > >>> [AVHWDeviceContext @ 000001532a762800] QF 0 flags: (graphics) > >>> (compute) (transfers) (sparse) > >>> [AVHWDeviceContext @ 000001532a762800] Using queue family 2 (total > queues: > >>> 8) for compute > >>> [AVHWDeviceContext @ 000001532a762800] QF 2 flags: (compute) > >>> (transfers) (sparse) > >>> [AVHWDeviceContext @ 000001532a762800] Using queue family 1 (total > queues: > >>> 2) for transfers > >>> [AVHWDeviceContext @ 000001532a762800] QF 1 flags: (transfers) > >>> (sparse) > >>> [AVHWDeviceContext @ 000001532a762800] Using device extension > >>> "VK_EXT_external_memory_host" > >>> [AVHWDeviceContext @ 000001532a762800] Using device extension > >>> VK_EXT_external_memory_host > >>> [AVHWDeviceContext @ 000001532a762800] Using device: GeForce GTX 1660 > >>> [AVHWDeviceContext @ 000001532a762800] Alignments: > >>> [AVHWDeviceContext @ 000001532a762800] > >>> optimalBufferCopyRowPitchAlignment: 1 > >>> [AVHWDeviceContext @ 000001532a762800] minMemoryMapAlignment: > >>> 64 > >> > >> And crashes right after printing: > >> > >>> [Parsed_v360_vulkan_1 @ 000001532abd5c80] Shader v360_compute linked! > >>> Size: 5508 bytes > >> > >> I'm using the latest driver, 451.48, on Windows 10 2004. > > > > So other vulkan filters, like vulkan_chromaber works for you? > > All fail the same way in vkGetInstanceProcAddr, so the issue is in > hwcontext. > > Lynne should be able to test/bench this filter. > Hello Paul, et al, Any updates on this filter? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".