From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9A075496E1 for ; Sat, 18 May 2024 12:40:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 26E2168CEC8; Sat, 18 May 2024 15:40:37 +0300 (EEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D1CAF68CCE7 for ; Sat, 18 May 2024 15:40:30 +0300 (EEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1ee0132a6f3so35365835ad.0 for ; Sat, 18 May 2024 05:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716036028; x=1716640828; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ajZ8kansvu66TO8duklm4lDJk5Qe9TZFe9oS80u8gAc=; b=FhsLtQ7Ukk2tnTin7mvr5n46sMSKMofkQU55leCAK0VEj8V3eJHVAM8koJp783HuUS HDJE03CXq6GPFDsaF7U8nsxTuHuMIFLaFrX/3S9HeKj/+v2+rJWtm2DGDRr4wAzPK3/N 4h9kyEPhgyRALq5YT/n6G9yB3+BhrUqB6VY91NNo4ufCvmkly35w0CxVBoIapN2psEcn S2gYcPW7ngMR4MRUIZIOto8UGc2OBbY8xocQL5z3M8/sbeLyzDPav9JaXIfcpGmBZCNV +RT2OXgWRhlECW02DSOUZ7VZsadZOpiVYuVrYY7cv7S25SpSb6eEcI4cv07d94b8OvKa NSBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716036028; x=1716640828; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ajZ8kansvu66TO8duklm4lDJk5Qe9TZFe9oS80u8gAc=; b=mjdUL1DKXS5GV+uYtaP1TbGqMLEbq1LFntD25g87xsSWKKEUfsOffEx2v+AKTafRmE 49YBuW7jb/axB+pDAPAJfmwjWPyMS5rfUT7KNHtlqke4Vj+H69buskuvkyuApxdWplSJ Mz1h6Th3d+c7Z50DJuTT42VUvhoEn9NgNqOYKOBHr8cFReYIINRaiwt2PVoXZkm7MZGC U97DnZ8k9QoT0cHYw3G5Yo7b4lj7Y9vTZI8xa2SBqsohV8XrD3rvlSkuzrNLuE7YU+6+ s8SSVcxPTjt2d244UebU9D6AGLW/kqekxPQWiVnwQI3hQ/+Am3FClUYl0VZMYJiP0rmZ 9NIg== X-Gm-Message-State: AOJu0Yx4Zr0iVzAfBug8NsWaNssLPW+33pAVInvxxUV+J7qaTKbvDrds gx78iI3+IHQuI3d/RkvsctAvzqsqb/RncgnjkdUMC9bL/AtEQENkbN0RUn+T83YcK18ufqKs9uJ tueDcAal8lY2lLRioF0kf9TAth2AXQTqK X-Google-Smtp-Source: AGHT+IHTXttm3ILXWhzS4Sizz5oeOYfRS8YMtqv9JElHeX0mi0GH/Y3s14FtY0fMHrKoMXaJzaNfJbP+1zlI1CFnRuQ= X-Received: by 2002:a17:90a:f98d:b0:2b4:6584:1be4 with SMTP id 98e67ed59e1d1-2b6cc77eff6mr22340033a91.21.1716036028111; Sat, 18 May 2024 05:40:28 -0700 (PDT) MIME-Version: 1.0 References: <82c8dff4-2bd6-47e1-8615-dcc5e29815f7@comstyle.com> In-Reply-To: <82c8dff4-2bd6-47e1-8615-dcc5e29815f7@comstyle.com> From: Dennis Mungai Date: Sat, 18 May 2024 15:40:16 +0300 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 18 May 2024, 14:27 Brad Smith, wrote: > Can this be backported to 7, 6, 5 and 4.4 releases? > > On 2024-05-05 11:59 p.m., Brad Smith wrote: > > lavd/v4l2: Use proper field type for second parameter of ioctl() with > BSD's > > > > The proper type was used until 73251678c83cbe24d08264da693411b166239bc7. > > > > This covers all of the OS's that currently have V4L2 support, > permutations > > of Linux glibc/musl, Android bionic, FreeBSD, NetBSD, OpenBSD, Solaris. > > > > Copied from FreeBSD ports patch. > > > > Signed-off-by: Brad Smith > > --- > > libavdevice/v4l2.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c > > index 3706582bc6..74f43ef6a9 100644 > > --- a/libavdevice/v4l2.c > > +++ b/libavdevice/v4l2.c > > @@ -108,10 +108,10 @@ struct video_data { > > int (*open_f)(const char *file, int oflag, ...); > > int (*close_f)(int fd); > > int (*dup_f)(int fd); > > -#ifdef __GLIBC__ > > - int (*ioctl_f)(int fd, unsigned long int request, ...); > > -#else > > +#if defined(__sun) || defined(__BIONIC__) || defined(__musl__) /* > POSIX-like */ > > int (*ioctl_f)(int fd, int request, ...); > > +#else > > + int (*ioctl_f)(int fd, unsigned long int request, ...); > > #endif > > ssize_t (*read_f)(int fd, void *buffer, size_t n); > > void *(*mmap_f)(void *start, size_t length, int prot, int flags, > int fd, int64_t offset); > _". > Seconded, a backport would be ideal for prior releases. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".