From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0C3CB45BD8 for ; Sat, 25 Mar 2023 00:32:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3220368C934; Sat, 25 Mar 2023 02:32:46 +0200 (EET) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D73AE68C90D for ; Sat, 25 Mar 2023 02:32:39 +0200 (EET) Received: by mail-io1-f50.google.com with SMTP id bf15so1476494iob.7 for ; Fri, 24 Mar 2023 17:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679704358; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=H6iDj4/5U3IAPu/1ZIOSisw1z/LIiFXladI2kz+K0i4=; b=ZMYUAEhbX3yN4K50fyP0o/Pw1y/GpKY19mEHDlhzfo5u0OWq44nOyn9gO5QcGNlTJo wp2zAQfCliCpCNicXogvqkKdCXqWCAdfZfYbmG5FEJgC1qk9TV8WM/WUNJjt9s/dfXIY 0AosQv6oUWGcipVPdlba2uEiYKdqbA0Ld8Gz9VfaYRLWlTGaXu3EEpOa0gLvmQJhy06H QJNLW8xiEo7V1jVr9KJ4etZxygERuJb8B3ueNh3BQ3H312AiJK4XOE7CzFAJ6WU4cfaF EONuW2025pR7Jf/4aQdI9Ge6jpV1/IoK8DzoR6jcG88XzSd0TNS49HL+hxdrT01MXDWK JFdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679704358; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H6iDj4/5U3IAPu/1ZIOSisw1z/LIiFXladI2kz+K0i4=; b=N2YGqP09V5EGIDIHjQR0ACJd0pTh80q/KyOPpXWU393ictdafdFg7aeMscQ2/UJ8V+ G2bN+msPB/nG3X3LKfzabVRhkjxTxJatY1qfm5XwXXL69WpFj8u2d2WeqNDxF8Huvqmx ghC1gKeZo4g2HeI0y7qtdRj8f78AuT7GWM3+FPlHq2fjNR2S+85lSkxEKspaJfc1SCEm fJbPbw87qQ9bZh2tAkUzxLc3Sr6/PueqDKO+Pvg+45S1zAMpEXEFxm/f4/WW4JbPFvk/ 7xfz/iWiMZcYC98MkP9Ihl33jigZeNZU4c6A4PRKfB8CHpxrcJnRnLd7PLiTkr8NFGwr SRKA== X-Gm-Message-State: AO0yUKVqHmAh46No/FmziSDd2oKz4BY2AJDjBp9Wm9Ha5HlOr7YAOMdw Pgc7nWlk1NVtgAQ5XYQS04agReut90bGNRUKNOa2cjXtVhw= X-Google-Smtp-Source: AK7set89XFFy8modEF7qqCndmG2mAVIODqfd+rCTEn21p1pgGtElpwceXtXw9zqFCOgVQ+eTaQy7D6vIDcl70CJP+Is= X-Received: by 2002:a02:298a:0:b0:3ca:61cc:4bbc with SMTP id p132-20020a02298a000000b003ca61cc4bbcmr1753145jap.2.1679704357667; Fri, 24 Mar 2023 17:32:37 -0700 (PDT) MIME-Version: 1.0 References: <20230324161458.819260-1-ullysses.a.eoff@intel.com> In-Reply-To: <20230324161458.819260-1-ullysses.a.eoff@intel.com> From: Dennis Mungai Date: Sat, 25 Mar 2023 03:32:01 +0300 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi: add hwdevice flag to hwupload/hwmap X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "U. Artie Eoff" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 24 Mar 2023 at 19:15, U. Artie Eoff < ullysses.a.eoff-at-intel.com@ffmpeg.org> wrote: > This fixes a regression introduced by: > > commit 3f63685c3554aea7f72bab1fdbde440820816d37 > and > commit 632c34993195f716e9fa575af3de80d07fd50991 > > ...where command-lines like: > > ffmpeg -v verbose -hwaccel qsv \ > -init_hw_device qsv=qsv,child_device=/dev/dri/renderD128 \ > -hwaccel_output_format qsv -f rawvideo -pix_fmt yuv420p \ > -s:v 352x288 -r:v 25 -i input.yuv \ > -vf 'format=nv12,hwupload=extra_hw_frames=120' \ > -an -c:v h264_qsv -y output.h264 > > ffmpeg -v verbose -hwaccel qsv \ > -init_hw_device qsv=qsv,child_device=/dev/dri/renderD128 \ > -hwaccel_output_format qsv -f rawvideo -pix_fmt nv12 \ > -s:v 352x288 -r:v 25 -i input.yuv \ > -vf > 'format=nv12|qsv,hwupload=extra_hw_frames=16,vpp_qsv=procamp=1:saturation=1.0,hwdownload,format=nv12' > \ > -pix_fmt nv12 -f rawvideo -fps_mode passthrough -an -y output.yuv > > ...produced errors like: > > [hwupload @ 0x55b6171d0dc0] A hardware device reference is required to > upload frames to. > [Parsed_hwupload_1 @ 0x55b6172053c0] Query format failed for > 'Parsed_hwupload_1': Invalid argument > Error reinitializing filters! > Failed to inject frame into filter network: Invalid argument > > Signed-off-by: U. Artie Eoff > --- > libavfilter/vf_hwmap.c | 1 + > libavfilter/vf_hwupload.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/libavfilter/vf_hwmap.c b/libavfilter/vf_hwmap.c > index 2e03dfc1fec7..e246b22603b5 100644 > --- a/libavfilter/vf_hwmap.c > +++ b/libavfilter/vf_hwmap.c > @@ -427,4 +427,5 @@ const AVFilter ff_vf_hwmap = { > FILTER_OUTPUTS(hwmap_outputs), > FILTER_QUERY_FUNC(hwmap_query_formats), > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > + .flags = AVFILTER_FLAG_HWDEVICE, > }; > diff --git a/libavfilter/vf_hwupload.c b/libavfilter/vf_hwupload.c > index dbc41734ccc3..ef61bb413757 100644 > --- a/libavfilter/vf_hwupload.c > +++ b/libavfilter/vf_hwupload.c > @@ -258,4 +258,5 @@ const AVFilter ff_vf_hwupload = { > FILTER_OUTPUTS(hwupload_outputs), > FILTER_QUERY_FUNC(hwupload_query_formats), > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > + .flags = AVFILTER_FLAG_HWDEVICE, > }; > -- > 2.38.1 > > > Related, The two mentioned commits above also broke hwupload use with CUDA. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".