From: Dennis Mungai <dmngaie@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: "Dennis Sädtler" <dennis@obsproject.com>, "Timo Rothenpieler" <timo@rothenpieler.org>, ffmpeg@gyani.pro Subject: Re: [FFmpeg-devel] [PATCH v3] movenc: Add an option for resilient, hybrid fragmented/non-fragmented muxing Date: Mon, 24 Jun 2024 12:42:33 +0300 Message-ID: <CAKKYfmF9hnxHNJskC=G0VQu-0O-sy7frxDLJYa0URa8RUxFNzA@mail.gmail.com> (raw) In-Reply-To: <4ec91c51-2941-84cc-1bef-54a0bd6f5648@martin.st> On Mon, 24 Jun 2024, 11:24 Martin Storsjö, <martin@martin.st> wrote: > On Thu, 20 Jun 2024, Dennis Sädtler wrote: > > > On 2024-06-20 15:47, Timo Rothenpieler wrote: > >> On 20/06/2024 15:46, Martin Storsjö wrote: > >>> On Wed, 19 Jun 2024, Martin Storsjö wrote: > >>> > >>>> This allows ending up with a normal, non-fragmented file when > >>>> the file is finished, while keeping the file readable if writing > >>>> is aborted abruptly at any point. (Normally when writing a > >>>> mov/mp4 file, the unfinished file is completely useless unless it > >>>> is finished properly.) > >>>> > >>>> This results in a file where the mdat atom contains (and hides) > >>>> all the moof atoms that were part of the fragmented file structure > >>>> initially. > >>>> --- > >>>> v3: Renamed the option to hybrid_fragmented. > >>>> --- > >>>> doc/muxers.texi | 11 ++++++ > >>>> libavformat/movenc.c | 62 +++++++++++++++++++++++++++++++--- > >>>> libavformat/movenc.h | 4 ++- > >>>> libavformat/version.h | 4 +-- > >>>> tests/fate/lavf-container.mak | 3 +- > >>>> tests/ref/lavf/mov_hybrid_frag | 3 ++ > >>>> 6 files changed, 78 insertions(+), 9 deletions(-) > >>>> create mode 100644 tests/ref/lavf/mov_hybrid_frag > >>> > >>> If there are no more comments on this one, I'll go ahead and push it > soon. > >> > >> +1 from me > > > > Sounds good to me as well. > > Pushed now, thanks for all the input! > > // Martin > Thanks for the patch, this resolves multiple issues with fragmented output even when FFmpeg exits suddenly. Retesting shortly with fmp4 + tee muxer(s). > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-24 9:42 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-19 13:06 Martin Storsjö 2024-06-20 13:46 ` Martin Storsjö 2024-06-20 13:47 ` Timo Rothenpieler 2024-06-20 14:12 ` Dennis Sädtler via ffmpeg-devel 2024-06-24 8:24 ` Martin Storsjö 2024-06-24 9:42 ` Dennis Mungai [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKKYfmF9hnxHNJskC=G0VQu-0O-sy7frxDLJYa0URa8RUxFNzA@mail.gmail.com' \ --to=dmngaie@gmail.com \ --cc=dennis@obsproject.com \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=ffmpeg@gyani.pro \ --cc=timo@rothenpieler.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git