Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: deiwo deiwo <deiwo101@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] avfilter/adelay - interactive commands
Date: Tue, 18 Jan 2022 18:58:26 +0100
Message-ID: <CAKEaJ+GwBk0pwqVz3rWVr6Zx760YJzo8wJnNx_MmMsf7j5sS8Q@mail.gmail.com> (raw)
In-Reply-To: <CAPYw7P5KoZ0v9_B36D3mGjRwEKHih4PvBjCFwSf=6hHrfuXo5w@mail.gmail.com>

Yes, I am aware of that fact. The changes are more proof of concept than
anything else.
What is missing is also proper command parsing, because the numbers can
have suffixes defining their resolution as is in the config_input()
function, where for each channel a different delay can be specified.
In that case the given functionality can be taken out to separate function
to be used by the config_input() and by the process_command().
I can implement the missing pieces if you decide to move forward with these
changes.

ut 18. 1. 2022 o 18:38 Paul B Mahol <onemda@gmail.com> napísal(a):

> On Tue, Jan 18, 2022 at 6:10 PM deiwo deiwo <deiwo101@gmail.com> wrote:
>
> > Hi,
> > I have created a proof of concept. Please check if it makes sense and
> has a
> > potential to get merged.
> > I did not know whether it would make sense to send it as a patch, so for
> > now a pastebin link:
> > https://pastebin.com/nAxRj4C9
>
>
> Delays can be different for each channel.
>
>
>
> >
> >
> > Thanks,
> > David Lacko
> >
> > ut 18. 1. 2022 o 10:09 deiwo deiwo <deiwo101@gmail.com> napísal(a):
> >
> > > Similar to how one can change volume in the volume filter when there
> is a
> > > zeromq filter preceding the volume filter, then it's possible to send
> > > zeromq commands to the volume filter and change the volume dynamically
> > > (while the ffmpeg is running).
> > > In the case of adelay filter the delay could be changed dynamically,
> when
> > > the user would increase the delay, additional silence would be added
> and
> > > the sample buffer would increase, and when the user would decrease the
> > > delay some samples would be skipped in the sample buffer and the buffer
> > > size would decrease.
> > >
> > > The usage for this would be beneficial for live streams, for example
> when
> > > changing the delay of an audio channel requires complete restart of the
> > > ffmpeg.
> > >
> > > ut 18. 1. 2022 o 9:22 Paul B Mahol <onemda@gmail.com> napísal(a):
> > >
> > >> On Mon, Jan 17, 2022 at 11:02 PM deiwo deiwo <deiwo101@gmail.com>
> > wrote:
> > >>
> > >> > Hello,
> > >> > I would like to ask if it makes sense to implement ZeroMQ
> interactive
> > >> > commands for the adelay filter, from the performance and memory
> point
> > of
> > >> > view.
> > >> > If it does make sense then is it possible to malloc/free/realloc
> > memory
> > >> > within the command processing function? Can it cause noticeable
> delays
> > >> in
> > >> > the stream outputs?
> > >> >
> > >> > I am new to the ffmpeg development so I am sorry if this kind of
> > >> question
> > >> > does not belong to this mailing list.
> > >> >
> > >> >
> > >> I fail to see how that would work. Please elaborate your idea.
> > >>
> > >>
> > >>
> > >> > Thanks for the response,
> > >> > David L
> > >> > _______________________________________________
> > >> > ffmpeg-devel mailing list
> > >> > ffmpeg-devel@ffmpeg.org
> > >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >> >
> > >> > To unsubscribe, visit link above, or email
> > >> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > >> >
> > >> _______________________________________________
> > >> ffmpeg-devel mailing list
> > >> ffmpeg-devel@ffmpeg.org
> > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >>
> > >> To unsubscribe, visit link above, or email
> > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > >>
> > >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-01-18 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 22:02 deiwo deiwo
2022-01-18  8:23 ` Paul B Mahol
2022-01-18  9:09   ` deiwo deiwo
2022-01-18 17:10     ` deiwo deiwo
2022-01-18 17:38       ` Paul B Mahol
2022-01-18 17:58         ` deiwo deiwo [this message]
2022-01-18 18:25           ` Paul B Mahol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKEaJ+GwBk0pwqVz3rWVr6Zx760YJzo8wJnNx_MmMsf7j5sS8Q@mail.gmail.com \
    --to=deiwo101@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git