From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FAF640465 for ; Tue, 21 Dec 2021 00:38:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5C7668AFF5; Tue, 21 Dec 2021 02:38:45 +0200 (EET) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B8B9568AF54 for ; Tue, 21 Dec 2021 02:38:38 +0200 (EET) Received: by mail-ua1-f51.google.com with SMTP id u40so20796752uad.1 for ; Mon, 20 Dec 2021 16:38:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lSm5Uy9jObHHUfLzLMJGhMK0utndt51kxLbYvPtUZaA=; b=mJ+XmcpYkt+aXda88L4gyaSqL+AE9KAvA6JtPZhBHFSoBMzb9/aXCHiRTKefY8o3Wg 94/0rOgRHQA528ma+hFF4Vtd4b2NXH3qCrYRpKFD22B10fBveK8K/sl1z+4YqQjldhsV uJ9DH76V/gR75W2DVp+/ta8dbqrard2pkhVM/B6vs0POBbZV/d3fTLI5xnkJCnu3QaOi YgxepnfLMT3QTBdnlUZ08xXlF21n4SAlqCOSxas+Icgeorh6spB/SArGfnP6+i+HCWJx 925YgVCUi3yRe70CzKWoLBm2W8avcZNNTTEa0KyC6dxommBe3rkZp5O9BcOu9XuIud4Q jySg== X-Gm-Message-State: AOAM533nKQTpClM8HGIpB3rE8I9YKMIoeH0i0wZC5g6buZSIUUvCkVqe rWwn+sZLO7qCmK+D53jMeLalt/Tdl+Umeseujw1aYDCHeyl4Iw== X-Google-Smtp-Source: ABdhPJy/qE7x1PBG10FH1WsWTFH5MeUl7O/jLuuhlsIMyiowkMSN+9pcLLZ7ZcXNADc37X7s6GZNYZXy/liEOFojBoE= X-Received: by 2002:a67:d51e:: with SMTP id l30mr329063vsj.1.1640047116908; Mon, 20 Dec 2021 16:38:36 -0800 (PST) MIME-Version: 1.0 References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> In-Reply-To: From: Aman Karmani Date: Mon, 20 Dec 2021 16:38:25 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Dec 20, 2021 at 4:12 PM Christopher Degawa wrote: > On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek < > tessarek@evermeet.cx> > wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA512 > > > > Hello, > > > > The following 2 commits break the build with a deployment target of 10.9 > on > > macOS. > > > > I agree that 10.9 is quite old, but the rest of the code worked perfectly > > fine, so were those 2 commits really necessary? > > > > * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add > > vf_yadif_videotoolbox (Aman Karmani) > > * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities > > (Aman Karmani) > > > > Can you make that code conditional? > > > > To tack on to this, I currently am also experiencing issues with those > commits, but am running on 10.15, however, my issue isn't necessarily that > the code isn't compiling, but rather it seems it's failing to link with > > xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o > libavfilter/metal/vf_yadif_videotoolbox.metal.air > air-lld: error: library not found for -lmetal_rt_osx_air2.2 > metal: error: air-lld command failed with exit code 1 (use -v to see > invocation) > make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1 > > currently running a fresh clone of FFmpeg and only ran ./configure and then > make. If I run > > xcrun metal > > -L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin > libavfilter/metal/vf_yadif_videotoolbox.metal -o > libavfilter/metal/vf_yadif_videotoolbox.metal.air > > then it succeeds, I don't think there's currently a way to export LDFLAGS > to metal as the rule for it is a simple `$(METALCC) $< -o $@` > > So I've exported "LIBRARY_PATH" to > > "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin" > in the profile since I can't easily update that on all of my CI > configurations. > Could you share the output of `xcrun metal -v` > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".