From: Aman Karmani <ffmpeg@tmm1.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS
Date: Mon, 20 Dec 2021 16:38:25 -0800
Message-ID: <CAK=uwuzh2HRUdO=+zRzWcJnusv20GuXNJkeH6oEJM2X1i-0Low@mail.gmail.com> (raw)
In-Reply-To: <CABDPGrwWubQbyx=Wsg7mjWQky4CY3W0YZAtBjTLpD4vqcFYO3w@mail.gmail.com>
On Mon, Dec 20, 2021 at 4:12 PM Christopher Degawa <ccom@randomderp.com>
wrote:
> On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek <
> tessarek@evermeet.cx>
> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> > Hello,
> >
> > The following 2 commits break the build with a deployment target of 10.9
> on
> > macOS.
> >
> > I agree that 10.9 is quite old, but the rest of the code worked perfectly
> > fine, so were those 2 commits really necessary?
> >
> > * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
> > vf_yadif_videotoolbox (Aman Karmani)
> > * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
> > (Aman Karmani)
> >
> > Can you make that code conditional?
> >
>
> To tack on to this, I currently am also experiencing issues with those
> commits, but am running on 10.15, however, my issue isn't necessarily that
> the code isn't compiling, but rather it seems it's failing to link with
>
> xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air
> air-lld: error: library not found for -lmetal_rt_osx_air2.2
> metal: error: air-lld command failed with exit code 1 (use -v to see
> invocation)
> make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1
>
> currently running a fresh clone of FFmpeg and only ran ./configure and then
> make. If I run
>
> xcrun metal
>
> -L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin
> libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air
>
> then it succeeds, I don't think there's currently a way to export LDFLAGS
> to metal as the rule for it is a simple `$(METALCC) $< -o $@`
>
> So I've exported "LIBRARY_PATH" to
>
> "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin"
> in the profile since I can't easily update that on all of my CI
> configurations.
>
Could you share the output of `xcrun metal -v`
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-21 0:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:30 Helmut K. C. Tessarek
2021-12-20 23:25 ` Ridley Combs
2021-12-20 23:49 ` Helmut K. C. Tessarek
2021-12-21 0:06 ` Ridley Combs
2021-12-21 0:13 ` Helmut K. C. Tessarek
2021-12-21 0:11 ` Christopher Degawa
2021-12-21 0:38 ` Aman Karmani [this message]
2021-12-21 0:43 ` Christopher Degawa
2021-12-21 0:50 ` Aman Karmani
2021-12-21 0:54 ` Helmut K. C. Tessarek
2021-12-21 0:52 ` Helmut K. C. Tessarek
2021-12-21 0:54 ` Aman Karmani
2021-12-21 1:18 ` Christopher Degawa
2021-12-21 1:24 ` Aman Karmani
2021-12-21 1:31 ` Christopher Degawa
2021-12-21 1:28 ` Ridley Combs
2021-12-21 1:35 ` Christopher Degawa
2021-12-21 1:03 ` Helmut K. C. Tessarek
2021-12-21 1:20 ` Aman Karmani
2021-12-21 1:35 ` Helmut K. C. Tessarek
2021-12-21 1:39 ` Ridley Combs
2021-12-21 2:31 ` Helmut K. C. Tessarek
2021-12-21 1:48 ` Christopher Degawa
2021-12-21 1:52 ` Aman Karmani
2021-12-21 6:04 ` Christopher Degawa
2021-12-21 7:39 ` Ridley Combs
2021-12-21 18:04 ` Christopher Degawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=uwuzh2HRUdO=+zRzWcJnusv20GuXNJkeH6oEJM2X1i-0Low@mail.gmail.com' \
--to=ffmpeg@tmm1.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git