From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A1A02400B0 for ; Sun, 19 Dec 2021 16:37:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCE1F68AEE7; Sun, 19 Dec 2021 18:37:39 +0200 (EET) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9738268A842 for ; Sun, 19 Dec 2021 18:37:33 +0200 (EET) Received: by mail-ua1-f51.google.com with SMTP id r15so13640043uao.3 for ; Sun, 19 Dec 2021 08:37:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=qY3LcAk2Gr5OpEyiBiLHotO+/FeApA4EjHqn8bxcBDw=; b=UhdBmgg5RBTfuqiIuwvRQLuSf68XgpG2n/yz4pYa9yDGBwZ9tK64zwxuoF5eiBDz2k 6zNPzUgt7Ox6FXvH3dXDu0AG7UC8LKuAoA8xXShka5nxoRzQ+hx0nAqJlUoM5MAin2b4 V+vYYT2xzQJHH/PoTVM7zlUeNMFMNpAhN2y3GBnUYuB4oqXuVXi78tzONKAl7XQk2XHW CxG1UrIc1Ff3HdtsZadsAkNn3dJt1LiIasngvVCdAQ3E6zwvxWf0Ivuwpy1pfSSLcBLJ htrH2GnHYWHqjwhyNE2rVU7KyIPsHGpP6m+qDT2vpuDqn8EvL6G0JS6v0Dn7bTdBi2oO ZBYQ== X-Gm-Message-State: AOAM531XzpPhiFtgfQhDdZjkJfwWF7YuWTX8AvZ3Lgv3F9nGetumjOM0 hEDI7iOfv2pWZJAkfVIcHFeKh/QsgAQ732AJc7gOBYpiFFY= X-Google-Smtp-Source: ABdhPJwyVidCVXQLKBGO/aXpdCnV5lobbLKb9EUCiK6rTratUH3eUOoKmm7HaDevlmYDRjwOLbJyBL/gk93PCnFPyU8= X-Received: by 2002:a9f:2383:: with SMTP id 3mr3684354uao.77.1639931851904; Sun, 19 Dec 2021 08:37:31 -0800 (PST) MIME-Version: 1.0 References: <20211218215319.84070-1-rcombs@rcombs.me> In-Reply-To: <20211218215319.84070-1-rcombs@rcombs.me> From: Aman Karmani Date: Sun, 19 Dec 2021 08:37:20 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/videotoolboxenc: use the correct types for options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Dec 18, 2021 at 1:53 PM rcombs wrote: > These are all set by AV_OPT_TYPE_INT or AV_OPT_TYPE_BOOL; the only reason > they worked before was that this is only used on little-endian. > --- > libavcodec/videotoolboxenc.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index 8237bd0ec5..5f1e3a9b9c 100644 > --- a/libavcodec/videotoolboxenc.c > +++ b/libavcodec/videotoolboxenc.c > @@ -227,14 +227,14 @@ typedef struct VTEncContext { > int64_t dts_delta; > > int64_t profile; > - int64_t level; > - int64_t entropy; > - int64_t realtime; > - int64_t frames_before; > - int64_t frames_after; > - > - int64_t allow_sw; > - int64_t require_sw; > + int level; > + int entropy; > + int realtime; > + int frames_before; > + int frames_after; > + > + int allow_sw; > + int require_sw; LGTM > double alpha_quality; > > bool flushing; > -- > 2.33.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".